From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77DE1CD4F25 for ; Thu, 14 May 2026 10:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EU7kB8GhnsIdEVRjiN2ofby6ssMzPxoJIC6XMGFWR+8=; b=kq5Ik/eEZWmIET PPbVEer4Qd9jj3+KFtI1cu9UFk1yb+XPowTgVVJU1foLqpQWLer40t8mzxin6/mTjn0gkxI9dg6fU +K5kDDJN/nqlLFxM5OEkT4tMdVzd5h/EgR0tpbYBUsf+cwUiyG+WOgSEotEgzq8TyDFpNJXHn4WCM H0pOH0pRPwozbarQU1j0Ga6swySCs6rS5jRSXXNFwTB4lCPQxWewIZmh6ODsTUHBcXnfAthHht+xw 1A83C44G9iggVxktr42c9607S0p1htDKO53y8oB5Rr1Yyz9HpINexOe0GlkxKNq20bQ6cTlbWE+7r YTt7JFgIAW8RgbCEeUCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNSue-000000058U8-1lBG; Thu, 14 May 2026 10:03:28 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNSuc-000000058Tl-35rq; Thu, 14 May 2026 10:03:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id BD4E760121; Thu, 14 May 2026 10:03:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5E16C2BCB3; Thu, 14 May 2026 10:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778753005; bh=eU1EYUyxKUydlQNJ+xAxAssRfVy3MHIEswP/6qw7geQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hjRggEcJoBqqvzhAfk8uDlGzbN+fWIEB6v9ayYO/nj6a0TGULZA//piez8JarOJjL QGd2G0jTgrkp7UCh1FI/NYiYPknn4sfrluQi+c3KkHMOII6jtwkFtgkEgdIa7UlHwv i9XrOj+t1VihC1qq2MaMankZACs8/fK97sDtFI4zWQ05VYwXIwDFkcLCXe2vqzi9Ua dXawt8bbnTX9W1PD2nE/Nzo7OumP3goQJk8WbroACgRKDEOKywszgPwg4LKVJOkQ3W HxcafGHjgtPVJWLEgJSqgirVk5PtxP26mGLuR4a5pLZ81urqyPvZ7PzDvz0JTOTWKI KzBB/NcWSHdkg== Date: Thu, 14 May 2026 12:03:23 +0200 From: Krzysztof Kozlowski To: Damon Ding Subject: Re: [PATCH v5 01/10] dt-bindings: display: rockchip: analogix-dp: Fix hclk as third clock for RK3588 Message-ID: <20260514-elegant-agate-pug-449ec2@quoll> References: <20260513074414.2053435-1-damon.ding@rock-chips.com> <20260513074414.2053435-2-damon.ding@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260513074414.2053435-2-damon.ding@rock-chips.com> X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heiko@sntech.de, dri-devel@lists.freedesktop.org, dianders@chromium.org, Laurent.pinchart@ideasonboard.com, andrzej.hajda@intel.com, airlied@gmail.com, m.szyprowski@samsung.com, simona@ffwll.ch, robh@kernel.org, rfoss@kernel.org, sebastian.reichel@collabora.com, jernej.skrabec@gmail.com, linux-rockchip@lists.infradead.org, luca.ceresoli@bootlin.com, devicetree@vger.kernel.org, conor+dt@kernel.org, jonas@kwiboo.se, maarten.lankhorst@linux.intel.com, mripard@kernel.org, linux-arm-kernel@lists.infradead.org, dmitry.baryshkov@oss.qualcomm.com, neil.armstrong@linaro.org, hjc@rock-chips.com, linux-kernel@vger.kernel.org, tzimmermann@suse.de, andy.yan@rock-chips.com, krzk+dt@kernel.org, nicolas.frattaroli@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, May 13, 2026 at 03:44:05PM +0800, Damon Ding wrote: > RK3588 eDP controller requires HCLK_VO1 (video output bus clock) > to access the VO1 GRF registers and enable the video datapath. To access GRF? Then it is the same clock input. AGAIN (reiterated soooo many times by me): you describe here clock input, NOT OUTPUT. > > Previously, the clock was enabled implicitly via the 'rockchip,vo-grf' > phandle reference, which allowed the eDP to work without explicitly > managing the hclk_vo1 clock. However, this is not safe or explicit. > > Enforce the correct third clock name on a per-compatible basis to > standardize clock requirements per SoC. This makes the clock > dependency clear and removes reliance on implicit clock enablement > from GRF phandle. > > Fixes: f855146263b1 ("dt-bindings: display: rockchip: analogix-dp: Add support for RK3588") > Signed-off-by: Damon Ding > > --- > > Changes in v4: > - Modify the commit msg. > > Changes in v5: > - Enforce the correct third clock name on a per-compatible basis. > - Modify the commit msg simultaneously. > --- > .../rockchip/rockchip,analogix-dp.yaml | 37 +++++++++++++++++-- > 1 file changed, 33 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml > index d99b23b88cc5..8001c1facf98 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml > @@ -23,10 +23,7 @@ properties: > > clock-names: > minItems: 2 > - items: > - - const: dp > - - const: pclk > - - const: grf What is 'grf' clock in such case? Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip