From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D1FFCD4F26 for ; Tue, 23 Jun 2026 09:47:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tsIFYdopkT+xwY4aRRWGd81VOL+SDnXxvc8yQI7jON4=; b=YJViuiU7hKtEzw FL9ZNEP12AmHtN+P0yN+aTtBCgqFfdptJfWfNKNIV8lrHSlqnBSFTQnoGYfK25EUH4cc327NYZ+0J G4ZlNtHahJatVdTJgQLvFlxsGwFG9EQ4uPZg+SbzSppGq2uZGAcFpv1BmQbrSroY+qzxOhyFExD0l sblpOyug5B3EW/0hMePoXHmy212kXmbOC3bsd5jdu2NALzRPFj7Mik8E2zSYUk1S2GUhwVmlmh2/t o7YClpYJCLuAcdtcQBQ5VfS8Y6sK+WaAxVETNCAb2yIDBO1ayph0Fd/ndZwQAKI/vc5O2Dwr7UkcP q7rLRSG0K1bTMIddN0Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbxjB-000000062BK-3G92; Tue, 23 Jun 2026 09:47:33 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbxj8-000000062AZ-357P for linux-rockchip@lists.infradead.org; Tue, 23 Jun 2026 09:47:32 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 5F0624E40755; Tue, 23 Jun 2026 09:47:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 305EC601C2; Tue, 23 Jun 2026 09:47:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 58FFE106C836A; Tue, 23 Jun 2026 11:47:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782208045; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=svsFrqtxSjp3C0yInI8YXCcDmQTS9+zcNrmpSt8j/lA=; b=ZJQAUj4WYpKiXwM1Lh2zuSl2zjVUGkvlGUi/hINcYDl3nq3od6Mmqm5kaaTReqwnadylXd 4rNL8iat8yqlgv+EWAMnsMk3F1baN9K8fRS4pk+yZ4UXMohTlII+F25TwL4Nu9YSrJAMWD CebgLxa/7ZZqIQB7h7dHuCAjo7kcP+2hmiGfZ6Y82rSkJYDV/ADGDelifIOVGyQi5Yb3ed lMYCwnNnknuFADiHDBry/gDZpsrp5FRm1nRk38lh15FsOA4FbffKDKqhtwM5SsTeynUXCG qt8ze3+n0Xgost3SqnXjFO/w2gDc/UA2FNvJ+PszAXIkRBYcbOiNkpy8KqwbyA== Date: Tue, 23 Jun 2026 11:47:20 +0200 From: Alexandre Belloni To: Nicolas Frattaroli Subject: Re: [PATCH v3 0/4] ROCK 4D audio enablement Message-ID: <202606230947201406cc92@mail.local> References: <20260408-rock4d-audio-v3-0-49e43c3c2a68@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260623_024730_906831_635151A0 X-CRM114-Status: GOOD ( 33.02 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, Dmitry Torokhov , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, linux-input@vger.kernel.org, Krzysztof Kozlowski , kernel@collabora.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Nicolas, I guess Dmitry is the one that would take patches 1 to 3. You should probably resend once the merge window has closed. On 11/05/2026 18:21:40+0200, Nicolas Frattaroli wrote: > Hi Alexandre, and other maintainers, > > On Wednesday, 8 April 2026 19:49:38 Central European Summer Time Nicolas Frattaroli wrote: > > The ROCK 4D uses an ADC input to distinguish between a headphone (i.e., > > no mic) and a headset (i.e., with mic). After some searching, it appears > > that the closest we can get to modelling this is by sending a particular > > switch input event. > > > > So this series modifies the adc-keys bindings, extends the adc-keys > > driver to allow sending other input types as well, and then adds the > > analog audio nodes to ROCK 4D's device tree. > > > > It should be noted that analog capture from the TRRS jack currently > > results in completely digitally silent audio for me, i.e. no data other > > than 0xFF. There's a few reasons why this could happen, chief among them > > that my SAI driver is broken or that the ES8328 codec driver is once > > again broken. The DAPM routes when graphed out look fine though. So the > > DTS part is correct, and I can fix the broken capture in a separate > > follow-up patch that doesn't have to include DT people. > > > > Another possibility is that my phone headset, despite being 4 rings and > > having a little pin hole at the back of the volume doodad, does not > > actually have a microphone, but in that case I'd still expect some noise > > in the PCM. Maybe it's just shy. > > > > Signed-off-by: Nicolas Frattaroli > > --- > > Changes in v3: > > - bindings: use unevaluatedProperties instead of explicitly mentioning > > linux,input-type. > > - Link to v2: https://lore.kernel.org/r/20251215-rock4d-audio-v2-0-82a61de39b4c@collabora.com > > > > Changes in v2: > > - Drop HDMI audio patch, as it was already merged. > > - adc-keys: rename "keycode" to "code". > > - adc-keys: make the keycode (now "code") local a u32 instead of an int > > - adc-keys: only allow EV_KEY and EV_SW for now. Rename patch > > accordingly. > > - adc-keys: Add another patch to rework probe function error logging. > > - Link to v1: https://lore.kernel.org/r/20250630-rock4d-audio-v1-0-0b3c8e8fda9c@collabora.com > > > > --- > > Nicolas Frattaroli (4): > > dt-bindings: input: adc-keys: allow all input properties > > Input: adc-keys - support EV_SW as well, not just EV_KEY. > > Input: adc-keys - Use dev_err_probe in probe function > > arm64: dts: rockchip: add analog audio to ROCK 4D > > > > .../devicetree/bindings/input/adc-keys.yaml | 17 ++-- > > arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 90 ++++++++++++++++++++++ > > drivers/input/keyboard/adc-keys.c | 88 ++++++++++----------- > > 3 files changed, 147 insertions(+), 48 deletions(-) > > --- > > base-commit: 8de395f35e79d9168a78504fed495578ec7bac52 > > change-id: 20250627-rock4d-audio-cfc07f168a08 > > > > Best regards, > > -- > > Nicolas Frattaroli > > > > > > What's the path forward here? All the patches are reviewed, but it > has been almost a month without them being applied now. > > Which tree(s) would this be applied to, and who should I poke? > > Thanks :) > > Kind regards, > Nicolas Frattaroli > > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip