From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1D39CDB47F for ; Wed, 24 Jun 2026 19:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mgLAkCO3m16uoxOmax4FQSFTum6+mcx6uUrg70K3508=; b=rsCEbVFc8/zXXY 59Gt1v7KuETV+7WgrYjyjRlLaUe2zTh52QPNzKZCRDzydrk/SZodV8yxquY1khgu7E8gLg1Qm3xzD p61wJGplaRye6YEAY3uNYTQ385PnvXt6myX9HvZGNlw2yDSvGh2M4L+yvNivjiPGgIdG9JVpN3C4D 1szYzI5NVsJmh2V1tQ3uM0kBBxj6/AjlbvF07Np5QbblViUqOz/oJsTtKw0/r/Z/TbdN3pm0MZXfZ g5SvVpjt+KCD2AkJmVxxK+O27lDliblyJl0Slpl72G7ZXkRHf1IkRNyDchU3e0fCjYGPHm/DoIpL1 IRW92sVgdrVUoojz5Y1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcT8P-00000008GMO-48mX; Wed, 24 Jun 2026 19:19:41 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcT8M-00000008GLx-3UHs; Wed, 24 Jun 2026 19:19:40 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 56D7E1049; Wed, 24 Jun 2026 21:18:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782328737; bh=SygbhfMsHBXymcem7e6Zd0nKKWVHq2pp7wmjCrhnj44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R9iPS6IL6p0/dDAwuFkL5icB0WAA7/VF1Z2f8Muhz3zenEk89jfcpVogCPF9xqqsm QPxnlkhw7Ug6s2tpdrYSAD+ZWecr8sCsX3hYxbY51skwWfYFAI00vNswoaiCKIZj+k 0HxXfhmL6kVxPTzsYM4hCVIu8p8C42YQ/DqNXn+k= Date: Wed, 24 Jun 2026 22:19:35 +0300 From: Laurent Pinchart To: Frank.Li@oss.nxp.com Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Mauro Carvalho Chehab , Dafna Hirschfeld , Heiko Stuebner , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , driver-core@lists.linux.dev, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou , Frank Li , Guoniu Zhou Subject: Re: [PATCH v2 0/4] media: add and use fwnode_graph_for_each_endpoint_scoped() Message-ID: <20260624191935.GG851255@killaraus.ideasonboard.com> References: <20260624-fw_scoped-v2-0-0a8db472af4a@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260624-fw_scoped-v2-0-0a8db472af4a@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260624_121939_019598_56ABC649 X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Frank, On Wed, Jun 24, 2026 at 01:00:08PM -0400, Frank.Li@oss.nxp.com wrote: > Add new helper macro fwnode_graph_for_each_endpoint_scoped() and use it > simplify media code. > > Typical example should qualcomm's driver (camss.c), the v4l2_mc.c and > rkisp1-dev.c only silience improvement. > > Anyways, *_for_each_*_scoped() already use widely and make code clean. > > Build test only. > > Sakari Ailus: > when I try to improve the patch > "Add common helper library for 1-to-1 subdev registration", I found need > camss.c pattern, so I create this small improvement firstly. Those are nice cleanups, thank you. After applying this series, the only left users of the fwnode_graph_for_each_endpoint() macro are in drivers/base/property.c. They can all be trivially replaced with the scoped variant. Should we add a patch to use fwnode_graph_for_each_endpoint_scoped() everywhere, and drop fwnode_graph_for_each_endpoint() ? > Signed-off-by: Frank Li > --- > Changes in v2: > - colllect review by tags > - fix typo and indent. > - see each patch's change log. > - Link to v1: https://patch.msgid.link/20260622-fw_scoped-v1-0-a37d0aac0a68@nxp.com > > --- > Frank Li (4): > device property: Introduce fwnode_graph_for_each_endpoint_scoped() > media: mc: use fwnode_graph_for_each_endpoint_scoped() to simpilfy code > media: rkisp1: use fwnode_graph_for_each_endpoint_scoped() to simplify code > media: qcom: camss: use fwnode_graph_for_each_endpoint_scoped() to simplify code > > drivers/media/platform/qcom/camss/camss.c | 17 +++++------------ > drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 4 +--- > drivers/media/v4l2-core/v4l2-mc.c | 5 +---- > include/linux/property.h | 5 +++++ > 4 files changed, 12 insertions(+), 19 deletions(-) > --- > base-commit: 3ce97bd3c4f18608335e709c24d6a40e7036cab8 > change-id: 20260620-fw_scoped-5dab644510a1 -- Regards, Laurent Pinchart _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip