From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77073C43458 for ; Wed, 1 Jul 2026 01:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9lyGbN+AGxM+ROZu4r0b8MYQ5s5yQKf7cKO0YAztZvc=; b=BgO27KYlH96FCA l6VuRSrLGQqa56zfMBWBD31po2U3RqQnSA1bBWGy6TMeEOvYp4ZbBhYb1B7kRL5MmIAAtFI+vLjEM GyRfHx+4k+K1nHnIN25PK1oIO7f31YiZ0LiXFOro68Hb2XwxAlaMnE6obVju9CCvf8w3CBEj005I9 yBd7pVVfkNKzhtlAarZYY8QPLAKvRHrd8hCI62HA60YV3z1D9kpQgepTLnNp2iazLzb5OAG78T3ub zbvkp27rjUSb5A0Tl4RKRDMvZ1+QTC5Ly95TT4ReXe4iWF14VfeuAKPeXBHyHxpSO957m+6jzfrrm usz+nVQD6i8ksM1/YFUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wek3C-00000000Szj-3rxV; Wed, 01 Jul 2026 01:47:42 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wek3B-00000000SzW-2sw5 for linux-rockchip@lists.infradead.org; Wed, 01 Jul 2026 01:47:41 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 110B640A00; Wed, 1 Jul 2026 01:47:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 506221F000E9; Wed, 1 Jul 2026 01:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782870459; bh=Rpdy5426Xc0zJZnjqUjuFXTHpOkdNMvNBX6jY1HfgE8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=TcfaV7fhPPT0+zcFP0jREJujju2MaeWSsaOPxooGHAV6RfffTFQY0FVkbyFeXpVMx 34xi+8T4UTmVSmI16MYSwSJhWKKEl23A/OLU8GvEAHzo//l8Rx2NBrD59egwITcclO o0J+v17W7oYqBGJw2JMdHJC7n9TSxS+hLG7rZfDe0d6bSWIXNBKNl0VLieD/8UA54x 3SADibwU0TgtbXKCxjFYpLjtRbPBwMqKvGOD4CRyzd3jJU1lc5zK35gE/0BOL0LPI7 EPCRIMyFqdMewyQfjsojLIxhPxkN6FdZ8w7ZCmUzDgKTWwVcYliyBrtuRndjeVrmNB 5IEK0BPj42svQ== Date: Wed, 1 Jul 2026 02:47:34 +0100 From: Jonathan Cameron To: Chris Morgan Cc: Chris Morgan , linux-iio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com, jean-baptiste.maneyrol@tdk.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, andriy.shevchenko@intel.com Subject: Re: [PATCH V14 0/9] Add Invensense ICM42607 Message-ID: <20260701024734.36a5148c@jic23-huawei> In-Reply-To: References: <20260624182350.50467-1-macroalpha82@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, 24 Jun 2026 16:18:23 -0500 Chris Morgan wrote: > > Changes Since V13: > > - Refactored inv_icm42607_set_accel_conf() and > > inv_icm42607_set_gyro_conf() into a single function. > > - Refactored inv_icm42607_accel_read_sensor() and > > inv_icm42607_gyro_read_sensor() into a single function. > > - Merged inv_icm42607_set_temp_conf() into initial init function > > since it only really needs to be called once. > > - Saved adding temp sensor for last and updated > > inv_icm42607_temp_read() to either confirm other sensors are already > > enabled or enable the accelerometer so it can get a reading. > > - Updated inv_icm42607_set_pwr_mgmt0() so that it does not update the > > sensor mode and forcibly keep the sensor enabled. > > - Added inv_icm42607_temp_filter_bw enums since it appears to use > > different values than the accel or gyro sensor. > > - Set the temp startup time from 77ms to 77us, as I previously misread > > the datasheet. > > - Additional minor fixes. > > > > Chris Morgan (9): > > dt-bindings: iio: imu: icm42600: Add mount-matrix > > dt-bindings: iio: imu: icm42600: Add icm42607 > > iio: imu: inv_icm42607: Add inv_icm42607 Core Driver > > iio: imu: inv_icm42607: Add SPI For icm42607 > > iio: imu: inv_icm42607: Add PM support for icm42607 > > iio: imu: inv_icm42607: Add Accelerometer for icm42607 > > iio: imu: inv_icm42607: Add Gyroscope to icm42607 > > iio: imu: inv_icm42607: Add Temp Support in icm42607 > > arm64: dts: rockchip: Add icm42607p IMU for RG-DS > > > > .../bindings/iio/imu/invensense,icm42600.yaml | 20 +- > > .../dts/rockchip/rk3568-anbernic-rg-ds.dts | 8 +- > > drivers/iio/imu/Kconfig | 1 + > > drivers/iio/imu/Makefile | 1 + > > drivers/iio/imu/inv_icm42607/Kconfig | 30 + > > drivers/iio/imu/inv_icm42607/Makefile | 13 + > > drivers/iio/imu/inv_icm42607/inv_icm42607.h | 423 ++++++++++++ > > .../iio/imu/inv_icm42607/inv_icm42607_accel.c | 317 +++++++++ > > .../iio/imu/inv_icm42607/inv_icm42607_core.c | 606 ++++++++++++++++++ > > .../iio/imu/inv_icm42607/inv_icm42607_gyro.c | 313 +++++++++ > > .../iio/imu/inv_icm42607/inv_icm42607_i2c.c | 98 +++ > > .../iio/imu/inv_icm42607/inv_icm42607_spi.c | 108 ++++ > > .../iio/imu/inv_icm42607/inv_icm42607_temp.c | 99 +++ > > .../iio/imu/inv_icm42607/inv_icm42607_temp.h | 37 ++ > > 14 files changed, 2072 insertions(+), 2 deletions(-) > > create mode 100644 drivers/iio/imu/inv_icm42607/Kconfig > > create mode 100644 drivers/iio/imu/inv_icm42607/Makefile > > create mode 100644 drivers/iio/imu/inv_icm42607/inv_icm42607.h > > create mode 100644 drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c > > create mode 100644 drivers/iio/imu/inv_icm42607/inv_icm42607_core.c > > create mode 100644 drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c > > create mode 100644 drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c > > create mode 100644 drivers/iio/imu/inv_icm42607/inv_icm42607_spi.c > > create mode 100644 drivers/iio/imu/inv_icm42607/inv_icm42607_temp.c > > create mode 100644 drivers/iio/imu/inv_icm42607/inv_icm42607_temp.h > > > > -- > > 2.43.0 > > > > I got sashiko.dev's review, and agree with everything except 2 points. > > 1) It asks "Is it appropriate to omit the interrupts property based on > driver behavior rather than hardware wiring?" I would say no, but in > my case the hardware is not wired for an interrupt so it's moot. I think the key thing it gets wrong is 'required'. Obviously an interrupt isn't required if it isn't wired ;) My only question is why is it required for the other devices? That makes no sense - so I think you can get rid of that change to require it in the binding (I'll reply to v15) > > 2) It asks "Does this code update the software state cache for the > sensor mode?" No, it doesn't. The goal is for the device to stay > powered up for up to 2 seconds until runtime PM turns it off if it > isn't active, but I don't mind something turning around and shutting > the hardware down if it's not in use before then. Anything that needs > to read the specific sensor in question will be holding the mutex so > that there shouldn't be a risk of another thread turning stuff off > while I'm trying to use it, I don't think. What I want to avoid is > calling to turn the hardware on for a one-shot read and then > immediately turning it off once I'm done. I can wait the two seconds > for runtime PM to do it when the alternative is to call the shutdown > routine every single time for one-shot reads and wait for the startup > and in the case of the gyro shutdown times otherwise. > > Thoughts? > As long as the locks are doing their jobs, this seems correct. Jonathan > I can fix the remaining issues it points out and resubmit. > > Thank you, > Chris _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip