From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32149C4450A for ; Sun, 19 Jul 2026 03:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=iX1g1zYeYc0D9kEQJ6TaZ0hvubx/yzkNiyUtNVY/ZW8=; b=dSCaeC1wqos473 15OQWQkvpJz9tmCN0z885pMX6+fPWJW4kpuznXFRJgsp+vT1lxqDBp92dD19Mlgu3d+rfLR/Wk2ID BlhbisjIR+dGzKao8FamhKatgCJtk2edNIBi3IwW90hdpCVes9V6UmXz2iE5BiBUWUL8iN8A6Ad5c eeKy0a0QD7ENu5dqxq8bJ6v+oK5QHT/DMFxdVZzm6rP3LEybwFIinsMB4joc9YlLfmslTWzSK181K fBhda8wb/6qSw+EkOnFaq1fB/T04e1bJQLUZKF06XDhAFesGf+c3xqF+kS96N47zK+1wfUhvEK6uq CNBN7j+Scuvn266qZGKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlITm-00000004im2-2Lcs; Sun, 19 Jul 2026 03:46:14 +0000 Received: from flow-b1-smtp.messagingengine.com ([202.12.124.136]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlITf-00000004ilb-0rYo for linux-rockchip@lists.infradead.org; Sun, 19 Jul 2026 03:46:12 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailflow.stl.internal (Postfix) with ESMTP id A0DE413001A6; Sat, 18 Jul 2026 23:46:03 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Sat, 18 Jul 2026 23:46:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gahingwoo.com; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm1; t=1784432763; x=1784436363; bh=K71T5tGJ+6 I/pIxNg5ggxdkC8btPjjIfP/2AA7E16Kw=; b=CpuK4YOtjH6ifPjbKchrKRaH7u bpsVQl30YvFKEW3AIsCdKDjAg/CuQiG9UBi+q09bDYnQGcmOQzv+aYUdYuy4d2sU XZjWN9x2w1C92akDpoGXHWQIikcHlhaynP/8WLxcYbE3y/L6Qv+zfRzzyVKZcKs+ GTBQwr8ZuvkqRezLK3ieDjRKETNh13kSi9+KvsTTcASiM31hRQN75iZ7B+DU0I0a 0CSsO5xZ/3MePwJak8lqPFSK2JmON4i6q0nW4to5bgYaI3dTKdwcDxfkJ59tptbI el4czpzavUtN77+TpZCM6RBtuOZdp4oKHefx7PuQKWThLSoCrJ72ZRagsHiw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1784432763; x=1784436363; bh=K71T5tGJ+6I/pIxNg5ggxdkC8btPjjIfP/2 AA7E16Kw=; b=Xv8ab6BY4/xe6LwTVr6VIF4cNkdAkjXFcgMWtVACtC4A4gRTFSA 44qYDlp1kMzox2xzwo99x8oY0fJd1BhBbscexPCWJDEWnlaDSXh1O4s8S/tb3Vjg 2TYhNy7gWI1pWqTSGC5fwZS/pkGC4vTA4fntUBmLX72cHYtsyq7kDLRr+C8w08T6 dc8yDquFOXV8KP7aod3EBFTv2T2ie4gNwROWYhl/WZSqnvZ1FzCmxWYO4Q4teqJ/ zGpsSTgNETrFA3ybo7oPZulzpMgKxkbXJmlnWt/cP6ESRBhMt7PPjNzCukDdRTt0 wEGJsUFsyvDaUEfkryeAhXY6lr/w/OTzGRA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFZGFuxOOcuQdUk9nnoXSFAretSBDpA7bPHsxXnUye+fLvAaW/QjoaDurq3PAttm9 a4QuFYl1x7Oxj4VfdlemzQxWNYFWbMg6eo8O6toy+0O6WJ0gmw5NR4wmgy/2SX7IbW4y0G Ej00Re0VIbKWZNiE57YBf4t86bHz36JYL00HMr3kD5GgDzjzG+n8QX02kRE5+RpEVWCih+ a6T2Fkycgvzn+vFrBnKkQkR0yZTEPcMbg3Rk9wSpvQfvxaCR6UXJcheQ6Ryr4lGbQViCP+ Po3+PZcvFLW0MueirC3YM2KVjHi8dm1NMTKJB84dF9qrsW/LnlDZgTK17yNQlWn+l2Qfkm GzqKVOmJRQPzKCxri3PUIR7FREbtFxI7TlmqSWlPaDyGRVn7GUtJ6tJn9e+LkuXQq3MJ2u EfScaCqH5HaJeiHk366wqNAIQD0xv3XAMPY6dBhKpknwLLCbfry9C5uSShJgcNPmNJztsI JnO7SKfChp8k2fGMckUar++LOWMdU5k0TzpmrVyECjXLIuP1iXESC4DQKDXzGt1ts8tHIf JB2051MspN2Im621cHKzL5w2RxyA4arkkyBbF0N+//YtOGXHx7WJTw+fTp29TwwQ1ornp9 oLIjXXsX4Bc2rK2hwAmcP9VCwSKemDpq/v8RmtPZvr84QPtmEtdKdSBojDSA X-ME-Proxy: Feedback-ID: i7a5e4b5f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Jul 2026 23:45:57 -0400 (EDT) From: Jiaxing Hu To: Frank.Sae@motor-comm.com, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com, heiko@sntech.de, linux-rockchip@lists.infradead.org Subject: [PATCH net-next] net: phy: motorcomm: enable the reference clock for YT8531 Date: Sun, 19 Jul 2026 15:45:55 +1200 Message-ID: <20260719034555.3623003-1-gahing@gahingwoo.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260718_204607_780161_5E224394 X-CRM114-Status: GOOD ( 11.74 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The YT8531 needs a 25 MHz reference. On boards without a local crystal it is fed from the SoC, described as a clock on the PHY node. Get and enable it in probe so the PHY is clocked before its registers are accessed. The clock is optional, so crystal-clocked boards are unaffected. Signed-off-by: Jiaxing Hu --- This supersedes "[PATCH net-next v2] net: stmmac: dwmac-rk: ..." which enabled the clock on the MAC side; Andrew and Maxime rightly pointed out that the PHY is the consumer and should enable it. That series is dropped. The DTS that consumes this (rk3576-armsom-cm5) goes to the rockchip tree separately; the clock is optional so this patch stands alone. Tested on an ArmSoM CM5-IO: the YT8531 links at 1000 Mbit/s. drivers/net/phy/motorcomm.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c index 708491bc1..2f85974a3 100644 --- a/drivers/net/phy/motorcomm.c +++ b/drivers/net/phy/motorcomm.c @@ -6,6 +6,7 @@ * Author: Frank */ +#include #include #include #include @@ -1169,9 +1170,20 @@ static int yt8521_probe(struct phy_device *phydev) static int yt8531_probe(struct phy_device *phydev) { struct device *dev = &phydev->mdio.dev; + struct clk *clk; u16 mask, val; u32 freq; + /* + * A crystal-less YT8531 takes its 25 MHz reference from the SoC. When + * that reference is described as a clock, enable it for the life of the + * device. It is optional, so crystal-clocked boards are unaffected. + */ + clk = devm_clk_get_optional_enabled(dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to get and enable the reference clock\n"); + if (device_property_read_u32(dev, "motorcomm,clk-out-frequency-hz", &freq)) freq = YTPHY_DTS_OUTPUT_CLK_DIS; -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip