From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87EC8C624D6 for ; Sat, 5 Sep 2026 05:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D8IU7fNvuSz8JS8F0RfcB7TKZnjGWAkfia2LuzV4PTc=; b=IeWH34NCb7GEzs c5yGWuBLlMlBUnPuLBAY778erQGt9Z66nO1RvvJrRQqPA1muxvmC1lFCLtRur9aGf+a7SPCaO0QIA dDcEkkgKhlDHoqVuTlA+z8dxO6bd+wFG0togPjtwq4mlVc138AqxHicSnLIY7Hgr+gnDW0w9cjG5S 62SQGS3cjv6GUBpT7EYs5Q+JmsCH7alVIX+v5hfICKXiiA20u1TDPfpWaNyVS9prue+lEQM/DO+/j pdLvMMGex9ejaFnAwKi77vsoXGXJ6UVpGSr9Se104bUlnO4IXkRby0/VR0n20T4s6VLBiFnhzzbfi obmgTZf+GC1DBS+tDWOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2iic-00000003gv4-1gPi; Sat, 05 Sep 2026 05:13:34 +0000 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2iia-00000003gue-0CGX for linux-rockchip@lists.infradead.org; Sat, 05 Sep 2026 05:13:33 +0000 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id E5D561400175; Sat, 5 Sep 2026 01:13:27 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Sat, 05 Sep 2026 01:13:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gahingwoo.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1788585207; x=1788671607; bh=mKQ6T09s6vUza8FyMAXZboJoVa94KKSs 2rJD+9vX/zI=; b=KlPnISX9RQo//VMkPodDUvpmLZvzYT8VGGKuQNH11B0i7H34 u9n19x7ea7yeDSNuKQGnW+nrfS7kNqUdIbWrbnKdIvbuSWetXiW8fwxWMIWNx925 oZI2mvhzxjr+MoYDgrLTaeNTZeLh/H09bUSjrDjYWjlNu7iNaKwYFScbnscD0eoP AJCS3qD0iTUIqhz/X5XMPqlshuhSuIgFBAus+XTrg1FFnCsSAMGPPyLVdkSxeq/K MP164mVEHIVHEE6XsgmKBFabNUUR51zJ78l8Yg33IjRr4h41FdpXQ9ojiu/N8+2z MVIAi1LqeoXuyxRV3RtvckGgN2aEY+oHu3RVmw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1788585207; x= 1788671607; bh=mKQ6T09s6vUza8FyMAXZboJoVa94KKSs2rJD+9vX/zI=; b=G spcRagjldvZlFYHdc8x3EXNRKSXnBXTY+BeMgAairmezS9Fhwr0Zvi71fwc/Nu2W ntmTSK3nWEXlRX4Tg6cCsXYkJilnd5MiyCE3gF/UcHL38jiJtCb1YxfzpcaBYMi1 Q4TeMOx1xYYaOzQ9da92WJ4KGnLzpdsaATG/9ekPhdZqMS/Gy2VMP6HTITE6g9Kf 87u35TwPSJNu1a/HH6KjMB87NJcZefUgmn/xvQUtkOgYchql8DbTh2Tvp+dtFD/a u6EmSQs998Bs6CEhcQv/ZmUAs2naNXSIcCftwTF//PE+97FQWgqtM8k5p1Ku6/rv 75IjcS7nM/AU+iSZ72saA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGDJEw3t5iHUzRHZjn+JaBo5KAsVspEkoW8MCWPkMvUPAnU+fwjT8R/Jig6eJ4/xE 0zGjqMF8FwH7siWqoG/yGhrGtL/LXq+uDX7Chexn0Sb1JESrAzFA0f2++iQtztSGIlKNso w8ZOYt6acu1pCDa4sMTjugJ7s1Qbnj5GMvaSK4DeEWeUTjznkFkAqy9v/X6H3UyfoZgv9w Eo9KrUE6FHDOvBTuDCh4QrH+f0bHaSr2AeorWamohzw5ehfvjnPXHuMikjlx6uT2H3S0kc qDXNfnfNHqQVLUylP3Zozf0f5Ua3y2B65bXT54vspD0Pvvmw26R5j9f/EGTfrg8pd8z3U9 eNK/fX3MeqP3ejXaQT/mFW6C2nAUjjWGlxYusdQn4tI6t9U6z/YOkmilJ/Cm0HyAp9X96V 4MdoINtYhfnTjioBmkRREXX0Deh0D5e87pP5asxtooNHL/m3mTlXJ80u2vAuarmTdgQ0TB O1OQNrzUhFjMv1aygeFPam+tyzm9lb0hnp0hfydfHld8jEu8bZvnWr3EDx4LlVhTyTjhcd +LYFSOUz0MGzE3LDeZddoWsjAu98qrU6hkVLYwBCFkL7t2jQXgGPb3sarPPSSJQllZzFde hlyoQgdEnkzrhg3eGOYJ2igOjDQcDl+7qJh1OXCIDirLKD/VPktBQ24z3xiw X-ME-Proxy: Feedback-ID: i7a5e4b5f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 5 Sep 2026 01:13:25 -0400 (EDT) From: Jiaxing Hu To: royalnet026@gmail.com Cc: tomeu@tomeuvizoso.net, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC] accel/rocket: DVFS on RK3588 - a hardware constraint, and some numbers Date: Sat, 5 Sep 2026 17:13:23 +1200 Message-ID: <20260905051323.189794-1-gahing@gahingwoo.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260904124659.25971-1-royalnet026@gmail.com> References: <20260801131656.58450-1-royalnet026@gmail.com> <20260904110853.85150-1-gahing@gahingwoo.com> <20260904124659.25971-1-royalnet026@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260904_221332_368688_8A8F04D4 X-CRM114-Status: GOOD ( 11.75 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Igor, > You are not in the delivery path of my series, so by > submitting-patches.rst it does not belong on that copy and I would > drop it there - your Reviewed-by is the credit that matters and it > stays, on both copies. Drop it. A Signed-off-by says I passed the patch along, and on your copy I did not. Reviewed-by is right on both, and the copy in my series keeps my sign-off because there I did. > You may want it on RK3576 too, where the same code runs with two > cores. Tested on a ROCK 4D, two cores, on next-20260730 with my series and two patches of my own on top. Unbinding both cores in bind order and binding them again, twice over: bound: 0 both gone, the device torn down bound: 2 core 0 and core 1 again bound: 0 bound: 2 core 0 and core 1 again Without your patch the second unbind never happens and the numbering walks off the end; with it the count reaches zero and a rebind starts clean. Nine models then decode with their batched prompt identical to their token loop. Tested-by: Jiaxing Hu # RK3576, two cores On my kernel the first unbind Oopsed even with your patch, and that one is mine. A patch of mine that keeps the IOMMU domain attached across jobs detaches it in rocket_job_fini() through core->iommu_group, and rocket_core_fini() put that group and cleared the pointer before calling it. pc : mutex_lock+0x20/0x54 lr : iommu_detach_group+0x20/0x40 rocket_job_fini+0x30/0x5c rocket_core_fini+0x40/0x50 rocket_remove+0x64/0xac Mainline and my posted series do not detach there, so neither has this. I mention it because your patch is what made me run unbind at all, and it found a bug in my unsent work the same afternoon. Not the kernel's fault, but it cost me an hour: an accel device takes the next free minor, so after two rebinds the NPU sat at /dev/accel/accel2 while my userspace opened accel0 and reported no hardware. Three clients bit-exact at 900 and 1000 MHz is the test I was hoping for, and the aggregate at 2.5x one client is what shows the three cores really did overlap. Thanks for running it before sending. Cheers, Jiaxing _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip