From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B948C79F8C for ; Wed, 9 Sep 2026 09:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0pYmOW4ZKL08g7zBObWz8p1k4h9Ry9sEs+6NgCPzfb4=; b=ybbqBOl0BVvdDJ a9MXqAfMdlzO5TQ5+eWsDY4bKV/b+qtfLEuqLjM4+0GIA9jHQ29Tboq469wWiD8esZDRkvyVpv/5S 4FETFzN3sIaBl+Kc3fOjqZhaDLGTDQDE8y2sC6/H1FeDsUKgKvEVmTgP9cGzdniJkpfBsdL90azuk uPhZvAViSMtbYDzlo0r4PydPgmJbjktJEWodbEmRbI3wNrUkUJZtOtH2XCAqDLE9L0sxZLDXVVrEj ghRlIMtbzXS9Vid/gCdANdy0cugXAtTk7jOKl2HaLhmRmj1/0zepCEncSBnAQGnW/Zm5k+EaymfeE GhhD45qMm98osUUBdhow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4EbE-0000000BHpA-0Um8; Wed, 09 Sep 2026 09:28:12 +0000 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4Eb9-0000000BHlX-0ly1 for linux-rockchip@lists.infradead.org; Wed, 09 Sep 2026 09:28:08 +0000 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-85590c5aeabso3945506b3a.3 for ; Wed, 09 Sep 2026 02:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788946086; x=1789550886; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LDCh3/bMgci4uGVV65c5lJe37gL3Ra631LoM+SOniZI=; b=DJdhhE48i4J6uHyZlh4aefXJaEbrGxIjBYmwQ/ZoHV4Ep+u0vKaKh+7a2UUm/sWRUW MYjZtxeNatONMCOT6CwOEldndK4yYVc5lk/z+H+xnB4PKLml3uXpJSBoA9tQL3bRHS1X FO2zrTu4LtCjij8Ta8jD1/yT3/FFcOtav3wSy/5X3kaNaDqerLbMyMdWC6wTy+gnr5Ct /0DHnCpGBXceM6+E76gKFdgbA+R96BH+8zr4AzQfj88XqJ9dI3Klh2yf7Ihksh+RG4yn qkPkkIxYP39x/4nrIimEnZOcjO4huWnNR9lXV1JgklOsKju5rs7V27i+bhj3dgX4MQeg te+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788946086; x=1789550886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LDCh3/bMgci4uGVV65c5lJe37gL3Ra631LoM+SOniZI=; b=BV4HYNd9z2r4jExPpvG5x6/dvu05rDq0bpf+B6eXcDMD5Ggv16Dx8lGmG5xdAUu1T4 rKa1GX3/jyzas/QdwlMfxmmVtz1bdCAllZbL6rFVtNeE1MKuevMMAeeTAEblSz6Eki0J bg/8agaMQWnPQgbMxyfo/p910fqmvZaqwhYw/mm8kToOgYuTJlEdDZRQr50rRtdXxg8f D/acUoKa+Tmz8kZELzBby+AZzjxsXTDjHsiyCLmz3/y0c0YULzAJTgokVsj0IdPFbX0g EQVGuFsvFYahkqrB0IKV8reNlxcnhgQc0ZiyBY1Kkk1wXkF406O9jJxO9q9HPHJW5xnT 6JyA== X-Forwarded-Encrypted: i=1; AKwUvBxx2o3bxXFYBV1LsBjshDSN9xZNYORaLHsezqlyKXrExyMl+Hs9agN/BGSXFsvUB8byfFt6kUfhcV9DsuLVZg==@lists.infradead.org X-Gm-Message-State: AFuF++k2Zhn/jjoXgRU3jv/erBtEaOPsUdC3TO5s+Qx7aTWkrotG8jS4 VOBll3oOFhAwoDxoEJQshidhqfHw3ujeagBYUuSG8viVgAaQoX/nLEmo X-Gm-Gg: AYBFou15vGu0NIz6awoCOtDs8MhLCd+nPPZpRiWdRgG34eC443MgiZvEw9FVpbGCNoM bLlF/mihHQFga52X0I7AVvebrY52eaTs6sWCcij/JOTsC2IKcYUWzLkxQgpVwXvkC6ssCh1StPn dDsZ7+B0NO6QaxVbRaWlgOM0+l21UiMr+CwLw070TYucds87bUQXJHDxIVLsJa9FmXyUdRIb558 zdH+WrqXlcb/DtdG5EX7J8QVE02jqlAIR5Y3wHNUTuoFfyRidwEfWgBWTp4uA0H3tqjsS9HJ8fA ekZrl3tr5I/BfEWcXne9a2Gu7FH8jcRfUEBmumCCLCM8FaUG4siuh5cmWNnpRDr/GBkaP5psi/X 8+m2KS6P41vnbdElEZNDojSPewYP7ddztWtnnstN+lpORfOv2zupxSfvqGvyu7OWzyL+U3tufzr x8ekV7DVWKQ0T5icmlTH9nzWb0Ys4GBdrBwkL52zhygEnJz2ut2Xosr5EUkl7q03ZEUyI4CihFd U/XvoWIAjaT X-Received: by 2002:a05:6a00:4388:b0:857:7317:cff2 with SMTP id d2e1a72fcca58-8616a266f1bmr50402873b3a.19.1788946086204; Wed, 09 Sep 2026 02:28:06 -0700 (PDT) Received: from Aaron-M6 ([188.253.120.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-868e3aaab85sm484904b3a.22.2026.09.09.02.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 02:28:05 -0700 (PDT) From: Yaozhong Li To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chris Zhong , Zhang Qing Cc: mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yaozhong Li Subject: [RFC PATCH 2/3] mfd: rk8xx: release the power hold GPIOs before powering off Date: Wed, 9 Sep 2026 17:27:27 +0800 Message-ID: <20260909092728.1859-3-yaozhonguwl@gmail.com> X-Mailer: git-send-email 2.55.0.windows.3 In-Reply-To: <20260909092728.1859-1-yaozhonguwl@gmail.com> References: <20260909092728.1859-1-yaozhonguwl@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260909_022807_584019_B7E2E86D X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org rk808_power_off() writes the PMIC's shutdown bit directly. On boards with "power hold" lines driven by the SoC, a shutdown performed this way does not stick: the rails drop and immediately come back up, so the board restarts instead of staying off. U-Boot reports the result as a power-on reset. Take those lines as an optional GPIO array, hold them asserted while the system runs and release them - waiting power-hold-delay-ms - before writing the shutdown bit. Device trees without the property retain the existing behaviour. Releasing every described line matters: on a Firefly-RK3399 the board stays off when both lines described for it are released, whereas releasing GPIO1_D0 while GPIO1_B5 is left asserted makes it come back up. Signed-off-by: Yaozhong Li --- drivers/mfd/rk8xx-core.c | 29 +++++++++++++++++++++++++++++ include/linux/mfd/rk808.h | 4 ++++ 2 files changed, 33 insertions(+) diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c index 3dcf6ab..fd1efbb 100644 --- a/drivers/mfd/rk8xx-core.c +++ b/drivers/mfd/rk8xx-core.c @@ -11,6 +11,8 @@ */ #include +#include +#include #include #include #include @@ -703,6 +705,24 @@ static int rk808_power_off(struct sys_off_data *data) default: return NOTIFY_DONE; } + + /* + * Some boards route "power hold" lines from the SoC into the board's + * power circuitry. They have to be held asserted while the system is + * running and released before the PMIC shutdown request is written: + * with any of them left asserted, the rails drop and then come back + * up. Releasing them here rather than from a separate handler keeps + * the ordering against the I2C write explicit. + */ + if (rk808->power_hold_gpios) { + unsigned int i; + + for (i = 0; i < rk808->power_hold_gpios->ndescs; i++) + gpiod_set_value_cansleep(rk808->power_hold_gpios->desc[i], 0); + + msleep(rk808->power_hold_delay_ms); + } + ret = regmap_update_bits(rk808->regmap, reg, bit, bit); if (ret) dev_err(rk808->dev, "Failed to shutdown device!\n"); @@ -874,6 +894,15 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap if (device_property_read_bool(dev, "system-power-controller") || device_property_read_bool(dev, "rockchip,system-power-controller")) { + rk808->power_hold_gpios = devm_gpiod_get_array_optional(dev, + "power-hold", GPIOD_OUT_HIGH); + if (IS_ERR(rk808->power_hold_gpios)) + return dev_err_probe(dev, PTR_ERR(rk808->power_hold_gpios), + "failed to get power hold GPIOs\n"); + + device_property_read_u32(dev, "power-hold-delay-ms", + &rk808->power_hold_delay_ms); + ret = devm_register_sys_off_handler(dev, SYS_OFF_MODE_POWER_OFF_PREPARE, SYS_OFF_PRIO_HIGH, &rk808_power_off, rk808); diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h index 7ffc904..eda111e 100644 --- a/include/linux/mfd/rk808.h +++ b/include/linux/mfd/rk808.h @@ -1459,6 +1459,8 @@ enum { RK818_ID = 0x8180, }; +struct gpio_descs; + struct rk808 { struct device *dev; struct regmap_irq_chip_data *irq_data; @@ -1466,6 +1468,8 @@ struct rk808 { long variant; const struct regmap_config *regmap_cfg; const struct regmap_irq_chip *regmap_irq_chip; + struct gpio_descs *power_hold_gpios; + u32 power_hold_delay_ms; }; void rk8xx_shutdown(struct device *dev); -- 2.55.0.windows.3 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip