From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEEAFC88E77 for ; Wed, 16 Sep 2026 13:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qtvuZHaIyLqGderrJTPjQE4IDMo48wvCFbO8E+r+tDA=; b=agCrZf19JCAKvW dwCSRZkGNIvCv5N0/pbjwA2GB2x3HqcvI2zNWfrjxt52bg1PTeU3WtBb1DeaATiBqi03U97jqS4R/ EHEhc0cZodEfvB2eUjHZtdm/iUXzUjNKrqpqp92oUAEkx3ZUAaOF40HvVQMW/jg5x1Mbr9n06GbbI ae7H025/dxwWaCS4H2zvE0aa/nFw1TqsV/RnbdPxjx4Zhb5kw6qfWQF1tyig4rJed0PLQ7EVzYG7h NUJxGx7cFa0oFVX2f+DwKD/shA47CKVNoJ70kKP4EfGlUN22gcQKR8OiBU6kBUpOh8DdF3BNwhUVR Ayh2bLInNUvVyxaQMG3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6q0G-00000009KUp-18mT; Wed, 16 Sep 2026 13:48:48 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6pzp-00000009KC6-10Rd for linux-rockchip@bombadil.infradead.org; Wed, 16 Sep 2026 13:48:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=QjTr2Jmo4sllECWNzVI6O2II4pn3OSCLwMo1L497iBk=; b=csTRWtLKQUzWbr42TWzCGhh8Fz AbWJfe9jjaor6vP23mo1aPWkrybnP3MBquYfre7+GfkPj8pCfU3FSk7k5lkyRRZAE/+v2M47Pmcbg Ziu8RYqxg8DdECGnyjCZqf525IKyswDRotd6SIqI7FFV9OjvP5dFjrbWtjacuL3JigGGC3FmJvZy7 eQy1boc06HrFqIlteO5Q28MGYKLwee1DkhoK+curricAk/wgowdMOyf/byYejrGUYma5pS9bvf3f2 s5wJLIzMwF+XwhY5GA67Vz02Ar9CyPaMDHY/ZltOJKAj7wRA4Dk2EM8mTjTOxUGTSs+ICOTsrJ8b5 7aJtiULA==; Received: from smtpout-02.galae.net ([185.246.84.56]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x6pzm-00000007wFW-1fOk for linux-rockchip@lists.infradead.org; Wed, 16 Sep 2026 13:48:20 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C59C91A07A8; Wed, 16 Sep 2026 13:48:17 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 98B0760337; Wed, 16 Sep 2026 13:48:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E1C4E11C7B035; Wed, 16 Sep 2026 15:48:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1789566490; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=QjTr2Jmo4sllECWNzVI6O2II4pn3OSCLwMo1L497iBk=; b=q2GXSr3MBNevWtr1X4GL5najFiFRCky4UDT9+gVxjCXDZmeQnPUNB3iBKRW8SS5eMuwAH0 e0RcOblp7qN+c50PtK5sZyWm7zvlBrfenS0ff+azzPN+fTSjdar7/YoOFPhzX2xzFO+ioP ZEgz69QYHQLGn8EMFMvl3NKPghhdfQu91EPTu7GXgpn3ln5u/vnxtTgNkfoTuHO2s/lf7O HXYgmH+GXJv/mSQTXZVJs1rsIiEwV0/ZzwEhCKGCkQPspx45LzvgFWd8XydFDzeoZeQvyW rLB8r/PtIndVeczq82GfGMwOXFL0P1Gv7id5bAIl9G04miXl2G84LDQQqs7VQg== From: Luca Ceresoli Date: Wed, 16 Sep 2026 15:45:42 +0200 Subject: [PATCH v3 18/19] drm/tve200: don't create a panel_bridge MIME-Version: 1.0 Message-Id: <20260916-drm-bridge-every-panel-v3-18-83afb4f1a707@bootlin.com> References: <20260916-drm-bridge-every-panel-v3-0-83afb4f1a707@bootlin.com> In-Reply-To: <20260916-drm-bridge-every-panel-v3-0-83afb4f1a707@bootlin.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang , Laurentiu Palcu , Lucas Stach , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Paul Kocialkowski , Linus Walleij , Inki Dae , Jagan Teki , Marek Szyprowski , Sean Paul , Jonathan Corbet , Shuah Khan , Randy Dunlap Cc: Albert Esteve , Anusha Srivatsa , Dmitry Baryshkov , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, asahi@lists.linux.dev, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Luca Ceresoli X-Mailer: b4 0.16.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260916_144818_518757_E6D04542 X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Now a panel_bridge is automatically created for every drm_panel and the panel-bridge API is just a deprecated wrapper to access it. Update and simplify the code by just getting a reference to the already-existing bridge using of_drm_get_bridge_by_endpoint(). And since of_drm_find_and_get_bridge() returns a refcounted bridge, take care of putting the bridge reference. Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/tve200/Kconfig | 1 - drivers/gpu/drm/tve200/tve200_drm.h | 1 - drivers/gpu/drm/tve200/tve200_drv.c | 30 +++++++----------------------- 3 files changed, 7 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/tve200/Kconfig b/drivers/gpu/drm/tve200/Kconfig index c0746ae8f703..afe243df4ebb 100644 --- a/drivers/gpu/drm/tve200/Kconfig +++ b/drivers/gpu/drm/tve200/Kconfig @@ -8,7 +8,6 @@ config DRM_TVE200 select DRM_BRIDGE select DRM_CLIENT_SELECTION select DRM_PANEL - select DRM_PANEL_BRIDGE select DRM_KMS_HELPER select DRM_GEM_DMA_HELPER help diff --git a/drivers/gpu/drm/tve200/tve200_drm.h b/drivers/gpu/drm/tve200/tve200_drm.h index 631a9f5d9aa6..708f8020667a 100644 --- a/drivers/gpu/drm/tve200/tve200_drm.h +++ b/drivers/gpu/drm/tve200/tve200_drm.h @@ -103,7 +103,6 @@ struct tve200_drm_dev_private { struct drm_device *drm; struct drm_connector *connector; - struct drm_panel *panel; struct drm_bridge *bridge; struct drm_plane plane; struct drm_crtc crtc; diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c index 63ca4a53fc4c..9874554e5065 100644 --- a/drivers/gpu/drm/tve200/tve200_drv.c +++ b/drivers/gpu/drm/tve200/tve200_drv.c @@ -65,7 +65,6 @@ static int tve200_modeset_init(struct drm_device *dev) { struct drm_mode_config *mode_config; struct tve200_drm_dev_private *priv = dev->dev_private; - struct drm_panel *panel; struct drm_bridge *bridge; int ret; @@ -77,19 +76,10 @@ static int tve200_modeset_init(struct drm_device *dev) mode_config->min_height = 240; mode_config->max_height = 576; - ret = drm_of_find_panel_or_bridge(dev->dev->of_node, - 0, 0, &panel, &bridge); - if (ret && ret != -ENODEV) - return ret; - if (panel) { - bridge = drm_panel_bridge_add_typed(panel, - DRM_MODE_CONNECTOR_Unknown); - drm_panel_put(panel); - if (IS_ERR(bridge)) { - ret = PTR_ERR(bridge); - goto out_bridge; - } - } else { + bridge = of_drm_get_bridge_by_endpoint(dev->dev->of_node, 0, 0); + if (IS_ERR(bridge) && PTR_ERR(bridge) != -ENODEV) + return PTR_ERR(bridge); + if (IS_ERR(bridge) || !drm_bridge_is_panel(bridge)) { /* * TODO: when we are using a different bridge than a panel * (such as a dumb VGA connector) we need to devise a different @@ -100,6 +90,8 @@ static int tve200_modeset_init(struct drm_device *dev) goto out_bridge; } + bridge->type = DRM_MODE_CONNECTOR_Unknown; + ret = tve200_display_init(dev); if (ret) { dev_err(dev->dev, "failed to init display\n"); @@ -121,9 +113,6 @@ static int tve200_modeset_init(struct drm_device *dev) goto out_bridge; } - dev_info(dev->dev, "attached to panel %s\n", - dev_name(panel->dev)); - ret = drm_vblank_init(dev, 1); if (ret) { dev_err(dev->dev, "failed to init vblank\n"); @@ -136,8 +125,6 @@ static int tve200_modeset_init(struct drm_device *dev) goto finish; out_bridge: - if (panel) - drm_panel_bridge_remove(bridge); drm_mode_config_cleanup(dev); finish: return ret; @@ -233,8 +220,6 @@ static int tve200_probe(struct platform_device *pdev) return 0; mode_config_cleanup: - if (priv->panel) - drm_panel_bridge_remove(priv->bridge); drm_mode_config_cleanup(drm); clk_disable: clk_disable_unprepare(priv->pclk); @@ -248,10 +233,9 @@ static void tve200_remove(struct platform_device *pdev) struct drm_device *drm = platform_get_drvdata(pdev); struct tve200_drm_dev_private *priv = drm->dev_private; + drm_bridge_put(priv->bridge); drm_dev_unregister(drm); drm_atomic_helper_shutdown(drm); - if (priv->panel) - drm_panel_bridge_remove(priv->bridge); drm_mode_config_cleanup(drm); clk_disable_unprepare(priv->pclk); drm_dev_put(drm); -- 2.55.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip