From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9983CC9831E for ; Thu, 24 Sep 2026 22:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8Nc1vYpTEEu87r1uZnpxGPnEyVBa4nWFWZtYzIl+mI0=; b=fgGMmbQ5yKSKtZ MgZIYxLI3w6rRA8FiladwtmBkQ9PjOMfr+q+X2mmOwHiHYGSzlscMK61U1CK3iVpz+fgV6QRtD6uH +WEtPKqHzYNEr52S5pNgxpEw7nogyKBTpALAltV/VyE1nydEYatYPvbum4lxpesE43AdyDS8EiqOt GVZwyKanebNWTWrPQDGH7gLPIPSDawsKFomnCU0kliVE+MItC4VZJ5c8e1joy/7cXWgqVKBFHr6l5 BEDvLl7umwHYPn2hyW+bTJRxbTANrC78WkLIrpji2JKhILRGjNeCfLoEunM6Sc3kcgoN3RAGatQuE iz+MRpUrstYnCxEJ+Mvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9s9i-0000000CJGg-10yP; Thu, 24 Sep 2026 22:43:06 +0000 Received: from mgamail.intel.com ([198.175.65.10]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9s9f-0000000CJEu-0W0R; Thu, 24 Sep 2026 22:43:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790289783; x=1821825783; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5k6ew4bZKs5Kak0IIZkqP5OL1erIyyXEfACAGORomcc=; b=decaKPbU/p7zeQI2+zBZRLX+e64QZlwazVWCzaTmMOnTJsXHFY3438un M3TQmTGEoGn53cCVTeLTAlEBuoat4oKLYyAkYcPWM+Q2F5k3jzPksa4Ix hWYs9/CHkMhhe2QW3050vm2QQLk7CBac2sUMuq3lbfVm0N3UbQwWP6/II UjCX+8YjGGUa3hiAtDv7rzjKpzLsefNg4+iG9K1esRqiwUTRR2dsZJ4wO 5WKuxbzSQYm31Saje5/gh0HqR8DvzDxYMlu6iRvJtcWKsJN0oOfsrcWR1 e8+fdhC8OVvprU1rBCYpY/GjuL7nABm1nxRi/4h9hx75qSe7na6MTdfuw g==; X-CSE-ConnectionGUID: /oPqw4s2Qy6Wu/mKNoOoHg== X-CSE-MsgGUID: JzU+pS/zRYemynvur9QCUA== X-IronPort-AV: E=McAfee;i="6800,10657,11915"; a="107459061" X-IronPort-AV: E=Sophos;i="6.27,121,1787036400"; d="scan'208";a="107459061" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2026 15:43:01 -0700 X-CSE-ConnectionGUID: U5Dk8CFqRMui2FINcs4gCw== X-CSE-MsgGUID: 0sfLiX2TT1WjCokNpBJP4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,121,1787036400"; d="scan'208";a="272276214" Received: from igk-lkp-server01.igk.intel.com (HELO a88263cc608e) ([10.211.93.152]) by orviesa010.jf.intel.com with ESMTP; 24 Sep 2026 15:42:58 -0700 Received: from kbuild by a88263cc608e with local (Exim 4.98.2) (envelope-from ) id 1x9s9U-000000000Sk-1VZT; Thu, 24 Sep 2026 22:42:52 +0000 Date: Fri, 25 Sep 2026 00:42:13 +0200 From: kernel test robot To: Coia Prant , Heiko Stuebner , Maxime Chevallier , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: oe-kbuild-all@lists.linux.dev, Sebastian Reichel , netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Coia Prant Subject: Re: [PATCH net] net: ethernet: stmmac: dwmac-rk: fix bulk clock leak when the PHY clock fails Message-ID: <202609250009.lQiuYnR7-lkp@intel.com> References: <20260919174223.2356964-1-coiaprant@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260919174223.2356964-1-coiaprant@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260924_154303_238693_D784561B X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Coia, kernel test robot noticed the following build warnings: [auto build test WARNING on net/main] url: https://github.com/intel-lab-lkp/linux/commits/Coia-Prant/net-ethernet-stmmac-dwmac-rk-fix-bulk-clock-leak-when-the-PHY-clock-fails/20260920-014223 base: net/main patch link: https://lore.kernel.org/r/20260919174223.2356964-1-coiaprant%40gmail.com patch subject: [PATCH net] net: ethernet: stmmac: dwmac-rk: fix bulk clock leak when the PHY clock fails config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20260925/202609250009.lQiuYnR7-lkp@intel.com/config) compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260925/202609250009.lQiuYnR7-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202609250009.lQiuYnR7-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1168:5: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] 1168 | return ret; | ^ drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1165:4: note: previous statement is here 1165 | if (ret) | ^ drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1177:2: warning: non-void function does not return a value in all control paths [-Wreturn-type] 1177 | } else { | ^ drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1177:4: error: expected identifier or '(' 1177 | } else { | ^ drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1189:2: error: expected identifier or '(' 1189 | return 0; | ^ drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1190:1: error: extraneous closing brace ('}') 1190 | } | ^ 2 warnings and 3 errors generated. vim +/if +1168 drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c 7ad269ea1a2b7d Roger Chen 2014-12-29 1152 7ad269ea1a2b7d Roger Chen 2014-12-29 1153 static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable) 7ad269ea1a2b7d Roger Chen 2014-12-29 1154 { ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1155 int ret; 7ad269ea1a2b7d Roger Chen 2014-12-29 1156 7ad269ea1a2b7d Roger Chen 2014-12-29 1157 if (enable) { 7ad269ea1a2b7d Roger Chen 2014-12-29 1158 if (!bsp_priv->clk_enabled) { ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1159 ret = clk_bulk_prepare_enable(bsp_priv->num_clks, ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1160 bsp_priv->clks); ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1161 if (ret) ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1162 return ret; 7ad269ea1a2b7d Roger Chen 2014-12-29 1163 ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1164 ret = clk_prepare_enable(bsp_priv->clk_phy); ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1165 if (ret) cb278e6780d874 Coia Prant 2026-09-20 1166 clk_bulk_disable_unprepare(bsp_priv->num_clks, cb278e6780d874 Coia Prant 2026-09-20 1167 bsp_priv->clks); ea449f7fa0bf3f Sebastian Reichel 2023-04-07 @1168 return ret; cb278e6780d874 Coia Prant 2026-09-20 1169 } 23c94d63a7e395 David Wu 2018-06-28 1170 5c1fc7cb81dfed Russell King (Oracle 2026-02-04 1171) rk_configure_io_clksel(bsp_priv); 5c1fc7cb81dfed Russell King (Oracle 2026-02-04 1172) rk_ungate_rmii_clock(bsp_priv); 2f2b60a0ec2826 David Wu 2022-08-30 1173 7ad269ea1a2b7d Roger Chen 2014-12-29 1174 mdelay(5); 7ad269ea1a2b7d Roger Chen 2014-12-29 1175 bsp_priv->clk_enabled = true; 7ad269ea1a2b7d Roger Chen 2014-12-29 1176 } 7ad269ea1a2b7d Roger Chen 2014-12-29 1177 } else { 7ad269ea1a2b7d Roger Chen 2014-12-29 1178 if (bsp_priv->clk_enabled) { 5c1fc7cb81dfed Russell King (Oracle 2026-02-04 1179) rk_gate_rmii_clock(bsp_priv); 7f864458e9a6d2 Sebastian Reichel 2025-10-14 1180 ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1181 clk_bulk_disable_unprepare(bsp_priv->num_clks, ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1182 bsp_priv->clks); fecd4d7eef8b21 David Wu 2017-08-10 1183 clk_disable_unprepare(bsp_priv->clk_phy); fecd4d7eef8b21 David Wu 2017-08-10 1184 7ad269ea1a2b7d Roger Chen 2014-12-29 1185 bsp_priv->clk_enabled = false; 7ad269ea1a2b7d Roger Chen 2014-12-29 1186 } 7ad269ea1a2b7d Roger Chen 2014-12-29 1187 } 7ad269ea1a2b7d Roger Chen 2014-12-29 1188 7ad269ea1a2b7d Roger Chen 2014-12-29 1189 return 0; 7ad269ea1a2b7d Roger Chen 2014-12-29 1190 } 7ad269ea1a2b7d Roger Chen 2014-12-29 1191 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip