From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62B13CA5FD4 for ; Fri, 2 Oct 2026 01:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SJ16QgvRaZkoF+ACtvqJXAr7Pb4kwafoKgCge/5Rnjc=; b=3OC8kj82bspQYM owk36lQlJU0o01cBX4HKl1I2EkYHNS3cOVXJVSALljRSlja7pSAAXwYdtAqaE9YUbSzTsjCV/rE8m K9fnSDDM5i7RWnOXetts3wDT9yzkgF7omDGh7aDn55Bc3rdl9EEzf0MoKFTWk9FnqQwWoPT3Kzguu 4nQSi9mja2nIKhkUsUmrZ0z8w2nwzao+dQCBE/Mmi7D3DsuLE7VkUxQgLv6xC5ciD1A2mfTFiwVQU TyzpqaWY1Zjas2P/nI2NSVLKRQSSIAU8kbksIA9e0SikmaqdrtCy6VnovpTDxGQYtvW/cZH+ge/OM 8Emt+q4jx0KxkKjFegtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCSML-0000000AUMM-0NVs; Fri, 02 Oct 2026 01:46:49 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCSMH-0000000AULu-0T0a; Fri, 02 Oct 2026 01:46:46 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D4333227; Fri, 2 Oct 2026 03:44:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1790905489; bh=oICVcHOz2Wfgzqh7GpipejxF0d1OizMTX25Z+t8idAE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DL47LK26zxYWCGEwmH0pFphMpQcdDa446j4BIEW/6z2jrfgx1u/HPvf5LspF0B4qm e6PUuZGYTLC1VVDdFuuXDusl9pBhG9xklqDGgx/8Sj4OayueF0WmZ/r+0sa/0dNgYP l4McKnsWX9Tt+e/LWL/mGqJ/C9wK+61dNMGhnAiI= Date: Fri, 2 Oct 2026 04:46:40 +0300 From: Laurent Pinchart To: Diederik de Haas Cc: Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , Detlev Casanova , Ezequiel Garcia , Jacob Chen , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] media: rkisp1: Switch to modern PM_OPS Message-ID: <20261002014640.GB101842@killaraus.ideasonboard.com> References: <20261001173610.158931-1-diederik@cknow-tech.com> <20261001173610.158931-4-diederik@cknow-tech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261001173610.158931-4-diederik@cknow-tech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261001_184645_324167_1B7A9143 X-CRM114-Status: GOOD ( 23.59 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, Oct 01, 2026 at 07:34:53PM +0200, Diederik de Haas wrote: > A new set of modern PM_OPS macros got defined in commit > 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones") > > Switch to those new macros so that the PM callbacks are always seen by the > compiler, but discarded if not used. This lets us drop the __maybe_unused > annotation from the callback functions. > > Signed-off-by: Diederik de Haas Reviewed-by: Laurent Pinchart As the three patches in this series are independent from each other, I've taken this in my tree. > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > index f90e01301943..e619a949dbc9 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > @@ -305,7 +305,7 @@ static int rkisp1_subdev_notifier_register(struct rkisp1_device *rkisp1) > * Power > */ > > -static int __maybe_unused rkisp1_runtime_suspend(struct device *dev) > +static int rkisp1_runtime_suspend(struct device *dev) > { > struct rkisp1_device *rkisp1 = dev_get_drvdata(dev); > > @@ -331,7 +331,7 @@ static int __maybe_unused rkisp1_runtime_suspend(struct device *dev) > return pinctrl_pm_select_sleep_state(dev); > } > > -static int __maybe_unused rkisp1_runtime_resume(struct device *dev) > +static int rkisp1_runtime_resume(struct device *dev) > { > struct rkisp1_device *rkisp1 = dev_get_drvdata(dev); > int ret; > @@ -351,9 +351,8 @@ static int __maybe_unused rkisp1_runtime_resume(struct device *dev) > } > > static const struct dev_pm_ops rkisp1_pm_ops = { > - SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > - pm_runtime_force_resume) > - SET_RUNTIME_PM_OPS(rkisp1_runtime_suspend, rkisp1_runtime_resume, NULL) > + SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) > + RUNTIME_PM_OPS(rkisp1_runtime_suspend, rkisp1_runtime_resume, NULL) > }; > > /* ---------------------------------------------------------------------------- > @@ -815,7 +814,7 @@ static struct platform_driver rkisp1_drv = { > .driver = { > .name = RKISP1_DRIVER_NAME, > .of_match_table = of_match_ptr(rkisp1_of_match), > - .pm = &rkisp1_pm_ops, > + .pm = pm_ptr(&rkisp1_pm_ops), > }, > .probe = rkisp1_probe, > .remove = rkisp1_remove, -- Regards, Laurent Pinchart _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip