From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43165CA5FED for ; Tue, 6 Oct 2026 13:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HlKQ2GgYAhE7TImjiK1LWFCycmpAQYxae6n2CDITeHI=; b=0DiW0mDn7XcA2N 06fj7YNtpKPFsd0dtnbjget20pp2WvXKmJQgjUA1uQHNSYkMVAu2hjO0ZtwZQXjnvtO6090w4tG2C nnh+1FrLHktaCY1qOVyimGWa8+6xQkRGNrYcCrRIc37+vms6u8WodbVldq7H/acOt9sjsG4raLGqA WZDWEFGozEJN9A4w0CujUirzqs5OBhHGyEr6jP5heQ5ChxPgplkXRdrwYAGRwIdoCTyXsUA+2MCAw cxl34xv6d5EtHNL9nMXzh+gNUsqUP6QmrXzbccwkKaseNZDCGnR6333l4RW/H699uYhubjbAt/YKm i3qP9UMP3F7760PXZP+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xE59k-00000000qwh-0h9v; Tue, 06 Oct 2026 13:24:32 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xE59i-00000000qw5-3Mjf; Tue, 06 Oct 2026 13:24:30 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 399BD40245; Tue, 6 Oct 2026 13:24:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB4EE1F000FF; Tue, 6 Oct 2026 13:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791293070; bh=76u9YDW7aKiOQkrk/yybh/tScB4dKv9L1ujivE8+las=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=DuOP5EDheODNf4/AFDlTAYw+nYmy4Ieq5s6wLw4yZmmzM3wVUzF9UFio40Cw54iKX tToacGZwZwpAAp6Lbwfel7lvim54fmBt8R2+A+3ZqdAJnskODzeZTnSczp+cRggMCL MUvYTYgDfE4uURhSfzFPb5nSIDSqfY2oO3fXNpbREmSjcl+gFnsfOwAt11p6W+V+EP cFo+Cnqmvngkk3pMjWYsdhjRyGLNZ0ctGv96xnF0PKv791p8VVLM+qeLazLX1rqylq V1gN0Nlu5tTZ3E9zhLTtZx1S9iKkjEGjY8Vd7q4gxBgGQQARdzbj7vI3M2YPk6+FGp 0dwvNAIFXroxA== Date: Tue, 6 Oct 2026 08:24:28 -0500 From: Rob Herring To: Coia Prant Cc: Jakub Kicinski , Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Maxime Chevallier , Heiner Kallweit , Russell King , David Wu , netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v10 1/6] dt-bindings: net: pcs: add rockchip,rk3568-xpcs support Message-ID: <20261006132428.GA1659963-robh@kernel.org> References: <20261005223011.1124347-1-coiaprant@gmail.com> <20261005223011.1124347-2-coiaprant@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261005223011.1124347-2-coiaprant@gmail.com> X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Oct 06, 2026 at 06:30:03AM +0800, Coia Prant wrote: > Add device tree binding documentation for the Synopsys DesignWare > XPCS integrated on the Rockchip RK3568 SoC. > > The XPCS is accessed over the APB3 bus and internally connected to > a Naneng Combo SerDes PHY. It supports 1000BASE-X, SGMII, and > QSGMII modes, with four MII ports. > > The four MII ports are described as ethernet-pcs-mii@N child nodes, > consumed by the Rockchip XPCS glue driver later in this series. > > phys and phy-names are required because dtbs_check only validates > required properties for enabled nodes. The SerDes link is a board-level > design choice (combphy1 on some boards, combphy2 on others), so these > properties must be provided by the board device tree, not the SoC dtsi. > > The CRU reset lines (SRST_XPCS*) are intentionally not described: no > in-tree user requests them, and bring-up relies on the PD_PIPE power > domain, the SerDes PHY and the in-IP soft reset. They can be added > later as optional without breaking ABI. > > Signed-off-by: Coia Prant > --- > .../net/pcs/rockchip,rk3568-xpcs.yaml | 110 ++++++++++++++++++ > 1 file changed, 110 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/pcs/rockchip,rk3568-xpcs.yaml > > diff --git a/Documentation/devicetree/bindings/net/pcs/rockchip,rk3568-xpcs.yaml b/Documentation/devicetree/bindings/net/pcs/rockchip,rk3568-xpcs.yaml > new file mode 100644 > index 0000000000000..703fcff0e3f70 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/pcs/rockchip,rk3568-xpcs.yaml > @@ -0,0 +1,110 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/pcs/rockchip,rk3568-xpcs.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip RK3568 Synopsys DesignWare Ethernet PCS > + > +maintainers: > + - Coia Prant > + > +description: | > + Rockchip RK3568 SoC integrates a Synopsys DesignWare Ethernet Physical > + Coding Sublayer (XPCS). > + The PCS provides an interface between the Media Access Control (MAC) > + and the Physical Medium Attachment (PMA) sublayer through a Media > + Independent Interface (GMII). > + > + The XPCS is accessed over the APB3 bus and internally connected to a > + Naneng Combo SerDes PHY. > + It supports 1000BASE-X, SGMII and QSGMII modes. > + > + The block contains four MII ports that can be individually enabled and > + routed to one of the Ethernet GMAC controllers via the pcs-handle > + property in the MAC device tree node. > + > +properties: > + compatible: > + const: rockchip,rk3568-xpcs > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + clocks: > + items: > + - description: APB3 bus interface clock (clk_csr_i), required for register access > + - description: EEE clock (clk_eee_i), required for Energy Efficient Ethernet operation > + > + clock-names: > + items: > + - const: csr > + - const: eee > + > + phys: > + maxItems: 1 > + > + phy-names: > + const: serdes You don't really need phy-names if there is only 1 entry. > + > + power-domains: > + maxItems: 1 > + > +patternProperties: > + "^ethernet-pcs-mii@[0-3]$": > + type: object > + description: > + One of the four MII ports of the XPCS. The port is linked to an > + Ethernet MAC controller via the pcs-handle property in the MAC's > + device tree node. > + > + properties: > + reg: > + description: MII port number. > + enum: [0, 1, 2, 3] > + > + required: > + - reg Why the child nodes? They don't contain anything. Perhaps that's due to pcs-handle not supporting arg cells to pass the port number? That's about to change[1]. Rob [1] https://github.com/devicetree-org/dt-schema/pull/198 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip