From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89A5ECC6B38 for ; Fri, 16 Oct 2026 04:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T06dleKgF9X8O4Jq6Q4Rqcu6PaY4hrDWPlflaIMxxHc=; b=tXW0JukTLveh8F JkaWWrzSv6zDvA4+AOzQOszh3VtyZzdJyvm0yzHujq53jd75cGgeIj1yqKP9bTgvkAkp6w7Imiot6 IeeHrc82siK0neMmDrze6K2ehfRo7u/6DVDlV8PH/FAAcw7rF2t10ljtApBJ2szuQC2mxsG5ltRT2 k+iO6gKANUCar+DVSzcnjoRMlRCIpvsJJ32L3M54xCRynwNT87ejidlbO/jAvUoh/9SuvDnQwlOmp K0wcaWTCBaSZZDX/AmEp/EfYFYQQdx3ggB7lvh6qGvQx7bODUpA3xaWWzHG89HF3rzG2u+IEjOeEs 8jW4h+DjXGtuxSTn8cWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHZHR-00000001wZu-3OIf; Fri, 16 Oct 2026 04:10:53 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHZHN-00000001wY4-23WI for linux-rockchip@lists.infradead.org; Fri, 16 Oct 2026 04:10:51 +0000 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-2df8c28a0b1so27289575ad.1 for ; Thu, 15 Oct 2026 21:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792123848; x=1792728648; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cRXMnaMYG3V2xMcW/3gwqdrm84/mm5oGaOhlRKzj2Og=; b=i1cy77voNsEL5OxybqQO5nmXjcezbxOUFN8jSRJisxQDe6Nu4B1Q4LEcRFJEwa0PTq 6ceCqvll8zrHPBYD9+GlNRB5pQLoI4wvgS3aPMFDRzDYMelrwCAiCZ4oZS4s+DKukBvB ae0TO3Lvcdpw3ZX8Dtw91Y/vPnBJHMY8eNndO0+lWIYKNIreBXZJk6nmRqqfGO1GTbmJ oZsI57GbK4+EJkx98lGcA9EikxI1EKijkeV5hWHcIKr1uCobmoUu1HmXzMg5+DbkIgcv 8KT4ioiup5sjYGrLIMG4ICU9c7A6GS8HPHt8Y2Fi0pyEcTS+kAMLfCODdtZsC6FRojld Ibiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792123848; x=1792728648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cRXMnaMYG3V2xMcW/3gwqdrm84/mm5oGaOhlRKzj2Og=; b=czPPdILdu4xT0G67BPoJbjL+lizMPqsvxWe1hWRO/jwx4+Fq+nOTAsWMUr0A+TXUp6 sOKDxHykBWk1/tmZJLQgcO2QfgE/nubeM5UBmYoPqS1IJn5uIkkbTmyXrZVzngplUJol OuyPEGFsyWk9muXuBYjDL3Sj5D8BruOp2OxL9bz/RRCUn3RaIepZbG1adO4PLG6+gwW9 Xj3701EHu87KvFZQjGdog6uiynzrEGH26Uf/x7yXEvdnZkNp/RJKDtpaiyRZxCKOEZ3E QBQPjG9l3irG+tcFfB5sQgvRQvjC4LmIz9LiO07YCtlf70xtiXU2ni5oWKnlH1agjK7r NUGg== X-Forwarded-Encrypted: i=1; AKwUvBy2qwITRtnn2D+c2IXLV6hP7GGTOY9sMbwgLI/ON5smFqm83mCiyxlzRqxEYH7OuIJ+k2T+3D3+2nj6JfPyaA==@lists.infradead.org X-Gm-Message-State: AFq9FYJBov3jn7J+jfoWkujB1pB9paeAn2JZqVxHbnUoyzG9absoNZYS 9Ds6L/cHUl2ew2IE/xKlCmIabpAUWT06kpML9n1MIU4PGipXGC3fiaBB X-Gm-Gg: AYBFou2rhM5oQZWii9lTs96jRybDgEFEw2WvwR5wQAEnoej5ykrjjCj5xZuXDD1HyZ7 7mxNJd8n8c+pEo4VgaSILqk5CH10qyLSqaopaq2oWe38cVMwdMmklQaIZD35cDmjFH9pfsq4zFc 2CBKnyZmkW3gnDrW8JgtxxBmaalfXJGw2e3Cxn1vxLfqmlDYxEBxvJk5LYAtJGzfmtV/YrAVgMS 1R8Yj/37vuQf9h+ggCnrgCvRRj6oy5XPZ9BGqjLGztp8EJjDWA2Xyy5qgx0q4JSDcqRrYi/LWaI EKB9lV4Kn9rjsZb18LaS7pRILKgIz3TsS6bf8EJBmec+NRnZgV4AU8fs3b0TGd8cqkYAveqLo5+ u17XKVxHDYsGm51+Y/IMX882R9qyY4/AWoB7H9XoSMzfjTflvpGeSykv3K9GQkHv6GAiTSKwcvc 90VRiv5pHq/lLIQkq2617ojmBhHxTKEdIUTC6PKfaUNueYF7T1+LTfwfh1wi4NbsRob760IqnyZ pUjyoSgS7Yyn2ROMOkfrXdNi9Wf+VvatefAr4oeONrZa4t6GzgpKN7pHjsJLvqBR45mweMRgzl7 mu4r7TZHznEPrw== X-Received: by 2002:a17:903:181:b0:2e9:842d:3c34 with SMTP id d9443c01a7336-2e9842d3dd5mr10658595ad.13.1792123848458; Thu, 15 Oct 2026 21:10:48 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e97e8ab443sm3815785ad.65.2026.10.15.21.10.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 21:10:48 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH 03/11] ASoC: atmel: Explain component open return value handling Date: Fri, 16 Oct 2026 11:09:38 +0700 Message-ID: <20261016040946.521195-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016040946.521195-1-phucduc.bui@gmail.com> References: <20261016040946.521195-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261015_211049_537978_8F2F2DEF X-CRM114-Status: UNSURE ( 9.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc Add a comment explaining why .open() must return 0 on success to ensure proper rollback handling and prevent future changes from reintroducing the issue. Signed-off-by: bui duc phuc --- sound/soc/atmel/atmel-pcm-pdc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/atmel/atmel-pcm-pdc.c b/sound/soc/atmel/atmel-pcm-pdc.c index 552bfa30d4ba..4cedf2ad934d 100644 --- a/sound/soc/atmel/atmel-pcm-pdc.c +++ b/sound/soc/atmel/atmel-pcm-pdc.c @@ -295,6 +295,11 @@ static int atmel_pcm_open(struct snd_soc_component *component, } runtime->private_data = prtd; + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .close() is not skipped on rollback. + */ return 0; out: -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip