From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0367E606A31F for ; Fri, 23 Oct 2026 07:53:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CP5S7Z3m; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=EVFnJAJC DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=Gu0uAUcPuh31GoTh+TSLXEGhC0EE4SJvPbWl0HhQVj0=; b=CP5S7Z3mqZVHYlWXmsn1JfZwtX 04qem/W9meQ8VolfFgqnnWct7U6zXHjeIJxmBDBjavYLSWdHnbSVqeW/jORD83i9IVNG8/thFS+ZH LjeMJ2LcdHQr8SULrkqYxdLLDe4rBufFavPEtYUMFP7TYqisKtht0633girIG4Ks8b/UaFDGZmJ3u 5Z1bj9kmSEms06P1+xxqDlFnGVp3fbfp4DfY2+BAXlD+6fnkBSZz0mNQXe0QRHjdOfOPH0iFuxXRh peZAZHGwwhLo3d8FeBxM/4XCLoQlmpWV913RlpOwDI3aMMzpXgRxJUdf32IsbMAVNYhp64AlGoeUg kB6bI61g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKA5J-0000000FoDU-1UC0; Fri, 23 Oct 2026 07:53:05 +0000 Received: from mail-dl2-x09.google.com ([2607:f8b0:4864:38::9]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKA5G-0000000FoBG-3Txb for linux-rockchip@lists.infradead.org; Fri, 23 Oct 2026 07:53:04 +0000 Received: by mail-dl2-x09.google.com with SMTP id a92af1059eb24-164f08a9e84so136558c88.1 for ; Fri, 23 Oct 2026 00:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792741982; x=1793346782; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LOqLZKJMT/w+vtW751BtQ1dEmz/kTbksIe//V4Kzc00=; b=EVFnJAJCJ4RHOT6XEIff8y1QssBR/Lm6T9kmKm2m8esqRdZmUTUsRlNztZi9o4e4yJ j+6ZPmmhdeGoaSon6MTEvJC9DVI2KSdjyXN3NHCfXzEBgi+qoS8luNUnkv2BI2PY9vBz n8DdzNJXm92lpgTPNjA2bhGwwA9ZvMhEq+SIOoatihYmiWKnaSKy9LttiuHGj5PJUIoP /zlljpEhWP3gRFlho3o1xgLeH2i+mR+pP/OhOkRwbYc1ybNoBMIqkgjPePv7CnBJP5/n IkK8kuLZJEN3o5xRrTP/cc0X5OBmslCr0LVbOq1uM6MKTQ+8tWRCW24M4kIlZzJVd3N9 r6Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792741982; x=1793346782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LOqLZKJMT/w+vtW751BtQ1dEmz/kTbksIe//V4Kzc00=; b=ARw2/2tNzxqj8T9rHgVO67DF7b1d+Jui0P1VUlkVEp+pMTnT8zSY7vZoxWOlAuBTRy q/0aoYxiKpSkxs7BzPGPjRZp1b0irxzhf/7qkGsum7u4e0j1cmuLKYmzmy1+8gT4WCoL tVe+bJtHeZuMEx1g+Omfz8TAGg79AVQ/6uX9BKa2Q30vuez1Q4JsD6w+cBqLdiHhJElB YnK4yYU1A9eymHlzEK7uFXY+RlMHyyNvf+w7iZpDuBZW/bseAKNjiDoiKMkmOxJVhJpc PZGsoUsf7enS/K5c1vxq5ek3y07+nyiiFCdTTWTi1sU8NKWtZaxpGYWtzV1n5S85Gy0Y 88Lw== X-Forwarded-Encrypted: i=1; AKwUvBy7xlxSrPCjKe7xr39nhFENF5AXVSAkX+yI5DZzq64n/TlskLxyStpaXzI+r9eNSHhD337PJPf/9u7QdL1xQQ==@lists.infradead.org X-Gm-Message-State: AFq9FYKd1bWL8/AaOlEzAOf+EgmRN8h2TN2ZJR4HfgH1kF13s2Zq950u sajy2Ki1SmPst0+luu/Ljl76k5UN32tPIcIZQv7bC9JSYPhnBWbYiWN4 X-Gm-Gg: AYBFou1522h+LmJ8sCNEZ/FEojsgTaf4JxiIqUy76kL1ZFOWz0osBIRLslc/goxBm8r ZNMx5bPw5VBEnYmVQXZ3fRAgJf7GB3J2ddpXSMZLUbG2qASvaWT9jg8wJyh978KNPaP9zxxHoZ3 OM9UAW0/u29rpGJSV0WIQ6ok7Nfs15Nt+HhOphribcD95yZAVFegf+PoqmRdXMLKvq4JUhbMjS1 HkR4kAioJfWMaWN3RG4dIsCWuOvXOd+QfpBFOg9KHxrArLC3UpqVzcENSWLm8BeUe+ZdU9SBkQ/ thyEI0hPSakCLqHVEGjhzy5kpIkNinN6P5Fx7KjmR5R1/rFKb4JtLR7CFT41zrCCFSCoymfl8sA cqMGm11LaxF79Eei9vYGwdh4eCDTYvU/Up7VpLBVOl1wfCstuKC15bEG1naJfHFYrvVlqo+OZfR OUVELmTDZ1oxkPK9R8m8OQS6eur3WjxBH4CY5pwP/kDTXe/e8bMToz077ULLqWL6J1adW/jhRfR xfBsOXyJoPkInJQzQB3Zu1R9NviASlY1sKwQ4J6Ut4oG9vOr22m38zcj29xGDQyKvr3efZTqwQ= X-Received: by 2002:a05:701b:2914:b0:187:a2b1:7b3a with SMTP id a92af1059eb24-195c77a82c2mr1718936c88.41.1792741981479; Fri, 23 Oct 2026 00:53:01 -0700 (PDT) Received: from server.lan ([168.138.199.194]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-195eae0e830sm4122132c88.10.2026.10.23.00.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2026 00:53:01 -0700 (PDT) From: Coia Prant To: Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Eric Dumazet , Heiko Stuebner , Coia Prant , netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 1/4] net: pcs: xpcs-plat: fix runtime PM initialization Date: Fri, 23 Oct 2026 15:52:12 +0800 Message-ID: <20261023075214.1793922-3-coiaprant@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261023075214.1793922-2-coiaprant@gmail.com> References: <20261023075214.1793922-2-coiaprant@gmail.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261023_005302_894744_51C154DB X-CRM114-Status: GOOD ( 15.48 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The driver calls pm_runtime_set_active() before runtime PM is enabled and before the CSR clock is prepared and enabled. If the device is later suspended (e.g. during unbind), the runtime suspend callback tries to disable a clock that was never enabled, producing: clk_csr already disabled clk_csr already unprepared Set the initial runtime PM status to suspended instead, and register a devm action that force-suspends the device on teardown. Without that action the CSR clock would stay enabled if the driver is removed while runtime-active, since nothing triggers a runtime suspend on unbind. pm_runtime_force_suspend() is not checked because the runtime suspend callback cannot fail. The clock is enabled on the first runtime resume (e.g. during MDIO access). No upstream platform currently enables this driver with a real CSR clock dependency, so the issue is not reachable in mainline today. It was found while using this driver as a reference for the Rockchip XPCS glue driver. Signed-off-by: Coia Prant --- drivers/net/pcs/pcs-xpcs-plat.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/pcs/pcs-xpcs-plat.c b/drivers/net/pcs/pcs-xpcs-plat.c index e669a7b248ac..11c4239bfd74 100644 --- a/drivers/net/pcs/pcs-xpcs-plat.c +++ b/drivers/net/pcs/pcs-xpcs-plat.c @@ -275,6 +275,14 @@ static int xpcs_plat_init_res(struct dw_xpcs_plat *pxpcs) return 0; } +static void xpcs_plat_exit_clk(void *data) +{ + struct dw_xpcs_plat *pxpcs = data; + struct device *dev = &pxpcs->pdev->dev; + + pm_runtime_force_suspend(dev); +} + static int xpcs_plat_init_clk(struct dw_xpcs_plat *pxpcs) { struct device *dev = &pxpcs->pdev->dev; @@ -285,10 +293,12 @@ static int xpcs_plat_init_clk(struct dw_xpcs_plat *pxpcs) return dev_err_probe(dev, PTR_ERR(pxpcs->cclk), "Failed to get CSR clock\n"); - pm_runtime_set_active(dev); - ret = devm_pm_runtime_enable(dev); + pm_runtime_set_suspended(dev); + pm_runtime_enable(dev); + + ret = devm_add_action_or_reset(dev, xpcs_plat_exit_clk, pxpcs); if (ret) { - dev_err(dev, "Failed to enable runtime-PM\n"); + dev_err(dev, "Failed to register devm for xpcs_plat_exit_clk: %d\n", ret); return ret; } -- 2.47.3 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip