From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D528160A2613 for ; Sun, 1 Nov 2026 19:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=mHQ4EmM4; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=x2OvA7wB DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=mXnyK+OkaRw7oo3TcwiqHS0ar8w6MzRL0g//WqW5ZPw=; b=mHQ4EmM4z41eiyXvVwrzG/och5 vStIgaN03iwKpZbuks3NRyEPR+IArKUrAHl8pm5+KyZBmRbrAro02weZ7GsIazGaNCQxVGyS4WhX3 cZfKTaw6nUyTIAFCqDyyP2KjAJHoPr3VL0oGUT8zUkSJR38vkjRfSehdtOlhuDFfACwKWUKMHAmjC 9f+JPQ5CtuG8h3/E/AaGOnu9GmSm/8soicjDlhHefL+n8Rg8DS0qtj4VfsHN5UWemwbn0xYeNHOAN fDm+tCy6+Ml1eTZa4/igerXh3EPqTuqBh0innIuePjsQCI5a0Eni78cTbI4mAx/M/4Ps3psb2qUCU OUsDn0NQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNbFU-0000000EonQ-1ZQe; Sun, 01 Nov 2026 19:29:48 +0000 Received: from mail-dy2-x08.google.com ([2607:f8b0:4864:36::8]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNbFS-0000000Eokv-1pct for linux-rockchip@lists.infradead.org; Sun, 01 Nov 2026 19:29:47 +0000 Received: by mail-dy2-x08.google.com with SMTP id 5a478bee46e88-36758ba1f01so1182972eec.1 for ; Sun, 01 Nov 2026 11:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793561386; x=1794166186; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1QXiP0o5CtQwTzziGzPYfpYOgoBAHOCYb3Fgk/Di0Jw=; b=x2OvA7wBDd+htpqdaoRM54uULJFTzgo3V/OycM+y7eKGCtT9k5TadqBlCSJmTTImY/ 53Ct4mqq1oozC910YAYgeo9YyGc9V6omtjPSoDn9ihQ5nogXyZyTKffTDyaFzsc3izo7 y0ZgzB5BAl1cgrFGfHZUxlzsF/IaG7zCQbcW2wsZXLDdRZcDqQ22irkppniljjl6MO0D p5CwopN6KI82RYszzyOyhR3BdlwI2u+PjXvwc298I4H8oZ/sNBfOHwoKRFugEnjHlOf6 oKN9gTGyez4Imq8ROXiNb+yfsw58/rnJDzhm7qjrWQjlXEA0BDhnZUnzaVrpL4n9gE0H FW6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793561386; x=1794166186; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1QXiP0o5CtQwTzziGzPYfpYOgoBAHOCYb3Fgk/Di0Jw=; b=exQw1HQE/RhLdG1bim6n0FuECXywhr1HfS+M6HzMlFWt7q4AwAo5D+xEA0ttzU+5UP mhEJ+AQQnrx/WKDLK6tlsSID4Ad2gl9U+EtMrepyQxiJzbgnM64ub4E3jxD81Fg9/ehT ihydnurmswgqcaV/FiAogo1txqPALWyTb07+QKGDke382bi/N3wybqKSa7yu84KSw1bN XohcQCG1mDEs3dqw5x1Q+ZaCkvokAqEuNcg3fu2RVB+kjLD/xVrZ00jZLze7Z82H8vzc +/E1jYRYxOJg7jA9yZG0Hev6ovoFFsQWnBl1S5u09z1KL2BnY9hvLvNFy+qarjvU1vJb KJuA== X-Forwarded-Encrypted: i=1; AKwUvBz4xddiVu4hMOAcC4klXG2QKiSNv/szWSnR32P3cbEZDWLv/1oVL57K55/5rj+wfEp/yC072LaWUzSftkOYzg==@lists.infradead.org X-Gm-Message-State: APuU4Z8gLlQdb+vLxWQkoJbOgR+hhCe7W59Jl62BucDE6ra+0YopuANw C1kXx/TzCSH56NRQSbuNznJjzes/4lxgdLutCg6PndDAKT8hFuYkFRnX X-Gm-Gg: AYBFou1EHRbrlZUH5YwUXjNfiIgM4zT5FIsQnzadMZiVDMDChAEEml+OWLezqwq/fUb C0f1SSZ0+u6fw8C7ShN4v5PNpbEdp7gC/kSfy7VCmnL/SvGWSJalQ2ZMeobpe4c6wJABtJisiMu zTfHf8Ijve6PP/e646U0IT3yNmolC3Kv+32RHhFpNHQ3sjBG97017Ixri4Np42XQuB1/mZetzkC 8khHab2xBCmgDHb9/V6hrtlQJ9YIaDBVZtszZdUn6FjeJNEqjiKtrk2DfNpbMKxCCYSj0H5Zni3 4EqWtKnqMBEjAdbUCJ2BXPB++WPAPw9Fp8sSEFUYThrIYd+IAXdI4aN+NBWDk4p6z99HORU5hAG 3k+TnwvG+ijbBrxUa4fEBtO8noEob1620bVnFeMu3SVAvcjctircN974F941+cUBMBR4PmwYbEu lMTmymWYTyvwhSOiJqhoJoPx9cR2fN9t7jQpj5CxEjaoKVpoxN8x4RMOI99Rh9bL4WNRzDA5gFG C0QDcYwuY9F/Ehh+q3Yo+tIapuDfdK4vXgoQxZPX/5vXYuqBzZ4AOOsfKOao3451yWzGUFyUqEa dKwIVHc/0yp3uvsUek5/Mjo+90A= X-Received: by 2002:a05:693c:69d2:b0:368:9553:f2da with SMTP id 5a478bee46e88-36a423f5c39mr13721930eec.31.1793561385680; Sun, 01 Nov 2026 11:29:45 -0800 (PST) Received: from server.lan ([168.138.199.194]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36a428af1dfsm31471861eec.7.2026.11.01.11.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Nov 2026 11:29:45 -0800 (PST) From: Coia Prant To: Heiko Stuebner Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Frank Wunderlich , Peter Geis , Junhao Xie , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Coia Prant Subject: [PATCH 3/5] arm64: dts: rockchip: fix GMAC clock setup on BPI-R2 Pro Date: Mon, 2 Nov 2026 03:28:05 +0800 Message-ID: <20261101192807.897562-4-coiaprant@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261101192807.897562-1-coiaprant@gmail.com> References: <20261101192807.897562-1-coiaprant@gmail.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261101_112946_477263_58881ED7 X-CRM114-Status: GOOD ( 12.47 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Both GMAC nodes rely on the internal 125 MHz GMAC main clock, but neither pins its rate explicitly. Add assigned-clock-rates = <0>, <125000000> so SCLK_GMACx is fixed at 125 MHz instead of whatever the bootloader or the hardware reset left. The RGMII speed clock (SCLK_GMACx_RX_TX) stays at 0, since it is managed at runtime by rk_set_clk_tx_rate(). For gmac0, also switch clock_in_out from "input" to "output". The port uses a fixed-link, and there is no external 125 MHz clock feeding the MAC, so "input" described a clock source that is not wired up. Note that on RK3568 clock_in_out does not change the hardware clock routing today (rk3568_ops has no io_clksel masks), so this corrects the description rather than the behaviour. Fixes: f901aaadaa2a ("arm64: dts: rockchip: Add Bananapi R2 Pro") Signed-off-by: Coia Prant --- arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts index 4d3ebe50b90ba..677b6261a3a1e 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts @@ -206,7 +206,8 @@ &combphy2 { &gmac0 { assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>; assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>; - clock_in_out = "input"; + assigned-clock-rates = <0>, <125000000>; + clock_in_out = "output"; phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&gmac0_miim @@ -232,6 +233,7 @@ fixed-link { &gmac1 { assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>; assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>, <&cru CLK_MAC1_2TOP>; + assigned-clock-rates = <0>, <125000000>; clock_in_out = "output"; phy-handle = <&rgmii_phy1>; phy-mode = "rgmii"; -- 2.47.3 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip