Re: [PATCH v6 0/2] MIPI DSI phy for rk3588

Heiko Stübner
2025-02-13T21:13:47Z

Am Donnerstag, 13. Februar 2025, 22:05:46 MEZ schrieb Heiko Stuebner:
> This adds the phy driver need for DSI output on rk3588.
>
> The phy itself is used for both DSI output and CSI input, though the
> CSI part for the whole chain needs a lot more work, so is left out for
> now and only the DSI part implemented.
>
> This allows the rk3588 with its current VOP support to drive a DSI display
> using the DSI2 controller driver I'll submit in a next step.
>
> Only generic phy interfaces are used, so the DSI part is pretty straight
> forward.
>
> changes in v6:
> - rebase onto 6.14-rc1
> - add Krzysztof binding review
> - v5 was sent at the beginning of december '24, so probably has been lost
>
> changes in v5:
> - add bitfield.h for the FIELD_PROP definition
> (reported by kernel-test-robot)
> - add Sebastian's Reviewed-by
> - add Conor's Ack to the dt-binding
>
> changes in v4:
> - moved to #phy-cells = 1 as suggested by Sebastian, with the argument
> denoting the requested phy-type (C-PHY, D-PHY). This works similarly
> how the Mediatek C/D-PHY already implements this, see mails around:
> https://lore.kernel.org/all/20230608200552.GA3303349-robh@kernel.org/
> - dropped Krzysztof's review tag from the binding because of this
> - dropped custom UPDATE macro and use FIELD_PREP instead
> - build a FIELD_PREP_HIWORD macro for the GRF settings
> - add received Tested-by tags
>
> changes in v3:
> - add Krzysztof review tag to the binding
> - address Sebastian's review comments
> - better error handling
> - dropping empty function
> - headers
> - not using of_match_ptr - this should also make the
> test-robot happier
>
> changes in v2:
> - fix error in dt-binding example
> - drop unused frequency table
> - pull in some more recent improvements from the vendor-kernel
> which includes a lot less magic values
> - already include the support for rk3576
> - use dev_err_probe
>
> Heiko Stuebner (2):
> dt-bindings: phy: Add Rockchip MIPI C-/D-PHY schema
> phy: rockchip: Add Samsung MIPI D-/C-PHY driver
>
> .../phy/rockchip,rk3588-mipi-dcphy.yaml | 87 +
> drivers/phy/rockchip/Kconfig | 12 +
> drivers/phy/rockchip/Makefile | 1 +
> .../phy/rockchip/phy-rockchip-samsung-dcphy.c | 1604 +++++++++++++++++
> 4 files changed, 1704 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml
> create mode 100644 drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c

Forgot to transplant from the v5 cover-letter - the series got a

Tested-by: Quentin Schulz <quentin.schulz@cherry.de>

on RK3588 Tiger with Haikou Video Demo in [0]

[0] https://lore.kernel.org/r/63cda072-3671-42c9-9650-7a3ece39dec6@cherry.de