Re: [PATCH v1 00/10] Add eDP support for RK3588

Heiko Stübner
2024-12-06T14:37:12Z

Hi Daemon,

Am Mittwoch, 27. November 2024, 08:51:47 CET schrieb Damon Ding:
> These patchs have been tested with a 1536x2048p60 eDP panel on
> RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified
> on RK3588 EVB1 board.
>
> Patch 1~3 are the RK3588 eDP support of Rockchip analogix_dp driver.
> Patch 4 is the eDP mode support of samsung hdptx phy driver.
> Patch 5~6 are the Rk3588 eDP support of Aanalogix DP driver. Add phy
> interfaces is to configure the HDMI/eDP TX Combo PHY.
> Patch 7~8 are the renaming of hdptxphy node. It is not only used by
> HDMI display but also for the eDP display.
> Patch 9 is the addition of RK3588 eDP0 node.
> Patch 10 is to enable the eDP0 display on RK3588S EVB1 board.

Could you maybe also bring over functionality for real bridge-handling?
That way we'd have support for things like the dp-connector bridge.

In the 6.1 vendor-tree I've found commits
94e598190128 ("drm/rockchip: analogix_dp: Add support for external bridge")
437e0a901b14 ("drm/bridge: analogix_dp: Support split mode for bridge chain")

needing a bit of cleanup of course, but that would get rid of the driver
not handling the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag too.

With a bit of streamlining, we could maybe even get rid of the panel-part
completely, similar to how the dw-dsi controllers do it [0]

Thanks
Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c#n335
devm_drm_of_get_bridge() combines drm_of_find_panel_or_bridge()
with devm_drm_panel_bridge_add(), so indepent of it being either a
panel or other bridge, the driver below only needs to handle bridges.

> Damon Ding (10):
> drm/rockchip: analogix_dp: Use formalized struct definition for grf
> field
> dt-bindings: display: rockchip: analogix-dp: Add support for RK3588
> drm/rockchip: analogix_dp: Add support for RK3588
> phy: phy-rockchip-samsung-hdptx: Add support for eDP mode
> drm/bridge: analogix_dp: add support for RK3588
> drm/bridge: analogix_dp: Add support for phy configuration.
> dt-bindings: display: rockchip: Fix label name of hdptxphy for RK3588
> HDMI TX Controller
> arm64: dts: rockchip: Fix label name of hdptxphy for RK3588
> arm64: dts: rockchip: Add eDP0 node for RK3588
> arch64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board
>
> .../rockchip/rockchip,analogix-dp.yaml | 1 +
> .../rockchip/rockchip,rk3588-dw-hdmi-qp.yaml | 2 +-
> arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 33 +-
> .../dts/rockchip/rk3588-coolpi-cm5-evb.dts | 2 +-
> .../rockchip/rk3588-coolpi-cm5-genbook.dts | 2 +-
> .../boot/dts/rockchip/rk3588-evb1-v10.dts | 2 +-
> .../rk3588-friendlyelec-cm3588-nas.dts | 2 +-
> .../arm64/boot/dts/rockchip/rk3588-jaguar.dts | 2 +-
> .../boot/dts/rockchip/rk3588-nanopc-t6.dtsi | 2 +-
> .../dts/rockchip/rk3588-orangepi-5-plus.dts | 2 +-
> .../boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
> .../boot/dts/rockchip/rk3588-tiger-haikou.dts | 2 +-
> .../boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +-
> .../boot/dts/rockchip/rk3588s-evb1-v10.dts | 84 ++
> .../dts/rockchip/rk3588s-indiedroid-nova.dts | 2 +-
> .../boot/dts/rockchip/rk3588s-nanopi-r6.dtsi | 2 +-
> .../boot/dts/rockchip/rk3588s-odroid-m2.dts | 2 +-
> .../boot/dts/rockchip/rk3588s-orangepi-5.dtsi | 2 +-
> .../boot/dts/rockchip/rk3588s-rock-5a.dts | 2 +-
> .../boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
> .../drm/bridge/analogix/analogix_dp_core.c | 8 +-
> .../drm/bridge/analogix/analogix_dp_core.h | 2 +
> .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 90 ++
> .../gpu/drm/rockchip/analogix_dp-rockchip.c | 112 ++-
> .../phy/rockchip/phy-rockchip-samsung-hdptx.c | 936 +++++++++++++++++-
> include/drm/bridge/analogix_dp.h | 3 +-
> 26 files changed, 1206 insertions(+), 97 deletions(-)