Re: [PATCH] ARM: dts: rockchip: add chosen node on veyron chromebooks

Heiko Stübner
2019-02-15T23:08:50Z

Hi Enric,

Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra:
> In order to use earlycon, the stdout-path property needs to be set
> in the chosen node.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

What's the reason for adding this only for the Chromebook variants?
Uart2 is pretty much the standard output for all devices, so I'd assume
at least all veyron boards should use uart2 as well, making this ideally
live in the rk3288-veyron.dtsi instead?

Heiko

> ---
>
> arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi index
> b54746df3661..8890967ed572 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> @@ -62,6 +62,10 @@
> pwm-off-delay-ms = <10>;
> };
>
> + chosen {
> + stdout-path = "serial2:115200n8";
> + };
> +
> gpio-charger {
> compatible = "gpio-charger";
> charger-type = "mains";