From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87B8FC4167B for ; Mon, 27 Nov 2023 15:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rIRp6kG9azOCJOOutLc/pkfMfTtdaK8kiDjQHrosL6M=; b=OMJJA0mDB5w5so tfuIagpk0SvUKjqLFTRYv9tAzyAC3cxXKzOhPEecPuiGSbu4/bB1lUVLwROf6njWxBGl5tp4CQwHK CdcCIEbgiGJtndQqSqxuZwKrUyW8q7PePsI0wZFnemnLisQGxp/K2WBeim1SjK8jmHhpSChPzeYHR bDAOpIq8RZupXMO4LK83PenTkYG9QzqZND724cP5h5S6+6NPEmBErYodtaflaElIrh7Yko/bzOnqD vGh4/oXCiHl/LYPGioAIrXJ/1siyz+IUybg+i1Xkgkd3gw1cSSepOJdX0o2hQctXrA42DKVmNIgi9 J2qk8++NhzGw128MOomg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7d78-002lGQ-1L; Mon, 27 Nov 2023 15:01:34 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7d76-002lEv-2P for linux-rockchip@lists.infradead.org; Mon, 27 Nov 2023 15:01:33 +0000 Received: from i53875bf8.versanet.de ([83.135.91.248] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r7d6y-0003Fi-1u; Mon, 27 Nov 2023 16:01:24 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Andy Yan Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, sebastian.reichel@collabora.com, kever.yang@rock-chips.com, chris.obbard@collabora.com, s.hauer@pengutronix.de, Andy Yan Subject: Re: [PATCH v2 03/12] drm/rockchip: vop2: set half_block_en bit in all mode Date: Mon, 27 Nov 2023 16:01:22 +0100 Message-ID: <23093643.0c2gjJ1VT2@diego> In-Reply-To: <20231122125413.3454489-1-andyshrk@163.com> References: <20231122125316.3454268-1-andyshrk@163.com> <20231122125413.3454489-1-andyshrk@163.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_070132_782897_5993280B X-CRM114-Status: GOOD ( 12.85 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Mittwoch, 22. November 2023, 13:54:13 CET schrieb Andy Yan: > From: Andy Yan > > At first we thought the half_block_en bit in AFBCD_CTRL register > only work in afbc mode. But the fact is that it control the line > buffer in all mode(afbc/tile/line), so we need configure it in > all case. > > Signed-off-by: Andy Yan This looks common to the rk3568 variant, right, so I guess this should have a Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") perhaps? Heiko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip