From: "Heiko Stübner" <heiko@sntech.de>
To: srini@kernel.org, Hrushiraj Gandhi <hrushirajg23@gmail.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Hrushiraj Gandhi <hrushirajg23@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: nvmem: rockchip-efuse: add rockchip,efuse-write-enable property
Date: Wed, 15 Jul 2026 13:42:56 +0200 [thread overview]
Message-ID: <2363663.KTMopqUuYO@diego> (raw)
In-Reply-To: <20260715110107.409204-2-hrushirajg23@gmail.com>
Am Mittwoch, 15. Juli 2026, 13:01:06 Mitteleuropäische Sommerzeit schrieb Hrushiraj Gandhi:
> Add an optional boolean property to explicitly opt in to write (OTP
> programming) support. eFuse bits are one-time-programmable and
> permanently set once written; write support must therefore not be
> enabled by default on arbitrary boards.
>
> Boards that intend to use software-initiated eFuse programming (e.g.
> factory key provisioning) must declare this property and must ensure
> the required VQPS programming supply (1.8V to 1.98V per RK3399 TRM)
> is present and correctly sequenced during writes.
>
> Signed-off-by: Hrushiraj Gandhi <hrushirajg23@gmail.com>
> ---
> .../devicetree/bindings/nvmem/rockchip-efuse.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml
> index b80fd8d1ae5b..8a7195245c84 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml
> @@ -46,6 +46,17 @@ properties:
> this property is defined.
> $ref: /schemas/types.yaml#/definitions/uint32
>
> + rockchip,efuse-write-enable:
> + type: boolean
> + description:
> + Enable write (programming) support for this eFuse block. eFuse bits
> + are one-time-programmable; setting a bit is permanent and cannot be
> + undone. This property must only be set on boards where irreversible
> + OTP programming from software is an intended use case (e.g. factory
> + provisioning), and where the required VQPS programming voltage
> + (1.8V to 1.98V per RK3399 TRM) is guaranteed to be present and
> + correctly sequenced by the board's power design during writes.
Devicetree is not a configuration space, and I think this really does count
as configuration - as the efuse will be writeable on every board.
You mention the VQPS voltage. If I'm reading schematics and application
notes correctly, this is a separate input used solely for writing efuses
and _needs_ to be 0V (off?) during reads.
You mention "needs to be present and correctly sequenced", who is supposed
to turn on/off that regulator?
So you very likely need to define that regulator and can even use its
absence as an indicator to disable writes.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-07-15 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 11:01 [PATCH 0/2] nvmem: rockchip-efuse: add RK3399 OTP write support Hrushiraj Gandhi
2026-07-15 11:01 ` [PATCH 1/2] dt-bindings: nvmem: rockchip-efuse: add rockchip,efuse-write-enable property Hrushiraj Gandhi
2026-07-15 11:42 ` Heiko Stübner [this message]
2026-07-15 11:01 ` [PATCH 2/2] nvmem: rockchip-efuse: add write support for RK3399 Hrushiraj Gandhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2363663.KTMopqUuYO@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hrushirajg23@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox