Re: [PATCH 0/2] drm: devm_drm_bridge_alloc() conversion and cleanup

From: "Heiko Stübner" <heiko@sntech.de>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Sandy Huang <hjc@rock-chips.com>,
	Andy Yan <andy.yan@rock-chips.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
	Huseyin BIYIK <boogiepop@gmx.com>,
	Johan Jonker <jbx6244@yandex.com>
Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] drm: devm_drm_bridge_alloc() conversion and cleanup
Date: Fri, 16 Oct 2026 13:45:22 +0200	[thread overview]
Message-ID: <2372538.iZASKD2KPV@diego> (raw)
In-Reply-To: <d1f0369c-ff43-4b76-9092-5c638b132f15@yandex.com>

Hi Johan,

Am Freitag, 16. Oktober 2026, 10:11:19 Mitteleuropäische Sommerzeit schrieb Johan Jonker:
> If any decency or Code of Conduct left in the DRM group then also credit the original author.
> Also remove driver_private.

after letting that stew in my mind over a lunch break:

- yes, your patch was earlier
- yes, I should've gotten around to it earlier - I am sorry about that
- so yes, this got mishandled

Nevertheless, this in no way justifies attacking the "drm-group", which
consists of a big number of individuals (most of which had no contact with
either variant of the patch at all) on a personal level :-( .

The change itself of moving to devm_drm_bridge_alloc, also is somewhat
straight-forward  that two different people could easily just create the
same change separately, as we saw here.

Heiko

> ===
> 
> [PATCH v3] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API
> https://lore.kernel.org/linux-rockchip/20260904-drm-v3-1-5b36532a3b72@gmail.com/  
> 
> [PATCH v2] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API
> https://lore.kernel.org/linux-rockchip/20260824-drm-v2-1-7f9273c6020b@gmail.com/
> 
> https://lore.kernel.org/linux-rockchip/dea8a038-577b-45da-bff3-703e9099b7e1@gmail.com/
> [PATCH v1] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API
> 
> On 10/16/26 08:52, Luca Ceresoli wrote:
> > 
> > On Thu, 01 Oct 2026 11:25:10 +0300, Cristian Ciocaltea wrote:
> >> Bridge drivers are expected to allocate their private data via
> >> devm_drm_bridge_alloc(), which also initializes the embedded struct
> >> drm_bridge, including its funcs pointer.  Most drivers were converted by
> >> commit 9c399719cfb9 ("drm: convert many bridge drivers from
> >> devm_kzalloc() to devm_drm_bridge_alloc() API"), but a couple of
> >> leftovers remain.
> >>
> >> [...]
> > 
> > Applied, thanks!
> > 
> > [1/2] drm/rockchip: rk3066_hdmi: Convert to devm_drm_bridge_alloc() API
> >       commit: 5c0cdbee4fa4a621f871d6dc825e759db08a1a4a
> > [2/2] drm/bridge: lontium-lt8713sx: Drop redundant bridge funcs assignment
> >       commit: 382c1e8ba409d1611cd256dccebdfa828c832bb1
> > 
> > Best regards,
> 
> 

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip