From: Krzysztof Kozlowski <krzk@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>, heiko@sntech.de
Cc: robh+dt@kernel.org, krzk+dt@kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: clock: fix some conversion issues for rockchip,rk3399-cru.yaml
Date: Sun, 27 Mar 2022 10:00:09 +0200 [thread overview]
Message-ID: <237a1e6a-7e0f-21b6-f8f4-045142f86712@kernel.org> (raw)
In-Reply-To: <20220326102712.20906-1-jbx6244@gmail.com>
On 26/03/2022 11:27, Johan Jonker wrote:
> With the conversion of rockchip,rk3399-cru.txt some issues were added,
> so fix them:
>
> Changed:
> Align the table with external clocks.
> Remove the original author in 2016 as maintainer.
This requires explanation.
> Change clocks maxItems.
This requires explanation. There is no maxItems in clocks.
> Add clock-names.
> Use clock-controller node name in example.
Why?
> Remove assigned-xxx.
> Remove ">" from description.
All this should be around two or three commits, so you need to split
changes which are cleanups to changes affecting functionality (adding
new properties, changing values).
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> .../bindings/clock/rockchip,rk3399-cru.yaml | 32 +++++++------------
> 1 file changed, 11 insertions(+), 21 deletions(-)
>
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2022-03-27 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 10:27 [PATCH v1 1/3] dt-bindings: clock: fix some conversion issues for rockchip, rk3399-cru.yaml Johan Jonker
2022-03-26 10:27 ` [PATCH v1 2/3] arm64: dts: rockchip: rk3399: use generic pmucru nodename Johan Jonker
2022-03-27 8:04 ` Krzysztof Kozlowski
2022-03-26 10:27 ` [PATCH v1 3/3] arm64: dts: rockchip: add clocks property to cru node rk3399 Johan Jonker
2022-03-27 8:00 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237a1e6a-7e0f-21b6-f8f4-045142f86712@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox