From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9254CCD4847 for ; Wed, 4 Sep 2024 18:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xxAThOWcsA9eloYJa7IYWCMT2RKWSOUcAhPlluhigUY=; b=X1hfMiHyNKMZnq 3WTfkrhjo6VxkzBToK3WocFAMs2Jx0jS8l12ycUQGYumHNKJKTqryeNIy4LwF/zqjCTAgyI84D1XE 97bCEa+zXPJaxBFs3n2mB/7vVuryR0PCuOEqI86khI4S9CZ8/rXkpjfCbo1VHq8OxKkZlXL0TZ6C0 Khd36CoCASs6dsC4jt30CVkL5aEKflF+I4UqycqsVPUf18+TDTBOfJMJPAtWScyauajxjT1T3zQLu thMDPP+muN0Kvj6FzqKU9WITgAzZlM5XODxAGyMm0F11ijt73s0HFBP9yYXykIUQBtMvx0OLxwAsF 2BCo40N1sqohvEneIVSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slupY-00000005cbV-2MfU; Wed, 04 Sep 2024 18:34:12 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slumZ-00000005cBX-3TGA for linux-rockchip@lists.infradead.org; Wed, 04 Sep 2024 18:31:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xsW9D7s+rJVWyLcLEN/1kF7Bbwks90r9TRq+eX/cAvA=; b=lvwIowpVS4eylft5U3wylFoti+ qOFMajAAdbhp8/CmajqEcSyNzlVNqBn3DxnIAbvZKDDhAwBnViCNQq0yG+lYieK6qWeherYKltgTE V16P8DNDXlMURTbPJk8/d0CR0nfAHdzxmvHFLUpwjazuMuahKAkVWIIj2lntfHq54K4uC9r8PmyBC BrGUvOOzI+xRKD7VkR2XdWUNEsxsoWXl4Qir2mR3uqEkmueRxAPx6iWbI9nk0bc8OTW+cTVsT1zxQ nH1xCaDA0Mf7HcHy4oGSlGIgZg1ld7+K7Ez3iwRrW7xyMWJQjJq8t6wUjwJEU3Edn5qga7/8mwHtT WG1ltHmw==; Received: from i5e860d0f.versanet.de ([94.134.13.15] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slumW-0002DJ-RZ; Wed, 04 Sep 2024 20:31:04 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: FUKAUMI Naoki Cc: michael.riesch@wolfvision.net, linux-rockchip@lists.infradead.org, FUKAUMI Naoki Subject: Re: [PATCH] arm64: dts: rockchip: add workaround for microSD card detection on Radxa ROCK 3A Date: Wed, 04 Sep 2024 20:32:54 +0200 Message-ID: <2471069.n97fhnxGW3@diego> In-Reply-To: <20240903085551.568-1-naoki@radxa.com> References: <20240903085551.568-1-naoki@radxa.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_113107_932923_EC656934 X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi, Am Dienstag, 3. September 2024, 10:55:50 CEST schrieb FUKAUMI Naoki: > Radxa ROCK 3A doesn't detect microSD card insertion/removal correctly. > it happens from Linux v5.19 to v6.11-rc6. > > add workaround (broken-cd property) to make CD work. > > Fixes: 22a442e6586c ("arm64: dts: rockchip: add basic dts for the radxa rock3 model a") > Signed-off-by: FUKAUMI Naoki before going for such drastic measures as broken-cd, can you describe how you checked the card insert/removal ? I.e. in the dts node below we have both cd-gpios as well as the sdmmc0_det pinctrl which would set the pinfunc 1 ... the hw-based card detect and possibly override the cd-gpios? What happens if you just remove the sdmmc0_det and keep the cd-gpios property? Also, what does cat /sys/kernel/debug/gpio report after that change with inserted and removed cards? Heiko > --- > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > index 59f1403b4fa5..89599258ef9c 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > @@ -722,12 +722,12 @@ &sdhci { > }; > > &sdmmc0 { > + broken-cd; > bus-width = <4>; > cap-sd-highspeed; > - cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>; > disable-wp; > pinctrl-names = "default"; > - pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>; > + pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd>; > sd-uhs-sdr50; > vmmc-supply = <&vcc3v3_sd>; > vqmmc-supply = <&vccio_sd>; > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip