linux-rockchip.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: rockchip: connect hdmi sound in rk3399
@ 2018-06-02 22:07 Vicente Bergas
       [not found] ` <20180602220718.4343-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Vicente Bergas @ 2018-06-02 22:07 UTC (permalink / raw)
  To: Heiko Stübner,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: Vicente Bergas

Everything is in place and working, it only needed to be wired up.

Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 4550c0f82be9..efb3a4481792 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1537,6 +1537,7 @@
 	};
 
 	i2s2: i2s@ff8a0000 {
+		#sound-dai-cells = <0>;
 		compatible = "rockchip,rk3399-i2s", "rockchip,rk3066-i2s";
 		reg = <0x0 0xff8a0000 0x0 0x1000>;
 		interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -1682,7 +1683,25 @@
 		status = "disabled";
 	};
 
+	hdmi_sound: hdmi-sound {
+		status = "disabled";
+		compatible = "simple-audio-card";
+		simple-audio-card,format = "i2s";
+		simple-audio-card,mclk-fs = <256>;
+		simple-audio-card,name = "hdmi-sound";
+
+		simple-audio-card,cpu {
+			sound-dai = <&i2s2>;
+		};
+		simple-audio-card,codec {
+			sound-dai = <&hdmi>;
+		};
+	};
+
 	hdmi: hdmi@ff940000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		#sound-dai-cells = <0>;
 		compatible = "rockchip,rk3399-dw-hdmi";
 		reg = <0x0 0xff940000 0x0 0x20000>;
 		interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH 0>;
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: rockchip: sapphire: enable hdmi sound
       [not found] ` <20180602220718.4343-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-06-02 22:07   ` Vicente Bergas
       [not found]     ` <20180602220718.4343-2-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-06-15  8:40   ` [PATCH 1/2] arm64: dts: rockchip: connect hdmi sound in rk3399 Heiko Stübner
  1 sibling, 1 reply; 4+ messages in thread
From: Vicente Bergas @ 2018-06-02 22:07 UTC (permalink / raw)
  To: Heiko Stübner,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: Vicente Bergas

Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
index e5daed7d2026..38f05d722968 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
@@ -227,6 +227,10 @@
 	status = "okay";
 };
 
+&hdmi_sound {
+	status = "okay";
+};
+
 &i2c0 {
 	clock-frequency = <400000>;
 	i2c-scl-rising-time-ns = <168>;
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm64: dts: rockchip: connect hdmi sound in rk3399
       [not found] ` <20180602220718.4343-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2018-06-02 22:07   ` [PATCH 2/2] arm64: dts: rockchip: sapphire: enable hdmi sound Vicente Bergas
@ 2018-06-15  8:40   ` Heiko Stübner
  1 sibling, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2018-06-15  8:40 UTC (permalink / raw)
  To: Vicente Bergas; +Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

Am Sonntag, 3. Juni 2018, 00:07:17 CEST schrieb Vicente Bergas:
> Everything is in place and working, it only needed to be wired up.
> 
> Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

applied for 4.19 after moving the #sound-dai-cells further down,
same for the status in hdmi_sound and removing the newly added
address-cells+size-cells from the patch.


Thanks
Heiko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] arm64: dts: rockchip: sapphire: enable hdmi sound
       [not found]     ` <20180602220718.4343-2-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-06-15  8:41       ` Heiko Stübner
  0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2018-06-15  8:41 UTC (permalink / raw)
  To: Vicente Bergas; +Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

Am Sonntag, 3. Juni 2018, 00:07:18 CEST schrieb Vicente Bergas:
> Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

applied for 4.19, after giving the patch a simple commit message.


Thanks
Heiko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-06-15  8:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-02 22:07 [PATCH 1/2] arm64: dts: rockchip: connect hdmi sound in rk3399 Vicente Bergas
     [not found] ` <20180602220718.4343-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-06-02 22:07   ` [PATCH 2/2] arm64: dts: rockchip: sapphire: enable hdmi sound Vicente Bergas
     [not found]     ` <20180602220718.4343-2-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-06-15  8:41       ` Heiko Stübner
2018-06-15  8:40   ` [PATCH 1/2] arm64: dts: rockchip: connect hdmi sound in rk3399 Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).