From: "Heiko Stübner" <heiko@sntech.de>
To: FUKAUMI Naoki <naoki@radxa.com>
Cc: robh@kernel.org, conor+dt@kernel.org, inindev@gmail.com,
devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
linux-rockchip@lists.infradead.org, alchark@gmail.com,
FUKAUMI Naoki <naoki@radxa.com>,
krzk+dt@kernel.org, dsimic@manjaro.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: fix USB 3.0 bottom port for Radxa ROCK 5B
Date: Tue, 03 Dec 2024 17:19:55 +0100 [thread overview]
Message-ID: <2724169.KRxA6XjA2N@diego> (raw)
In-Reply-To: <20241130014043.12942-2-naoki@radxa.com>
Am Samstag, 30. November 2024, 02:40:43 CET schrieb FUKAUMI Naoki:
> add rockchip,dp-lane-mux to usbdp_phy1 to make it work properly.
Make it work properly is not an ideal commit description.
I guess the lane assignment for the dp port should be discoverable
in the device schematics, so the commit description should explain
as much.
Heiko
> tested with ELECOM U3HC-A424P10BK[1]:
>
> $ lsusb -t
> /: Bus 001.Port 001: Dev 001, Class=root_hub, Driver=ehci-platform/1p, 480M
> |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 480M
> |__ Port 003: Dev 003, If 0, Class=Wireless, Driver=btusb, 12M
> |__ Port 003: Dev 003, If 1, Class=Wireless, Driver=btusb, 12M
> /: Bus 002.Port 001: Dev 001, Class=root_hub, Driver=ohci-platform/1p, 12M
> /: Bus 003.Port 001: Dev 001, Class=root_hub, Driver=ehci-platform/1p, 480M
> /: Bus 004.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 480M
> /: Bus 005.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> |__ Port 001: Dev 002, If 0, Class=Mass Storage, Driver=usb-storage, 5000M
> /: Bus 006.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 480M
> |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/5p, 480M
> |__ Port 005: Dev 003, If 0, Class=Billboard, Driver=[none], 480M
> /: Bus 007.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 5000M
> |__ Port 004: Dev 003, If 0, Class=Mass Storage, Driver=usb-storage, 5000M
> /: Bus 008.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 480M
> /: Bus 009.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> |__ Port 001: Dev 002, If 0, Class=Mass Storage, Driver=usb-storage, 5000M
>
> [1] https://www.elecom.co.jp/products/U3HC-A424P10BK.html
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index c5776e3b4aab..43fc1f24dfc9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -918,6 +918,7 @@ &usbdp_phy0 {
> };
>
> &usbdp_phy1 {
> + rockchip,dp-lane-mux = <2 3>;
> status = "okay";
> };
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-12-03 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 1:40 [PATCH 1/2] arm64: dts: rockchip: use Type-C port as USB HOST port for Radxa ROCK 5B FUKAUMI Naoki
2024-11-30 1:40 ` [PATCH 2/2] arm64: dts: rockchip: fix USB 3.0 bottom " FUKAUMI Naoki
2024-12-03 16:19 ` Heiko Stübner [this message]
2024-12-03 17:01 ` Sebastian Reichel
2024-12-04 1:33 ` FUKAUMI Naoki
2024-12-03 16:18 ` [PATCH 1/2] arm64: dts: rockchip: use Type-C port as USB HOST " Heiko Stübner
2024-12-03 17:11 ` Sebastian Reichel
2024-12-04 1:31 ` FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2724169.KRxA6XjA2N@diego \
--to=heiko@sntech.de \
--cc=alchark@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=inindev@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox