Re: [PATCH v5 3/3] usb: dwc2: Properly account for the force mode delays

Stefan Wahren
2016-09-13T18:07:25Z

Hi Heiko,

> Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> hat am 12. September 2016 um 13:05
> geschrieben:
>
>
> Hi Stefan,
>
> Am Montag, 12. September 2016, 07:20:44 CEST schrieb Stefan Wahren:
> > > Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> hat am 11. September 2016 um 23:19
> > > geschrieben:
> > > Am Mittwoch, 7. September 2016, 19:39:43 CEST schrieb John Youn:
> > > > When a force mode bit is set and the IDDIG debounce filter is enabled,
> > > > there is a delay for the forced mode to take effect. This delay is due
> > > > to the IDDIG debounce filter and is variable depending on the platform's
> > > > PHY clock speed. To account for this delay we can poll for the expected
> > > > mode.
> > > >
> > > > On a clear force mode, since we don't know what mode to poll for, delay
> > > > for a fixed 100 ms. This is the maximum delay based on the slowest PHY
> > > > clock speed.
> > > >
> > > > Tested-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
> > > > Signed-off-by: John Youn <johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
> > > > ---
> > >
> > > [...]
> > >
> > > > @@ -475,12 +478,6 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg)
> > > >
> > > > __func__, hsotg->dr_mode);
> > > >
> > > > break;
> > > >
> > > > }
> > > >
> > > > -
> > > > - /*
> > > > - * NOTE: This is required for some rockchip soc based
> > > > - * platforms.
> > > > - */
> > > > - msleep(50);
> > > >
> > > > }
> > >
> > > sorry for not finding the time to test your subsequent versions, but this
> > > still
> > > acts up on my Rockchip boards, as I'm still running into errors like
> > >
> > > [ 4.875570] usb usb2-port1: connect-debounce failed
> >
> > could you please name the relevant DTS file of the affected boards?
>
> So far I've been able to see that on
>
> rk3188-radxarock
> rk3036-kylin
>
> both on host-only dwc2 controllers.

thanks, does patch 1 & 2 already have a negative effect on these controllers?

Stefan

>
> Checking my rk3288-veyron-pinky, I see my usb-ethernet coming up correctly and
>
> if I'm not mistaken (some sort of blindness when reading dmesg), there the
> adapter is connected to the real otg dwc2 on there.
>
> So right now it really seems to be limited to host-only dwc2 controllers, but
> I guess I should double check that once I can switch cables around again.
>
>
> Heiko