From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions Date: Sun, 28 Apr 2019 12:40:08 +0200 Message-ID: <2816348.laE8LpYbrI@phil> References: <1556262488-21072-1-git-send-email-wen.yang99@zte.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Markus Elfring Cc: Wen Yang , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Florian Fainelli , linux-kernel@vger.kernel.org, Russell King , Yi Wang List-Id: linux-rockchip.vger.kernel.org Am Sonntag, 28. April 2019, 08:27:05 CEST schrieb Markus Elfring: > > arch/arm/mach-rockchip/platsmp.c | 12 ++++++++++-- > > arch/arm/mach-rockchip/pm.c | 2 ++ > > * Would a commit subject variant be nicer? yeah, but I'll simply adjust that when applying. > * I dare to present a reminder for a recurring development topic. > How do you think about to adjust the exception handling in these function > implementations a bit more according to the Linux coding style > (so that the addition of duplicate function calls would be avoided)? I actually requested not doing wild gotos for of_node_put calls, as it makes the code harder to read, especially when the "node" gets reused for a different node-source.