From: Andy Yan <andy.yan@rock-chips.com>
To: Alex Bee <knaerzche@gmail.com>, Andy Yan <andyshrk@163.com>,
heiko@sntech.de
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
zhengxing@rock-chips.com
Subject: Re: [PATCH v2 1/3] ARM: dts: rockchip: Add psci for rk3036
Date: Thu, 21 Dec 2023 09:07:13 +0800 [thread overview]
Message-ID: <28216be5-810f-40d6-850b-a0fc590ffa3c@rock-chips.com> (raw)
In-Reply-To: <da10e2fc-3179-4bd5-88ed-b4d5f64a7191@gmail.com>
Hi Alex:
On 12/20/23 19:16, Alex Bee wrote:
> Hi Andy,
> Am 18.12.23 um 11:55 schrieb Andy Yan:
>> From: Andy Yan <andy.yan@rock-chips.com>
>>
>> The system will hang at bringup secondary CPUs
>> without psci node.
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>
>> ---
>>
>> (no changes since v1)
>>
>> arch/arm/boot/dts/rockchip/rk3036.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi b/arch/arm/boot/dts/rockchip/rk3036.dtsi
>> index 78686fc72ce6..5344803442a1 100644
>> --- a/arch/arm/boot/dts/rockchip/rk3036.dtsi
>> +++ b/arch/arm/boot/dts/rockchip/rk3036.dtsi
>> @@ -67,6 +67,11 @@ display-subsystem {
>> ports = <&vop_out>;
>> };
>> + psci {
>> + compatible = "arm,psci-1.0";
>> + method = "smc";
>> + };
>> +
> I don't think that's an good idea.
Why?
>You most likely need that because you have downstream bootloader installed on this board. PSCI implementation takes place in TEE-OS for Rockchips ARM SoCs. There is no support for RK3036 in upstream op-tee OS. It's pretty much the same for RK3128 and RK3288.
> If you use upstream u-boot it should be good as-is.
Unfortunately, upstream u-boot also cannot boot up on this board.
At present, I haven't had time to debug what is going on.
Another reason I want to use downstream u-boot it is: I try run
this board with mainline just because i want to test some community
patches about inno-hdmi driver, as you said "the inno-hdmi driver currently gets a lot of attention"[0]
With a downstream u-boot I can easy switch between upstream kernel and downstream kernel(no need to replace other components)
if I found some function is not work as expected.
[0]https://patchwork.kernel.org/project/linux-rockchip/cover/20231219170100.188800-1-knaerzche@gmail.com/
>
> Alex
>> timer {
>> compatible = "arm,armv7-timer";
>> arm,cpu-registers-not-fw-configured;
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-12-21 1:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 10:55 [PATCH v2 0/3] Fix mainline support for rk3036 kylin board Andy Yan
2023-12-18 10:55 ` [PATCH v2 1/3] ARM: dts: rockchip: Add psci for rk3036 Andy Yan
2023-12-20 11:16 ` Alex Bee
2023-12-21 1:07 ` Andy Yan [this message]
2023-12-21 15:58 ` Alex Bee
2023-12-22 10:37 ` Andy Yan
2023-12-22 15:37 ` Alex Bee
2023-12-23 11:14 ` Andy Yan
2023-12-18 10:55 ` [PATCH v2 2/3] ARM: dts: rockchip: Add stdout-path for rk3036 kylin Andy Yan
2023-12-18 10:55 ` [PATCH v2 3/3] ARM: dts: rockchip: Remove rockchip,default-sample-phase from rk3036.dtsi Andy Yan
2023-12-19 10:01 ` Shawn Lin
2023-12-24 19:54 ` (subset) [PATCH v2 0/3] Fix mainline support for rk3036 kylin board Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28216be5-810f-40d6-850b-a0fc590ffa3c@rock-chips.com \
--to=andy.yan@rock-chips.com \
--cc=andyshrk@163.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=knaerzche@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox