Re: [PATCH] arm64: dts: rockchip: add more cpu operating points for RK3328

[Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>]

Hi,

Am Freitag, 1. März 2019, 18:54:53 CET schrieb Leonidas P. Papadakos:
> This allows for greater max frequency on rk3328 boards,
> increasing performance.
> 
> It has been included in Armbian (a linux distibution for ARM boards)
> for a while now without any reported issues
> 
> https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1392mhz-opp.patch
> https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1512mhz-opp.patch
> 
> Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Signed-off-by: Leonidas P. Papadakos <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index 84f14b132..18caef3c3 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -123,6 +123,20 @@
>  			opp-microvolt = <1300000>;
>  			clock-latency-ns = <40000>;
>  		};
> +		opp-1392000000 {
> +			opp-hz = /bits/ 64 <1392000000>;
> +			opp-microvolt = <1350000 1350000 1350000>;
> +			opp-microvolt-L0 = <1350000 1350000 1350000>;
> +			opp-microvolt-L1 = <1325000 1325000 1325000>;

I checked Rockchip's productpage and the chip really seems to be
rated up to 1.5GHz, but you should get rid of opp-microvolt-Lx
options as these are still vendor-specific regarding the leakage
handling.

While on it, when all microvolt elements are the same, using the
absolute value instead of "preferred min max" saves a bit of space
similar to the other OPPs in the file.

Thanks
Heiko

> +			clock-latency-ns = <40000>;
> +		};
> +		opp-1512000000 {
> +			opp-hz = /bits/ 64 <1512000000>;
> +			opp-microvolt = <1450000 1450000 1450000>;
> +			opp-microvolt-L0 = <1450000 1450000 1450000>;
> +			opp-microvolt-L1 = <1425000 1425000 1425000>;
> +			clock-latency-ns = <40000>;
> +		};
>  	};
>  
>  	amba {
>