From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Jonker Subject: Re: [PATCH 2/2] include: dt-bindings: rockchip: remove RK_FUNC defines Date: Tue, 15 Oct 2019 22:26:14 +0200 Message-ID: <29be43a3-516b-ce33-8a19-ffd8202d9c3a@gmail.com> References: <20191015191000.2890-1-jbx6244@gmail.com> <20191015191000.2890-2-jbx6244@gmail.com> <2236841.lnJlJmhppS@phil> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2236841.lnJlJmhppS@phil> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Heiko Stuebner Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org Hi Heiko, What's the plan for RK_FUNC_GPIO ? Change all to '0' or keep it? On 10/15/19 10:10 PM, Heiko Stuebner wrote: > Hi Johan, > > Am Dienstag, 15. Oktober 2019, 21:10:00 CEST schrieb Johan Jonker: >> The defines RK_FUNC_1, RK_FUNC_2, RK_FUNC_3 and RK_FUNC_4 >> are no longer used, so remove them to prevent >> that someone start using them again. > > That won't work. Devicetree provides a slightly flexible promise of > backwards compatibilty. So a new kernel should still work old devicetrees. > (not exactly sure if this means dt-binaries and sources or only binaries) > > So while I think RK_FUNC_0-n should not be used anymore, we should > probably just mark them as "deprecated" in a first step. > > > Heiko