From: Robin Murphy <robin.murphy@arm.com>
To: Heiko Stuebner <heiko@sntech.de>, linux-rockchip@lists.infradead.org
Cc: briannorris@chromium.org, ezequiel@collabora.com,
dianders@chromium.org, linux-arm-kernel@lists.infradead.org,
Emil Renner Berthing <esmil@mailme.dk>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: bulk convert gpios to their constant counterparts
Date: Mon, 8 Apr 2019 13:03:11 +0100 [thread overview]
Message-ID: <29c0db6d-4f63-7104-9ed5-ef2c978c0efe@arm.com> (raw)
In-Reply-To: <20190402121852.14442-2-heiko@sntech.de>
On 02/04/2019 13:18, Heiko Stuebner wrote:
[...]
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts b/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts
> index 931c3dbf1b7d..2a127985ab17 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts
> @@ -125,7 +125,7 @@
> ir {
> ir_rx: ir-rx {
> /* external pullup to VCC3V3_SYS, despite being 1.8V :/ */
> - rockchip,pins = <0 RK_PA6 RK_FUNC_1 &pcfg_pull_none>;
> + rockchip,pins = <0 RK_PA6 1 &pcfg_pull_none>;
> };
> };
> };
Oops - not only has this escaped my deliberate attempt to submit
everything in the preferred format to begin with, but we're not actually
using this pin in PWM mode anyway :(
Regardless, for the patch itself,
Acked-by: Robin Murphy <robin.murphy@arm.com>
Cheers,
Robin.
next prev parent reply other threads:[~2019-04-08 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 12:18 [PATCH 1/2] ARM: dts: rockchip: bulk convert gpios to their constant counterparts Heiko Stuebner
[not found] ` <20190402121852.14442-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2019-04-02 12:18 ` [PATCH 2/2] arm64: " Heiko Stuebner
2019-04-06 15:56 ` Katsuhiro Suzuki
2019-04-08 12:03 ` Robin Murphy [this message]
2019-04-11 12:40 ` [PATCH 1/2] ARM: " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29c0db6d-4f63-7104-9ed5-ef2c978c0efe@arm.com \
--to=robin.murphy@arm.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=esmil@mailme.dk \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox