From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tim Lunn <tim@feathertop.org>,
linux-rockchip@lists.infradead.org, conor.dooley@microchip.com,
robh+dt@kernel.org, devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Chris Zhong <zyw@rock-chips.com>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>, Zhang Qing <zhangqing@rock-chips.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] dt-bindings: rockchip: rk809: Document audio codec clock
Date: Mon, 22 Jan 2024 09:16:05 +0100 [thread overview]
Message-ID: <2e9ae099-18a3-4e22-8868-931d41c81f3f@linaro.org> (raw)
In-Reply-To: <20240120135529.899403-4-tim@feathertop.org>
On 20/01/2024 14:55, Tim Lunn wrote:
> Rockchip RK809 shares the same audio codec block as the rk817 mfd, and
What rk817 has anything to do with this?
> is compatible with the existing rk817_codec driver. This patch
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> introduces the clock required for the audio codec.
>
> This clock provides the I2S master clock for the audio data. The codec
> driver finds the clock by the name "mclk" and will fail to register if
> this is missing. Clock-names is kept here to keep compatibility with the
> exisitng driver ABI and also to be consistent with the rk817 binding.
Typo.
Also, what consistency with rk817 driver?
I really do not understand which problem you are solving here.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-01-22 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 13:55 [PATCH v3 0/3] dt-bindings: rockchip: Add support for rk809 audio codec Tim Lunn
2024-01-20 13:55 ` [PATCH v3 1/3] dt-bindings: rockchip: rk809 fix existing example Tim Lunn
2024-01-20 13:55 ` [PATCH v3 2/3] dt-bindings: rockchip: rk809: Document audio codec properties Tim Lunn
2024-01-22 8:14 ` Krzysztof Kozlowski
2024-01-23 4:10 ` Tim Lunn
2024-01-23 7:37 ` Krzysztof Kozlowski
2024-01-23 8:33 ` Tim Lunn
2024-01-20 13:55 ` [PATCH v3 3/3] dt-bindings: rockchip: rk809: Document audio codec clock Tim Lunn
2024-01-22 8:16 ` Krzysztof Kozlowski [this message]
2024-01-23 4:25 ` Tim Lunn
2024-01-23 7:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e9ae099-18a3-4e22-8868-931d41c81f3f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=tim@feathertop.org \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox