From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C0F2C433F5 for ; Thu, 5 May 2022 08:47:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VLNkKgep3n2PqnNeSzP1INXSV8MfZnPHYu18/YAxldU=; b=uK0veS7RKosZCq gOdn+bSFIrdkB2eHcQL3DgNq/F1XBujk7n+gTX29M/NB30tR6EBREDUuKIAwxldUB7zoib1EJLDaU GjpibtTl2qMPCQRIGI+awCuZY7DVO6uLQNSfOyC+/OeZAxK4uPOx1QdHtS2fz6arH6q8iPIiCIb8z txgcZqS+O7FtUJqsHwG2DH2lYeQ4sAC7ghk9q3hBT1++x5CKkOZORyl3qNz7/B+pYELavQakceexi xm9sB2/YSufXNiwaTl1aR2s83zREHOlhVEavTUwM+UojxokXIELVxjwe2duGof82VBZY9pqsD68Dl xcnzVgjBxJYKmmagO2JA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmX8c-00Eomt-Ao; Thu, 05 May 2022 08:47:06 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmX8Y-00EoiO-MW for linux-rockchip@lists.infradead.org; Thu, 05 May 2022 08:47:04 +0000 Received: by mail-wr1-x436.google.com with SMTP id b19so5121904wrh.11 for ; Thu, 05 May 2022 01:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=KAi9SgYYEJZdQCddUzbx52lypx3cIglFyl/qHafebhw=; b=tkNfdzaaxw1oNzzHEFi5PsCP9pSRB2g18WUgVkc6DnnNJz4opSwgzEVFoUUkq98Kud DmFNXaVYExw1NuJr8DqujznLa2az0lWDiTc0qWvNUCAP5r5OW9iSR8QEqSlWZJONTS4P F30VkUEk9v9uHoJqLqcvFr87lcceheNYz87udcrXOAHtFnIyEOvlcZaxaIZkOdNhT30Y dB4ud6EWIxegH+EYbtLr/2s0zJ21Uw2TaCRSfxNT1dPyuAPqkA2Ti2WZXu8bcR/8mxNC eMgh7vO/iGZwuEnOROZ+GPB0E6E/imyXgauO3i4m/vz/qEwWxwP3ttMVK1mz2Ist0shg sbpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KAi9SgYYEJZdQCddUzbx52lypx3cIglFyl/qHafebhw=; b=tY9QIQSmIibRPxuSewfvB/cnqP7F5WMUmAWiDx9WgkRczuevvflR5c+XfOkSRn7oon WqtgwPRBwLGsTClvtNKtGe/7hLLv/n2rhTvpCbpPAqclNYfqOc1jdOzO9wB5JP96hcJ+ YSZ59FfzcH6fNkDudCowEt3kEWAbvpTDtcbo/a9dKewhB66wtx6s/+3uLvKgp5wTPAXO E7EIP0+prUnF59oF2VlOmCDs3YIj71+o1Vsjn3lFRO4vAyvlReZ0ulQ+gQYlCv2V61TV 5IQcY8PxfBdEmDuMFzC4x+6c0g+zwWTAV8GCi7zOtZPg2BjREFavcwRloxGLQhqXIBv8 4ZLA== X-Gm-Message-State: AOAM530/ftUUh+6OhV9F8pcxbpLIOiy/MS1oUvIGRx5LPIYmdWsmqtVf tHgj4uNYLby5hWTk+i2cg+yOQA== X-Google-Smtp-Source: ABdhPJx0cG82J35HyxF+U/lAjaHUyieUfdukDsGukXiyDflYgKWosvfKkWmN+5Kvijh4a8XoYMPHpw== X-Received: by 2002:a5d:6551:0:b0:20a:e23c:a7fa with SMTP id z17-20020a5d6551000000b0020ae23ca7famr19657153wrv.535.1651740417622; Thu, 05 May 2022 01:46:57 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id 67-20020a1c1946000000b003942a244f2csm6771728wmz.5.2022.05.05.01.46.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 01:46:57 -0700 (PDT) Message-ID: <313a5b2e-c571-a13f-3447-b1cd7200f4c9@linaro.org> Date: Thu, 5 May 2022 10:46:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [RFC v2 4/4] arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board Content-Language: en-US To: Vladimir Oltean , Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Matthias Brugger , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20220430130347.15190-1-linux@fw-web.de> <20220430130347.15190-5-linux@fw-web.de> <20220504152450.cs2afa4hwkqp5b5m@skbuf> <20220504154720.62cwrz7frjkjbb7u@skbuf> From: Krzysztof Kozlowski In-Reply-To: <20220504154720.62cwrz7frjkjbb7u@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_014702_800571_12984693 X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 04/05/2022 17:47, Vladimir Oltean wrote: >> >> current device-tree nodes using "switch" and "ports" >> >> see discussioon here about make it fixed to "ports" property instead of PatternProperties including optional "ethernet-" >> >> https://patchwork.kernel.org/project/linux-mediatek/patch/20220502153238.85090-1-linux@fw-web.de/#24843155 > > Hmm, I don't get why Krzysztof said to just keep what is used in > existing device trees. The schema validator should describe what is > valid, These were talks about bindings which describe hardware. The node name, except Devicetree spec asking for generic names, does not matter here actually. > and since the mt7530 driver does not care one way or another > (some drivers do explicitly parse the "ports"/"ethernet-ports" node), > then whatever is valid for the DSA core is also valid for the mt7530 > bindings. And "ethernet-ports" is valid too, so I think it should be > accepted by mediatek.yaml... You can make it "(ethernet-)?ports" as well. My comment was purely to make it simpler, for bindings (goes into properties, not patternProperties) and for us. If you prefer to keep it like DSA core, also fine. Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip