From: Dragan Simic <dsimic@manjaro.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Tim Lunn <tim@feathertop.org>, Jagan Teki <jagan@edgeble.ai>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 4/9] ARM: dts: rockchip: rv1126: Add i2c2 nodes
Date: Tue, 12 Dec 2023 09:04:55 +0100 [thread overview]
Message-ID: <316304f17b7e2641658d0efc867c0603@manjaro.org> (raw)
In-Reply-To: <6efa5eb17d795da024357a12dfb11ac1@manjaro.org>
On 2023-11-27 14:07, Dragan Simic wrote:
> On 2023-11-27 12:10, Heiko Stübner wrote:
>> Am Montag, 27. November 2023, 11:55:21 CET schrieb Dragan Simic:
>>> On 2023-11-27 11:50, Heiko Stübner wrote:
>>>> Am Montag, 27. November 2023, 11:43:05 CET schrieb Dragan Simic:
>>>>> Please note there's already an Ethernet alias defined in
>>>>> rk3399.dtsi,
>>>>> even despite not all RK3399-based devices using the GMAC, for
>>>>> example
>>>>> the Pinebook Pro. Perhaps that's something to be fixed as well.
>>>>
>>>> possibly :-)
>>>>
>>>> I guess for starters we shouldn't introduce new instances for it.
>>>
>>> Totally agreed.
>>>
>>> > All the newer SoCs already have their ethernet alias in the board dts
>>> > (rk356x, rk3568) which came after we also moved the mmc aliases.
>>>
>>> The base rk3399.dtsi file and the RK3399-based board/device dts(i)
>>> files
>>> are fine when it comes to the mmc aliases. I can move forward and
>>> clean
>>> up the Ethernet alias as well, if you agree?
>>
>> Yep, we moved mmc aliases a while ago.
>>
>> So moving the ethernet sounds like the right way forward. So if you
>> have
>> the time for it, then I'd be quite happy to take patches for that
>> change.
>
> Great, thanks. I'll prepare the patches in the next couple of days,
> and send them over.
I apologize for the delay, I finally got around to implementing and
verifying these patches for the RK3399, RK3368, RK3328 and PX30 SoC
dts(i) files. [1] The way I verified them was to compare the compiled
dtb files before and after applying the patches.
Also, I went ahead and implemented the patches that add ethernet aliases
to the RK356x and RK3588 dts board files. [2] With these patches in
place, together with the other patches that have already been accepted,
we should have a rather clean situation when it comes to the Rockchip
arm64 DT aliases.
[1]
https://lore.kernel.org/linux-rockchip/cover.1702366958.git.dsimic@manjaro.org/T/#u
[2]
https://lore.kernel.org/linux-rockchip/cover.1702368023.git.dsimic@manjaro.org/T/#u
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-12-12 8:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 12:22 [PATCH v2 0/9] Add support for Sonoff iHost RV1126 Smart Home Gateway Tim Lunn
2023-11-22 12:22 ` [PATCH v2 1/9] ARM: dts: rockchip: rv1126: Add alternate UART pins Tim Lunn
2023-11-22 12:22 ` [PATCH v2 2/9] ARM: dts: rockchip: rv1126: Serial aliases Tim Lunn
2023-11-22 12:29 ` Krzysztof Kozlowski
2023-11-22 12:22 ` [PATCH v2 3/9] i2c: rk3x: Adjust offset for i2c2 on rv1126 Tim Lunn
2023-11-26 19:43 ` Andi Shyti
2023-11-27 0:26 ` Heiko Stübner
2023-11-27 10:11 ` Tim Lunn
2023-11-27 21:57 ` Andi Shyti
2023-11-22 12:22 ` [PATCH v2 4/9] ARM: dts: rockchip: rv1126: Add i2c2 nodes Tim Lunn
2023-11-22 12:29 ` Krzysztof Kozlowski
2023-11-22 13:09 ` Tim Lunn
2023-11-26 23:06 ` Heiko Stübner
2023-11-27 6:52 ` Krzysztof Kozlowski
2023-11-27 9:23 ` Tim Lunn
2023-11-27 9:27 ` Krzysztof Kozlowski
2023-11-27 9:45 ` Heiko Stübner
2023-11-27 9:58 ` Tim Lunn
2023-11-27 10:29 ` Heiko Stübner
2023-11-27 10:43 ` Dragan Simic
2023-11-27 10:50 ` Heiko Stübner
2023-11-27 10:55 ` Dragan Simic
2023-11-27 11:10 ` Heiko Stübner
2023-11-27 13:07 ` Dragan Simic
2023-12-12 8:04 ` Dragan Simic [this message]
2023-11-27 12:52 ` Tim Lunn
2023-11-27 23:11 ` Alex Bee
2023-11-27 23:35 ` Heiko Stübner
2023-11-22 12:22 ` [PATCH v2 5/9] ARM: dts: rockchip: rv1126: Split up rgmii1 pinctrl Tim Lunn
2023-11-22 12:22 ` [PATCH v2 6/9] ARM: dts: rockchip: rv1126: Add ethernet alias Tim Lunn
2023-11-22 12:22 ` [PATCH v2 7/9] ARM: dts: rockchip: Add rv1109 SoC Tim Lunn
2023-11-22 12:22 ` [PATCH v2 8/9] ARM: dts: Add Sonoff iHost Smart Home Hub Tim Lunn
2023-11-22 12:22 ` [PATCH v2 9/9] dt-bindings: arm: rockchip: Add Sonoff iHost Tim Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=316304f17b7e2641658d0efc867c0603@manjaro.org \
--to=dsimic@manjaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=tim@feathertop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox