From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B10C433DB for ; Mon, 18 Jan 2021 18:04:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42C6922CA0 for ; Mon, 18 Jan 2021 18:04:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42C6922CA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1SAuyWT9mKf9hF9tOcBoPWTp7bzAdZGLSdmcIxPQJJs=; b=oc7Jkrzwrb5sqxePedp88fJji v0IeFnE8NPQJUcmpRdrL6E2W5v2V/1N5fd8PG4qgPxvTUHrTT5VyFOTtxrTEnoyNlNr/dgUd6s6tp BwJJ/6ua2clbPmeC7eoF1wvn/upXRErOCcWbtZxJ6rQG9ka2YaOcc1/NbX+A+guJwHHfJ6KgOY9jH tXTyMXD2tnlzTxmqvrRigj+CztVnizSeC8lXXLZ9mHAyRN1iqNQGNUalYkZpxhhVdsLqLQevXy3XG M3piWoe8tKo2CpdmteXKeZo5PK/Rf9E8D4AO91alWHtTYOhN2VRxseTf9tZ1fnA5UcbzJ+WKTa9+U xpBI+CDGw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Yss-0005in-6K; Mon, 18 Jan 2021 18:04:10 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Ysq-0005hi-HD for linux-rockchip@lists.infradead.org; Mon, 18 Jan 2021 18:04:09 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: koike) with ESMTPSA id EA5C11F44836 Subject: Re: [PATCH v6 2/4] media: rockchip: rkisp1: reduce number of histogram grid elements in uapi To: Heiko Stuebner , dafna.hirschfeld@collabora.com, linux-media@vger.kernel.org, mchehab@kernel.org, Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl References: <20210118110448.275389-1-heiko@sntech.de> <20210118110448.275389-3-heiko@sntech.de> From: Helen Koike Message-ID: <31c655ca-ec76-6135-5e05-5d2f62a48ff5@collabora.com> Date: Mon, 18 Jan 2021 15:04:01 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210118110448.275389-3-heiko@sntech.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_130408_674286_582C3292 X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-rockchip@lists.infradead.org, tfiga@chromium.org, ezequiel@collabora.com, christoph.muellner@theobroma-systems.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 1/18/21 8:04 AM, Heiko Stuebner wrote: > From: Heiko Stuebner > > The uapi right now specifies an array size of 28 but the actual number > of elements is only 25 with the last 3 being unused. > > Reduce the array size to the correct number of elements. > > Signed-off-by: Heiko Stuebner Acked-by: Helen Koike > --- > include/uapi/linux/rkisp1-config.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h > index ba443771cc0b..ecfb8f7a6c70 100644 > --- a/include/uapi/linux/rkisp1-config.h > +++ b/include/uapi/linux/rkisp1-config.h > @@ -102,8 +102,7 @@ > /* > * Histogram calculation > */ > -/* Last 3 values unused. */ > -#define RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE 28 > +#define RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE 25 > > /* > * Defect Pixel Cluster Correction > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip