From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4368FCF34A9 for ; Wed, 19 Nov 2025 12:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F3p1v7AxOlYDnFQXYpGoOAC1SZJzGokCm52cHGZg0DA=; b=bCBYzmUxfCM9B/ QJYsPA/sPKSuIjPhnSG1taX4Z5ck5zDR6Qh1O1NCyU9gjyJFniqLOv5YQ5Lmk7LNT/aIpjYM0i03I WkY+ao+ATD/w97fE3+1VJrbPTo248NFxQzTbGGbSedtVf0/6DxvRa9PRW246RzaTJNc1VbZLSJRH9 ga0OsL/MDyo9D5Ut4khi0uJ41hSDcn2XU3Vt5fMcmaP1CLEJkxNztUJ8COVg1ipK0P9qBqf+K6skO xNNrTNZn48L7v3WdFUJoSlbxtc+eGZtXWsAGV3Ns0AwlUvvXDNm9BX/o5G+lbrSlo/ItuZrNdJ2ap tStengasFjEiehmQyfuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLhes-00000003CLy-1SbT; Wed, 19 Nov 2025 12:51:38 +0000 Received: from sender3-pp-f112.zoho.com ([136.143.184.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLheo-00000003CLI-3rDj; Wed, 19 Nov 2025 12:51:36 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1763556663; cv=none; d=zohomail.com; s=zohoarc; b=AyRIM5Y8RIGa5LyOoq0ccUAqnmzs53sijHthacfrKaiSLAm9MaxJZ5oRJSI52Zc0jAQq2DzhM9uZW043CZztPNGRiHbPCuKIkRmfeBgaBrzIRvpPbgLVM8un06SMTnxKPWkDPYr3h0v/NZIlUMRzfDM9lGeimvaV33AnO2KbiOI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763556663; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=PjuIE5XQCboZaBC3kZXhkSfHggXBEuTBZO5PYZyfkLI=; b=Ct/N8eh9hNemhqXrIJKdvoisgw1Z0eA98iQMGiynN9RZdQ0MEgjFU2CS9kZCb+Cro/LxUk6AXgfjkNXG2QnydB4MKt/WjhKKlSti8yR5M6TEkRd7SfHAa34OwP1zIqVsJanOcqeD6uN2G02lxdJGIpXPqREUfQlSfyQvFs+IpC0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1763556663; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=PjuIE5XQCboZaBC3kZXhkSfHggXBEuTBZO5PYZyfkLI=; b=iTWTuAU6cKXXC5+qEq7RmZPcbx7yn2KLD3qIr5NdhMeNoNFTO2slMNjxIcO8BYgi aP2NKf8/uhyI1L0zYuxbhohbtSnjqRXh0iZBXu4am5SToLWSKJi+xyiOP1R8K9Y+77b 7PmmIrjQJX8rKaeOAenKpSMrKpkDmgdlZMF4VeNE= Received: by mx.zohomail.com with SMTPS id 1763556660590486.6645799254244; Wed, 19 Nov 2025 04:51:00 -0800 (PST) From: Nicolas Frattaroli To: Laurent Pinchart Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?UTF-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v4 04/10] drm/bridge: Act on the DRM color format property Date: Wed, 19 Nov 2025 13:50:51 +0100 Message-ID: <3210678.irdbgypaU6@workhorse> In-Reply-To: <20251119043246.GY10711@pendragon.ideasonboard.com> References: <20251117-color-format-v4-0-0ded72bd1b00@collabora.com> <20251117-color-format-v4-4-0ded72bd1b00@collabora.com> <20251119043246.GY10711@pendragon.ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251119_045135_007254_991B6126 X-CRM114-Status: GOOD ( 32.63 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wednesday, 19 November 2025 05:32:46 Central European Standard Time Laurent Pinchart wrote: > On Mon, Nov 17, 2025 at 08:11:48PM +0100, Nicolas Frattaroli wrote: > > The new DRM color format property allows userspace to request a specific > > color format on a connector. In turn, this fills the connector state's > > color_format member to switch color formats. > > > > Make drm_bridges consider the color_format set in the connector state > > during the atomic bridge check. Specifically, reject any output bus > > formats that do not correspond to the requested color format. > > > > Signed-off-by: Nicolas Frattaroli > > --- > > drivers/gpu/drm/drm_bridge.c | 57 ++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 57 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > > index 8f355df883d8..b7df5cbad832 100644 > > --- a/drivers/gpu/drm/drm_bridge.c > > +++ b/drivers/gpu/drm/drm_bridge.c > > @@ -1052,6 +1052,59 @@ static int select_bus_fmt_recursive(struct drm_bridge *first_bridge, > > return ret; > > } > > > > +static bool __pure bus_format_is_color_fmt(u32 bus_fmt, enum drm_color_format fmt) > > +{ > > + if (bus_fmt == MEDIA_BUS_FMT_FIXED) > > + return true; > > + > > + switch (fmt) { > > + case DRM_COLOR_FORMAT_NONE: > > + case DRM_COLOR_FORMAT_AUTO: > > + return true; > > + case DRM_COLOR_FORMAT_RGB444: > > + switch (bus_fmt) { > > + case MEDIA_BUS_FMT_RGB888_1X24: > > + case MEDIA_BUS_FMT_RGB101010_1X30: > > + case MEDIA_BUS_FMT_RGB121212_1X36: > > + case MEDIA_BUS_FMT_RGB161616_1X48: > > + return true; > > + default: > > + return false; > > + } > > + case DRM_COLOR_FORMAT_YCBCR444: > > + switch (bus_fmt) { > > + case MEDIA_BUS_FMT_YUV8_1X24: > > + case MEDIA_BUS_FMT_YUV10_1X30: > > + case MEDIA_BUS_FMT_YUV12_1X36: > > + case MEDIA_BUS_FMT_YUV16_1X48: > > + return true; > > + default: > > + return false; > > + } > > + case DRM_COLOR_FORMAT_YCBCR422: > > + switch (bus_fmt) { > > + case MEDIA_BUS_FMT_UYVY8_1X16: > > + case MEDIA_BUS_FMT_UYVY10_1X20: > > + case MEDIA_BUS_FMT_UYVY12_1X24: > > + return true; > > + default: > > + return false; > > + } > > + case DRM_COLOR_FORMAT_YCBCR420: > > + switch (bus_fmt) { > > + case MEDIA_BUS_FMT_UYYVYY8_0_5X24: > > + case MEDIA_BUS_FMT_UYYVYY10_0_5X30: > > + case MEDIA_BUS_FMT_UYYVYY12_0_5X36: > > + case MEDIA_BUS_FMT_UYYVYY16_0_5X48: > > + return true; > > + default: > > + return false; > > + } > > + } > > I'd find this more readable: > > if (fmt == DRM_COLOR_FORMAT_NONE || fmt == DRM_COLOR_FORMAT_AUTO) > return true; > > switch (bus_fmt) { > case MEDIA_BUS_FMT_RGB888_1X24: > case MEDIA_BUS_FMT_RGB101010_1X30: > case MEDIA_BUS_FMT_RGB121212_1X36: > case MEDIA_BUS_FMT_RGB161616_1X48: > return fmt == DRM_COLOR_FORMAT_RGB444: > > case MEDIA_BUS_FMT_YUV8_1X24: > case MEDIA_BUS_FMT_YUV10_1X30: > case MEDIA_BUS_FMT_YUV12_1X36: > case MEDIA_BUS_FMT_YUV16_1X48: > return fmt == DRM_COLOR_FORMAT_YCBCR444; > > case MEDIA_BUS_FMT_UYVY8_1X16: > case MEDIA_BUS_FMT_UYVY10_1X20: > case MEDIA_BUS_FMT_UYVY12_1X24: > return fmt == DRM_COLOR_FORMAT_YCBCR422; > > case MEDIA_BUS_FMT_UYYVYY8_0_5X24: > case MEDIA_BUS_FMT_UYYVYY10_0_5X30: > case MEDIA_BUS_FMT_UYYVYY12_0_5X36: > case MEDIA_BUS_FMT_UYYVYY16_0_5X48: > return fmt == DRM_COLOR_FORMAT_YCBCR420; > > default: > return false; > } > > but it could be a matter for personal preference ? I agree, that is nicer. > > I'm also a bit concerned about the > > if (fmt == DRM_COLOR_FORMAT_NONE || fmt == DRM_COLOR_FORMAT_AUTO) > > test. What's the difference between NONE and AUTO ? Is it meaningful, or > should the two enumerators be merged into a single one ? I've noticed that as well but didn't act on it before sending out v4. I think we should try to make them the same yes. I don't see a valid reason why anything would ever set "NONE" when it means "AUTO". If there is a non-AUTO "NONE" case to describe an invalid format, then this code is wrong anyways. I'll do some digging. > > + > > + return false; > > +} > > + > > /* > > * This function is called by &drm_atomic_bridge_chain_check() just before > > * calling &drm_bridge_funcs.atomic_check() on all elements of the chain. > > @@ -1137,6 +1190,10 @@ drm_atomic_bridge_chain_select_bus_fmts(struct drm_bridge *bridge, > > } > > > > for (i = 0; i < num_out_bus_fmts; i++) { > > + if (!bus_format_is_color_fmt(out_bus_fmts[i], conn_state->color_format)) { > > + ret = -ENOTSUPP; > > + continue; > > + } > > ret = select_bus_fmt_recursive(bridge, last_bridge, crtc_state, > > conn_state, out_bus_fmts[i]); > > if (ret != -ENOTSUPP) > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip