Re: [PATCH 06/38] dt-bindings: add power-domain header for RK3562 SoC

Krzysztof Kozlowski
2024-12-21T20:24:41Z

On 20/12/2024 12:04, Kever Yang wrote:
> From: Finley Xiao <finley.xiao@rock-chips.com>
>
> According to a description from TRM, add all the power domains.
>
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>

1. Split your series per subsystem (and learn which subsystems are
involved here), this is really unnecessary patch bomb.
2. Header goes always with DT bindings.

> ---
>
> include/dt-bindings/power/rk3562-power.h | 35 ++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 include/dt-bindings/power/rk3562-power.h
>
> diff --git a/include/dt-bindings/power/rk3562-power.h b/include/dt-bindings/power/rk3562-power.h
> new file mode 100644
> index 000000000000..616b5b9be3e1
> --- /dev/null
> +++ b/include/dt-bindings/power/rk3562-power.h
> @@ -0,0 +1,35 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

3. Dual license.

4.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.


All these apply to all your patches. I won't be reviewing the rest.

Best regards,
Krzysztof