Re: [PATCH 05/38] pinctrl: rockchip: add rk3562 support

Heiko Stübner
2024-12-22T16:05:59Z

Am Freitag, 20. Dezember 2024, 12:04:03 CET schrieb Kever Yang:
> From: Steven Liu <steven.liu@rock-chips.com>
>
> Add support for the 5 GPIO banks in the rk3562.
>
> Signed-off-by: Steven Liu <steven.liu@rock-chips.com>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> drivers/pinctrl/pinctrl-rockchip.c | 199 ++++++++++++++++++++++++++++-
> drivers/pinctrl/pinctrl-rockchip.h | 3 +-
> 2 files changed, 200 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index 36d4eaf0ebd1..c919437a1dbc 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> * Pinctrl driver for Rockchip SoCs
> + * Copyright (c) 2020-2024 Rockchip Electronics Co., Ltd.
> *
> * Copyright (c) 2013 MundoReader S.L.
> * Author: Heiko Stuebner <heiko@sntech.de>

nitpick: it would look nicer to keep the Copyright blocks together, like

* Pinctrl driver for Rockchip SoCs
*
+ * Copyright (c) 2020-2024 Rockchip Electronics Co., Ltd.
* Copyright (c) 2013 MundoReader S.L.
* Author: Heiko Stuebner <heiko@sntech.de>

other than that, the rk3562 variant looks quirk-free, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Heiko