public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
To: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	"Enric Balletbo i Serra"
	<enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: gwendal-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 1/6] phy: rockchip-typec: fall back to working in host-mode if extcon is missing.
Date: Fri, 16 Mar 2018 11:29:59 +0530	[thread overview]
Message-ID: <32f24fca-7d89-6edf-26a4-8dc7d1d1ea31@ti.com> (raw)
In-Reply-To: <20019382.PXhIOVQJGo@diego>



On Wednesday 14 March 2018 01:44 PM, Heiko Stübner wrote:
> Hi Kishon,
> 
> Am Donnerstag, 1. März 2018, 16:25:10 CET schrieb Enric Balletbo i Serra:
>> Right now the rockchip type-c phy does fail probing when no extcon is
>> detected. Some boards get the cable-state via the extcon interface and
>> have this supported, other boards seem to use the fusb302 chip or
>> another but the driver currently does not seem to utilize the extcon
>> interface to report the cable-state. And, other, just connect the type-c
>> to a standard USB-A port so use no controller at all. A missing extcon
>> shouldn't fail to probe, instead, should just fall back to working in
>> host-mode if it cannot get the extcon.
>>
>> Fixes: c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port
>> support for rk3399") Reported-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
> 
> Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> 
> I did revert the original commit mentioned in the fixes tag for 4.16-rc
> but it would nevertheless be really cool if these 2 patches (code + binding)
> could make it into your tree for 4.17 :-)
> 
> And ideally also with the other 5 patches from Enric starting at
> 	[PATCH v3 1/6] phy: rockchip-typec: deprecate some DT properties for various register fields.
> 
> from 2018-02-16.

merged now, thanks!

-Kishon

  reply	other threads:[~2018-03-16  5:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 15:25 [PATCH v2 0/6] phy: rockchip-typec: fix boards that does not report cable-state Enric Balletbo i Serra
2018-03-01 15:25 ` [PATCH v2 1/6] phy: rockchip-typec: fall back to working in host-mode if extcon is missing Enric Balletbo i Serra
2018-03-14  8:14   ` Heiko Stübner
2018-03-16  5:59     ` Kishon Vijay Abraham I [this message]
2018-03-01 15:25 ` [PATCH v2 2/6] dt-bindings: phy-rockchip-typec: move extcon property to be optional Enric Balletbo i Serra
2018-03-07 19:34   ` Rob Herring
2018-03-07 19:42     ` Alexandru Stan
2018-03-01 15:25 ` [PATCH v2 3/6] arm64: dts: rockchip: enable typec-phy for rk3399-sapphire Enric Balletbo i Serra
2018-03-03 11:17   ` Vicente Bergas
2018-03-16 10:38   ` Heiko Stuebner
2018-03-01 15:25 ` [PATCH v2 4/6] arm64: dts: rockchip: enable typec-phy for rk3399-firefly Enric Balletbo i Serra
2018-03-16 10:38   ` Heiko Stuebner
2018-03-01 15:25 ` [PATCH v2 5/6] arm64: dts: rockchip: enable typec-phy1 for rk3399-puma Enric Balletbo i Serra
2018-03-02 19:49   ` klaus.goger
2018-03-16 10:39   ` Heiko Stuebner
2018-03-01 15:25 ` [PATCH v2 6/6] arm64: dts: rockchip: enable typec-phy0 for rk3399-puma-haikou Enric Balletbo i Serra
2018-03-02 19:49   ` klaus.goger
2018-03-16 10:39   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32f24fca-7d89-6edf-26a4-8dc7d1d1ea31@ti.com \
    --to=kishon-l0cymroini0@public.gmane.org \
    --cc=enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    --cc=groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=gwendal-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox