From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E2E6C021B8 for ; Tue, 25 Feb 2025 16:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=koW+Lzv5TwdR3bs3YbFCypbEMxVZhQN8x3XzxkpUwQI=; b=DxBkbmZbnolEk7 UER1sDLamAKQTUx+3TBBAAmI9mhhi8N2jefgl5tBY2HytVmA3Pt1Tg8pQZVWcoTpIaog25MvM2OmC 1IbVMvvxGmYkJHv3Ea8YH2MDDLAWRo/ywgmAjMHfgJW3G7vdY1e1lGelDyjTZSsltlzSwnmlYq4/+ CokPjDrTaRifY50ANvpI5mDgyetO10eQskTnBu+7maIPaqG/dOHem4QdYdIiKy5Rbty9joPY6P8fM 5Syqz85HlI5tUAXpzv2ARTbbSgG1olIzyJtQ9R9zsjX2mIInyIOA8i3YojGIqDDNuqk2Fe8dy+YMe HrbXAvPeO5f2IUhXbAgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tmy0u-00000000LRa-3e4f; Tue, 25 Feb 2025 16:42:32 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tmwP1-000000000Rp-1BMH; Tue, 25 Feb 2025 14:59:20 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1740495509; cv=none; d=zohomail.com; s=zohoarc; b=mQbs+nNywvchZFCL9JymH2C8Mfwg6UtxLkIBKFfXH+OgT3Er9z92reIXwwZDlCaXzBFGSqFUCB99RUbDPDI/jH3WgyxTy4695bkfa6stVdnU5tJI0DQqp40daOjUrBm7+EtUQ3nTgFTVt+I2k4fZ4NVcdvFExsYLShEv9OZYZV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1740495509; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=UPm7l3RiX1WuCB7tMXcd8twnqxK37m3RDu2nnogmkfY=; b=Z1XR4CWew3aD4t4Sl2nhyLbmcHwGn6emwSBsGnQO4/8UYJ4FvFwU/i0mQtXSRjC2zqlZvgUcmqM6KxF++fN8GPX/3fB0QueOEHTN8xQy/KcMO9+qDfo/VPaTs6w43L6R8BNnjGZbfA8KpgHrTuH/6H4kZvUtNffCy0svlZDWdkY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=detlev.casanova@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1740495509; s=zohomail; d=collabora.com; i=detlev.casanova@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=UPm7l3RiX1WuCB7tMXcd8twnqxK37m3RDu2nnogmkfY=; b=VAtgprLNucRCs34k6jFRYcQYth7SSrgIubTX93w+NZ99KalCH1glGXW/gwR57Tvb 0xUz4CDDIKPg8yiKI5lCp8PLmGSnz7UYqMxGjLOaAnvcLRKb6TWugknX5lkX+zvm6K8 yMWQOyM3tOBj57i8GNs9LywGwbqDneKv9XS995cQ= Received: by mx.zohomail.com with SMTPS id 1740495506960426.84058732469487; Tue, 25 Feb 2025 06:58:26 -0800 (PST) From: Detlev Casanova To: Kuninori Morimoto Cc: Piotr Oniszczuk , linux-kernel@vger.kernel.org, Algea Cao , Heiko Stuebner , Geert Uytterhoeven , dri-devel@lists.freedesktop.org, Niklas Cassel , Laurent Pinchart , Andrzej Hajda , kernel@collabora.com, David Airlie , Dragan Simic , Simona Vetter , Rob Herring , Robert Foss , Sebastian Reichel , Jernej Skrabec , Sugar Zhang , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , FUKAUMI Naoki , devicetree@vger.kernel.org, Conor Dooley , Jonas Karlman , Maarten Lankhorst , Maxime Ripard , Dmitry Baryshkov , Johan Jonker , linux-arm-kernel@lists.infradead.org, Neil Armstrong , Alexey Charkov , Thomas Zimmermann , Krzysztof Kozlowski Subject: Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC Date: Tue, 25 Feb 2025 09:58:23 -0500 Message-ID: <3337030.aeNJFYEL58@trenzalore> In-Reply-To: <8734g2sg4t.wl-kuninori.morimoto.gx@renesas.com> References: <20250217215641.372723-1-detlev.casanova@collabora.com> <87frk2sumw.wl-kuninori.morimoto.gx@renesas.com> <8734g2sg4t.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250225_065919_379597_B9703610 X-CRM114-Status: GOOD ( 20.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Morimoto-san, On Tuesday, 25 February 2025 01:16:50 EST Kuninori Morimoto wrote: > Hi Detlev, again > > > > Especially those commits: > > > ASoC: audio-graph-card2: use __free(device_node) for device node > > > ASoC: audio-graph-card: use __free(device_node) for device node > > > ASoC: simple-card: use __free(device_node) for device node > > > > I got same report from our test team. I'm now tring to solve it. > > Unfortunately, I can't reproduce the issue on my environment, > but I guess I found the root cause. Does attached patch can solve > your issue ? >From what I see, the error is not present anymore on linux 6.14-rc4. I tried reverting your patch "ASoC: simple-card-utils.c: add missing dlc->of_node" (dabbd325b25edb5cdd99c94391817202dd54b651) and the error reappears. On 6.14-rc3, any of your patches (dabbd325b25e, or the one you attached here) will fix the issue and on 6.14-rc4, there is already a patch that fixes the issue. Also, since dabbd325b25e, the node indeed should be kept while the driver is used. So even though the issue reported here is fixed by another patch, both are likely needed. That being said, I'm not sure I completely understand why that extra line fixes the issue. Is the __free() attribute smart enough to know that the pointer has been copied and not free it at the end of scope ? > I will officially post the patch to ML, but want to confirm it before it. > > Thank you for your help !! Thank you for looking into this too :) Detlev. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip