From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C14A7CF34A9 for ; Wed, 19 Nov 2025 12:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t8WsR8iiGeGbXr3KDSRzmjVVeyrpZ3q8frQD7aAGALw=; b=HZ2Hh/ad+wvyrw t+keIvzlCWS2rOyY1gKQ9fIZpFXAhmoB7fbBAj53qKLd3KZgVES97xOx3g0hGlJVPB79NY1Up91+/ f1DqoTsgXYcvZbLPhyKqi8tD+rd4O8qf9WpCGFSryLJXpsQWTNquZojOA9gI/pJUM3A7bLQPcucUC dWuBCZzxzyVo0fc5kVuHKz9sjLjRk8x1mxn7V0qH3SZKVzHxhtPuNTcJloUlod22jeYSt5B0IxcRu /Zfge12kvoPyxM8avLRf9H2kyKPfRkY48AH9qNSBiU+ASdLQA4y1xGyo+tBtqjdPVdlYfJ2mbPKyV UJFzDyLGSyNnHQ6AkHrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLhcI-00000003C5O-1Lg9; Wed, 19 Nov 2025 12:48:58 +0000 Received: from sender3-pp-f112.zoho.com ([136.143.184.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLhcG-00000003C4h-1jbc; Wed, 19 Nov 2025 12:48:57 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1763556504; cv=none; d=zohomail.com; s=zohoarc; b=lGobB1qzJH7GzM6uI4HVkLOh1I8pze/y3j2P/PELoKydjwc5GfaMuw/8BCAe0HLK++VNtQlqzj9efmuG5+NNKhL+gyi2ygvlZuemgfuv2Md3+wMH0dacCKqc8Lk3P9mcxSgJHo99P/1gyvd3gjqKhhWlBK59ib36dJhrviZhSBI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763556504; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Uq6952CT/UldDXXHAirV2OkWzCY9Znw+41wgffkpeTY=; b=if/xx65+ObdoqBB2lsNN1N4+4YNqAMP+VFa6FpQ/bGv7q6FHapta/xqEHArWftd45ruq4dSHSRNOEYJrRqGBnLDr5ideAZxu1LJn0jZWH5xltlpA8wOHXz+b55xDImQkcuPfGqVFC6Tqdq8SgHNgMqLabGBL5WgZIPmrUR0L++w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1763556504; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=Uq6952CT/UldDXXHAirV2OkWzCY9Znw+41wgffkpeTY=; b=bcd1jJVY9PbUn0eoEylRY9GWSd38DpOpFitmJI2vpk1U6RvTBVZ0FUvhhkbFBncg n5i1ZsU3Ehq+ls857IUCPH5VjIjU7yC61XvEHXT1vGtswiEtoKU3+thvnl86IXwRl3q c1Bjd+TkP3B9aOgqQMYCJqIAV2icQ3WaatJlraG0= Received: by mx.zohomail.com with SMTPS id 1763556502200169.8816814936023; Wed, 19 Nov 2025 04:48:22 -0800 (PST) From: Nicolas Frattaroli To: Laurent Pinchart Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?UTF-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Marius Vlad Subject: Re: [PATCH v4 03/10] drm: Add enum conversion from/to HDMI_COLORSPACE to DRM_COLOR_FORMAT Date: Wed, 19 Nov 2025 13:48:13 +0100 Message-ID: <3356228.ElGaqSPkdT@workhorse> In-Reply-To: <20251119041648.GD10711@pendragon.ideasonboard.com> References: <20251117-color-format-v4-0-0ded72bd1b00@collabora.com> <20251117-color-format-v4-3-0ded72bd1b00@collabora.com> <20251119041648.GD10711@pendragon.ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251119_044856_521177_2D41A8D6 X-CRM114-Status: GOOD ( 25.71 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wednesday, 19 November 2025 05:16:48 Central European Standard Time Laurent Pinchart wrote: > On Mon, Nov 17, 2025 at 08:11:47PM +0100, Nicolas Frattaroli wrote: > > From: Marius Vlad > > > > This would please the compiler to have a enum transformation from one to > > another even though the values are the same. It should also make things > > The hdmi_colorspace enumerators are defined as (with comments added to > make the values explicit) > > enum hdmi_colorspace { > HDMI_COLORSPACE_RGB, /* 0 */ > HDMI_COLORSPACE_YUV422, /* 1 */ > HDMI_COLORSPACE_YUV444, /* 2 */ > HDMI_COLORSPACE_YUV420, /* 3 */ > HDMI_COLORSPACE_RESERVED4, /* 4 */ > HDMI_COLORSPACE_RESERVED5, /* 5 */ > HDMI_COLORSPACE_RESERVED6, /* 6 */ > HDMI_COLORSPACE_IDO_DEFINED, /* 7 */ > }; > > and the DRM color formats as (after patch 02/10) > > enum drm_color_format { > DRM_COLOR_FORMAT_NONE = 0, /* 0 */ > DRM_COLOR_FORMAT_RGB444 = (1 << 0), /* 1 */ > DRM_COLOR_FORMAT_YCBCR422 = (1 << 1), /* 2 */ > DRM_COLOR_FORMAT_YCBCR444 = (1 << 2), /* 4 */ > DRM_COLOR_FORMAT_YCBCR420 = (1 << 3), /* 8 */ > /* auto case, driver will set the color_format */ > DRM_COLOR_FORMAT_AUTO = (1 << 4), /* 16 */ > }; > > Contrary to what is stated in the commit message, the values are not the > same. Maybe you confused DRM_COLOR_FORMAT_* with DRM_MODE_COLOR_FORMAT_* > ? It's possible the equality got lost during my refactor, but I think the needless enum conversions between like 4 different things should be minimised anyway, so I'll look into getting rid of as much of this as possible. > > > obvious that we use different enums. > > > > Signed-off-by: Marius Vlad > > --- > > drivers/gpu/drm/drm_connector.c | 18 ++++++++++++++++++ > > include/drm/drm_connector.h | 3 +++ > > 2 files changed, 21 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > > index 0ad7be0a2d09..61c077b67ac3 100644 > > --- a/drivers/gpu/drm/drm_connector.c > > +++ b/drivers/gpu/drm/drm_connector.c > > @@ -1384,6 +1384,24 @@ drm_color_format_enum_to_color_format(enum drm_color_format_enum fmt_enum) > > } > > } > > > > +enum hdmi_colorspace > > +color_format_to_hdmi_colorspace(enum drm_color_format fmt) > > +{ > > + switch (fmt) { > > + default: > > + case DRM_COLOR_FORMAT_AUTO: > > + case DRM_COLOR_FORMAT_RGB444: > > + return HDMI_COLORSPACE_RGB; > > + case DRM_COLOR_FORMAT_YCBCR444: > > + return HDMI_COLORSPACE_YUV444; > > + case DRM_COLOR_FORMAT_YCBCR422: > > + return HDMI_COLORSPACE_YUV422; > > + case DRM_COLOR_FORMAT_YCBCR420: > > + return HDMI_COLORSPACE_YUV420; > > + } > > +} > > +EXPORT_SYMBOL(color_format_to_hdmi_colorspace); > > + > > /** > > * drm_get_color_format_name - return a string for color format > > * @colorspace: color format to compute name of > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > > index a071079fd3ad..e044976c8d76 100644 > > --- a/include/drm/drm_connector.h > > +++ b/include/drm/drm_connector.h > > @@ -2586,6 +2586,9 @@ drm_color_format_to_color_format_enum(enum drm_color_format fmt); > > u32 > > drm_color_format_enum_to_color_format(enum drm_color_format_enum fmt_enum); > > > > +enum hdmi_colorspace > > +color_format_to_hdmi_colorspace(enum drm_color_format fmt); > > + > > /** > > * drm_for_each_connector_iter - connector_list iterator macro > > * @connector: &struct drm_connector pointer used as cursor > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip