From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3B57C2A072 for ; Mon, 5 Jan 2026 08:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JO0DlnJkXoH12H90J/V8WMkW0ub6Q2vtEU/2ucQ3U+o=; b=af4EU2uFhtaj2a Z7741hpnRG+9zamjAHt5rnPYoG0nqQii+9bPeKT+HQjWyrKyDS9G5SO4MDkMbTl7UaOh9CrNxvqp7 FsZzsmYBxioiOFYdDXPaZAoCIyEc2k7AuVWp6Z+ay+jf8kDalvBB7THLGmbYpYZRHYWQDfIgTKgbL sgO4mMW6/Qjg8Cvibd0bni9M6LwThAvr3wl2iakrDJuI7vZl3FU7ajyCqAj3p7gu6wzhbwRwe3Po9 hYEXSMBC7f9WW97WRQgosoTxv5lap5hl909FfHAycDcaVtv5wv+muVIz2QVl5rg+jqqU/aOdox3O0 84IN+rfLWq8reyU2T2eQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vcfiP-0000000AxvU-2INF; Mon, 05 Jan 2026 08:13:25 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vcfiN-0000000AxuT-0YrV; Mon, 05 Jan 2026 08:13:24 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1767600797; cv=none; d=zohomail.com; s=zohoarc; b=QdXw+QBWdhHBaWDiWFCWRqp8L+hYjX48wt7hN0jhvuqlM+QjKbEydSKgepGKrysb0g02n/qjNMtj7W38+H7Bm63L8kgu8e74YVxpEB6hBRRsHloZNlB1u+/mxigvOVnEBJnxV4odBvWY5W+Erq0n6NhFddo8zKOywom5tjNeXd8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767600797; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=bLisPGbELcHPPEG+rKVCKDHWdvS62k1e+Z4DLqfCveA=; b=lGWzhNoUQidxBINUgLQUoiRL0vUBXDEBsXrl9UsceHxsgqjU36LoQZ1cBKPWryukec7duDtsWsUAbqrkbUbPJIRrmEWnqzX7DN5WCIzUSXsy/INykBYbolCUSsRHYkw3edSO0ylTo+ZgOAkezTKK9At759BwzK5DmENZRR6mRgo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1767600797; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=bLisPGbELcHPPEG+rKVCKDHWdvS62k1e+Z4DLqfCveA=; b=WUprz+W2XfKk41Wqqox8kwJn9wpR2m1ClYf8aopBTRnCIuE6iyBt2fSZw9UcYpGW IuLMILv/GPmYgXzm3hruPc8BueLicwR5BvwuzzUHSxN6nz6GporC3T/grAfTKVZw1d1 pMbrr0WBKn8fiE25aaMB2BITBFWP5q1/pbB6rxas= Received: by mx.zohomail.com with SMTPS id 176760079557383.79032239597313; Mon, 5 Jan 2026 00:13:15 -0800 (PST) From: Nicolas Frattaroli To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chaoyi Chen , Kever Yang , Sebastian Reichel , Cristian Ciocaltea , Frank Wang , Alexey Charkov , Liang Chen , Finley Xiao , Elaine Zhang , Yifeng Zhao , Chaoyi Chen Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: Fix wrong register range of rk3576 gpu Date: Mon, 05 Jan 2026 09:13:11 +0100 Message-ID: <3395202.44csPzL39Z@workhorse> In-Reply-To: <010a23e0-4f55-431f-ba34-7b28ff5df43a@rock-chips.com> References: <20251230090246.46-1-kernel@airkyi.com> <5954009.DvuYhMxLoT@workhorse> <010a23e0-4f55-431f-ba34-7b28ff5df43a@rock-chips.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260105_001323_223278_A3C745D8 X-CRM114-Status: GOOD ( 23.91 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Monday, 5 January 2026 09:12:00 Central European Standard Time Chaoyi Chen wrote: > Hello Nicolas, > > On 1/5/2026 3:55 PM, Nicolas Frattaroli wrote: > > On Tuesday, 30 December 2025 10:02:46 Central European Standard Time Chaoyi Chen wrote: > >> From: Chaoyi Chen > >> > >> According to RK3576 TRM part1 page13, the size of the GPU registers > >> is 128 KB. > >> > >> Fixes: 57b1ce903966 ("arm64: dts: rockchip: Add rk3576 SoC base DT") > >> Signed-off-by: Chaoyi Chen > >> --- > >> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > >> index 6284e7bdc442..b375015f0662 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi > >> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > >> @@ -1271,7 +1271,7 @@ power-domain@RK3576_PD_VO1 { > >> > >> gpu: gpu@27800000 { > >> compatible = "rockchip,rk3576-mali", "arm,mali-bifrost"; > >> - reg = <0x0 0x27800000 0x0 0x200000>; > >> + reg = <0x0 0x27800000 0x0 0x20000>; > >> assigned-clocks = <&scmi_clk SCMI_CLK_GPU>; > >> assigned-clock-rates = <198000000>; > >> clocks = <&cru CLK_GPU>; > >> > > > > This is only true if you only consider the GPU_CONTROL and > > JOB_CONTROL register ranges, and leave out the MMU_STAGE1 > > and MMU_STAGE2 ranges. I don't know if those need to be > > mapped, since the MMU control registers are < 0x2000. > > > > What do other bifrost devices do? > > > > I don't quite understand your point. And this size is 0x20000, > not 0x2000. Before the change it was 0x200000, which overlaps the > address space of some hardware that comes after it like JPEG. > > Could you explain it again? Thank you. Oops, I misread. You are correct, there's one too many zeroes, and I thought you removed one too many. :) Reviewed-by: Nicolas Frattaroli > > > Kind regards, > > Nicolas Frattaroli > > > > > > > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip