From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87B2EC25B75 for ; Fri, 31 May 2024 23:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZRm0Ie9PabcMpi++NC7yjpMW2h8rzvvr3yso5ekRVt8=; b=Ov7fcZbwoGmWjt guVryMl8h2ipBhuFc1wweuLIiAj4vTcVHqlVaT+ldoxsDqXgqjuSlONlpAd3K68KsI7zWdVWx16xJ Q7k7MXc8FQFiF6LkJaU+D3B4crLCgSTqHBBAxXhfLXd5dVP/ZLhQRW6+lzVesLkddrfI5mkPa2Vlf Cnot51gbBMY19ZSiPYKpFMWHDOT5cfyG48ITY7prXfoSIugoGHYuY593IbprLY01+Jpdg/VIqq5i5 MM7NImcOqXf2S44TERSUmM96PZCqLuK0S4Dpu4Snz42T/ygrISfgF6Dibp/JuyWGf5JSpnTr3K0v/ pcIzf+AWZMfjdY5DTeIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sDBT8-0000000Beq6-46nb; Fri, 31 May 2024 23:15:30 +0000 Received: from smtp.forwardemail.net ([149.28.215.223]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sDBT5-0000000BeoO-3Kjf for linux-rockchip@lists.infradead.org; Fri, 31 May 2024 23:15:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1717197310; bh=NT5VlfpAzQy5RqRKCg0k7PinYB0pq9c+JH44HfHvY7g=; b=eluFq7dWDBPkW+exCejdkAN4T+k2Y9LF/M8JHAC2ell/udmPgto3k/ewXzaafSlaa5EGEGY4+ QZe1o426QDPplYp3Hw1+4UTC1zuLAKb4s06xn7ke5zNoprAk8wogymAERT/AhwrIzJkdijiD/Y6 m43Z0asJr2R1xJKf4R35tjNUgTdF+znt4+U6ic/8rtOpCe5B0y9YzW68gsVzMpBod84zzMFep+n etLENzhCsIgcLWXnS4Mo5Ug/PYrXFJ2DHjo+MsbY/zt4owuMqmjgkIyRRPEcpZWXoY/rmuBabWS oibkrfBV+Yd7gsA1QNHdm2wXX5KEUXZORKWbp8PtkmOw== Message-ID: <33ee8446-aa01-47df-8e20-5ae2d384ed0e@kwiboo.se> Date: Sat, 1 Jun 2024 01:15:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] arm64: dts: rockchip: Make preparations for per-RK3588-variant OPPs To: Dragan Simic Cc: Alexey Charkov , linux-rockchip@lists.infradead.org, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, quentin.schulz@cherry.de, wens@kernel.org, daniel.lezcano@linaro.org, didi.debian@cknow.org, krzysztof.kozlowski+dt@linaro.org, viresh.kumar@linaro.org References: <673dcf47596e7bc8ba065034e339bb1bbf9cdcb0.1716948159.git.dsimic@manjaro.org> <8f8623e29a479c4108141302e708dc3b@manjaro.org> <166cc4e46f31644a50306625b2ab18a6@manjaro.org> <82db817a908b761d8c3d73ea04714314@manjaro.org> <607f4da8-99b2-4379-9567-4bfd2744eab3@kwiboo.se> <66677077acf4e970444cea829436fd0a@manjaro.org> Content-Language: en-US From: Jonas Karlman In-Reply-To: <66677077acf4e970444cea829436fd0a@manjaro.org> X-Report-Abuse-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Complaints-To: abuse@forwardemail.net X-ForwardEmail-Version: 0.4.40 X-ForwardEmail-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 149.28.215.223 X-ForwardEmail-ID: 665a59fe0b82eeef13908f0a X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240531_161528_303193_331F5981 X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Dragan, On 2024-05-31 23:24, Dragan Simic wrote: > Hello Jonas, > > On 2024-05-31 13:27, Jonas Karlman wrote: >> On 2024-05-30 21:31, Dragan Simic wrote: >> [snip] >> >>>>>>> That way we'll have no roadblocks if, at some point, we end up >>>>>>> with >>>>>>> having >>>>>>> different OPPs defined for the RK3588 and the RK3588S variants. >>>>>>> Or >>>>>>> maybe >>>>>>> even for the RK3582, which we don't know much about yet. >>>>>> >>>>>> Guess we'll deal with that one once we stumble upon an actual >>>>>> RK3582 >>>>>> board out in the wild and heading to the mainline kernel tree :) >>>>> >>>>> Of course, that was just an example for the future use. >>>> >>>> In fact, I've just discovered that Radxa has recently released Rock >>>> 5C >>>> Lite which is based on RK3582, and starts at just $29 for the 1GB >>>> version, making it interesting for tinkering. Especially given that >>>> its GPU, one of the big-core clusters and one of the VPU cores seem >>>> to >>>> be disabled in software (u-boot) rather than in hardware, which means >>>> there is some chance that a particular SoC specimen would actually >>>> have them in a working condition and possible to re-enable at no >>>> cost. >>>> Ordered myself one to investigate :) >>> >>> Yes, I also saw the RK3582-based ROCK 5C Lite a couple of days ago. :) >>> It seems that the disabled IP blocks are detected as defective during >>> the manufacturing, which means that they might work correctly, or >>> might >>> actually misbehave. It seems similar to the way old three-core AMD >>> Phenom II CPUs could sometimes be made quad-core. >> >> I can confirm that the RK3582 include ip-state in OTP indicating >> unusable cores, any unusable cpu core cannot be taken online and stalls >> Linux kernel a few extra seconds during boot. > > Thanks for this confirmation! > >> Started working on a patch for U-Boot to remove any broken cpu core >> and/or cluster nodes, similar to what vendor U-Boot does, adopted to >> work with a mainline DT for RK3588. > > Nice, thanks for working on that. :) > >> On one of my ROCK 5C Lite board one of the cpu cores is unusable, >> U-Boot >> removes the related cpu cluster nodes. On another ROCK 5C Lite board >> one >> rkvdec core is only marked unusable and all cpu cores can be taken >> online, U-Boot does nothing in this case. Guessing we should apply >> similar policy as vendor U-Boot and disable cores anyway. > > Just checking, you're referring to disabling the rkvdec core only, > for the latter case? No, the vendor U-Boot will remove cluster2 if no cpu core is bad. RK3582 policy: - always remove gpu node - always remove both rkvdec nodes - remove bad rkvenc node, if both are normal, remove rkvenc1 anyway RK3583 policy: - remove bad rkvdec node, if both are normal, remove rkvdec1 anyway - remove bad rkvenc node, if both are normal, remove rkvenc1 anyway CPU core policy: - remove both cores within a cluster having a bad core - if core4~7 are all normal, remove core6 and core7 anyway Regards, Jonas > >> Following commit contains early work-in-progress and some debug output. >> >> https://github.com/Kwiboo/u-boot-rockchip/commit/8cdf606e616baa36751f3b4adcfaefc781126c8c >> >> Booting ROCK 5C Lite boards using U-Boot generic-rk3588_defconfig: >> >> ROCK 5C Lite v1.1 (RK3582 with 1 bad cpu core): >> >> cpu-code: 3582 >> cpu-version: 08 10 >> data: fe 21 >> package: 11 >> specification: 01 >> ip-state: 10 00 00 >> bad-state: cpu core 4 >> >> ROCK 5C Lite v1.1 (RK3582 with 1 bad rkvdec core): >> >> cpu-code: 3582 >> cpu-version: 08 00 >> data: fe 21 >> package: 11 >> specification: 01 >> ip-state: 00 80 00 >> bad-state: rkvdec core 1 > > Thanks again for these nice details! _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip