From: Robin Murphy <robin.murphy@arm.com>
To: "Vicente Bergas" <vicencb@gmail.com>,
"Doug Anderson" <dianders@chromium.org>,
crj <algea.cao@rock-chips.com>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 0/3] drm: rockchip: hdmi: enable higher resolutions than FHD
Date: Wed, 23 Sep 2020 23:18:20 +0100 [thread overview]
Message-ID: <340b1e7f-9149-3dcc-e6a3-74ab02fcc6e5@arm.com> (raw)
In-Reply-To: <20200922203107.2932-1-vicencb@gmail.com>
On 2020-09-22 21:31, Vicente Bergas wrote:
> This patch series enable a QHD HDMI monitor to work at native resolution.
> Tested on a Sapphire board with RK3399 connected to a Q27q-10 monitor at 2560x1440@60
Indeed for RK3399 it also allows my 1920x1200 monitor (Dell U2415) to be
driven at its native resolution with a 154MHz pixel clock. However, as
predicted, it also breaks RK3328 for the same monitor - instead of
rejecting the native mode and falling back to "standard" 1920x1080, it
now tries to use it, which results in no signal and a spam of CRTC
timeout warnings in dmesg :(
I'll try to test RK3288 as well soon - I tried hacking a specific entry
for 154MHz into the tables a while ago, and while it worked perfectly on
RK3399, RK3288 gave a fairly glitchy picture as if the clock signal was
unstable or slightly out of spec. I'm interested to see if patch #1
makes any difference there.
Thanks,
Robin.
>
> Changes since v1:
> Use alternative clock rounding code proposed by Doug Anderson
>
> Vicente Bergas (3):
> drm: rockchip: hdmi: fix clock rounding code
> drm: rockchip: hdmi: allow any clock that is within the range
> drm: rockchip: hdmi: add higher pixel clock frequencies
>
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 8 +++++++-
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 7 ++-----
> 2 files changed, 9 insertions(+), 6 deletions(-)
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2020-09-23 22:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 20:31 [PATCH v2 0/3] drm: rockchip: hdmi: enable higher resolutions than FHD Vicente Bergas
2020-09-22 20:31 ` [PATCH v2 1/3] drm: rockchip: hdmi: fix clock rounding code Vicente Bergas
2020-09-23 1:37 ` crj
2020-09-23 22:58 ` Doug Anderson
2020-09-23 22:55 ` Doug Anderson
2020-09-22 20:31 ` [PATCH v2 2/3] drm: rockchip: hdmi: allow any clock that is within the range Vicente Bergas
2020-09-22 20:31 ` [PATCH v2 3/3] drm: rockchip: hdmi: add higher pixel clock frequencies Vicente Bergas
2020-09-23 22:18 ` Robin Murphy [this message]
2020-09-23 23:25 ` [PATCH v2 0/3] drm: rockchip: hdmi: enable higher resolutions than FHD Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=340b1e7f-9149-3dcc-e6a3-74ab02fcc6e5@arm.com \
--to=robin.murphy@arm.com \
--cc=airlied@linux.ie \
--cc=algea.cao@rock-chips.com \
--cc=andy.yan@rock-chips.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox