From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F40FC77B73 for ; Mon, 8 May 2023 08:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZJwDibFKB4PVYqxaKrsGuusGjJePbjspj9GlBW/Ym7g=; b=E/dJXC7aHpkc/P yKE0xvRc6oRLGELd75mLH71qWlvuDo41HSNDWZ7goAae1u64YYAsKX+bNgjh1RG/IdAB4EfHtVHE+ SxLgQiTLZIAtJJA1iQwaj44BrzUMUONygZDVP24tCGRNWQaHsKiXi8a6R2OsbpMzmF/ssxhnWF7wN WHG8s02lhI0K2khrDDUbLs2z+ZU6ngVuDenGVl24gTvY05MUqQ0EHG8tK/f+HnPOSEmCDFFeyD80Y LFDV1HbBZTtUPvLssyE247yfrcPWT88NnyvZ3eHFsnjLOnMpkFPXpBemodd1Kfwv75PBbEjxI+IRm N2Ltu+Vw/k/IFAJxmvBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pvwAF-00HZWg-1n; Mon, 08 May 2023 08:24:11 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pvwAC-00HZUs-20; Mon, 08 May 2023 08:24:09 +0000 Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pvwA6-0003KZ-6D; Mon, 08 May 2023 10:24:02 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sandy Huang , David Airlie , Daniel Vetter , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH 38/53] drm/rockchip: Convert to platform remove callback returning void Date: Mon, 08 May 2023 10:24:01 +0200 Message-ID: <3495460.iIbC2pHGDl@diego> In-Reply-To: <20230507162616.1368908-39-u.kleine-koenig@pengutronix.de> References: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> <20230507162616.1368908-39-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230508_012408_658485_E7B9C70B X-CRM114-Status: GOOD ( 12.47 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Sonntag, 7. Mai 2023, 18:26:01 CEST schrieb Uwe Kleine-K=F6nig: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert rockchip drm drivers from always returning zero in the > remove callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Heiko Stuebner _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip