Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

Javier Martinez Canillas
2023-09-09T14:39:36Z

Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:

Hello Uwe,

> Hello,
>
> this patch series adapts the platform drivers below drivers/gpu/drm
> to use the .remove_new() callback. Compared to the traditional .remove()
> callback .remove_new() returns no value. This is a good thing because
> the driver core doesn't (and cannot) cope for errors during remove. The
> only effect of a non-zero return value in .remove() is that the driver
> core emits a warning. The device is removed anyhow and an early return
> from .remove() usually yields a resource leak.
>
> By changing the remove callback to return void driver authors cannot
> reasonably (but wrongly) assume any more that there happens some kind of
> cleanup later.
>
> Best regards
> Uwe
>
> Uwe Kleine-König (53):

[...]

> drm/imx/ipuv3: Convert to platform remove callback returning void
> drm/ingenic: Convert to platform remove callback returning void

[...]

> drm/mediatek: Convert to platform remove callback returning void
> drm/mediatek: Convert to platform remove callback returning void

[...]

> drm/msm: Convert to platform remove callback returning void

[...]

> drm/shmobile: Convert to platform remove callback returning void

Pushed these to drm-misc (drm-misc-next). Thanks!

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat