From: "Heiko Stübner" <heiko@sntech.de>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Phil Edworthy" <phil.edworthy@renesas.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 40/49] mtd: rawnand: rockchip: Convert to platform remove callback returning void
Date: Sat, 01 Apr 2023 21:04:46 +0200 [thread overview]
Message-ID: <3562741.hdfAi7Kttb@diego> (raw)
In-Reply-To: <20230401161938.2503204-41-u.kleine-koenig@pengutronix.de>
Am Samstag, 1. April 2023, 18:19:29 CEST schrieb Uwe Kleine-König:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-04-01 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 16:18 [PATCH 00/49] mtd: nand: Convert to platform remove callback returning void Uwe Kleine-König
2023-04-01 16:19 ` [PATCH 40/49] mtd: rawnand: rockchip: " Uwe Kleine-König
2023-04-01 19:04 ` Heiko Stübner [this message]
2023-04-03 16:29 ` [PATCH 00/49] mtd: nand: " Tudor Ambarus
2023-04-07 8:10 ` Miquel Raynal
2023-04-08 18:53 ` [PATCH] " Uwe Kleine-König
2023-04-10 5:37 ` Tudor Ambarus
2023-04-11 8:20 ` Miquel Raynal
2023-04-11 11:11 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3562741.hdfAi7Kttb@diego \
--to=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=phil.edworthy@renesas.com \
--cc=richard@nod.at \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox