Re: [1/3] Device Tree for ASUS Tinker Board S

Re: [1/3] Device Tree for ASUS Tinker Board S

[Heiko Stuebner]

Hi David,

thanks for working on including the tinker-s.
Some comments below.

Am Sonntag, 2. September 2018, 12:04:48 CEST schrieb beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org:
> Hi,
> 
> The ASUS Tinker Board S : 
> https://www.asus.com/uk/Single-Board-Computer/Tinker-Board-S/
> 
> Is a variant on the original ASUS Tinker Board, the main difference 
> being that the "S" has eMMC.
> 
> This patchset sets up the device tree for the "S". It is based on the 
> patches used with the debian distribution which ships with the device : 
> https://github.com/TinkerBoard/debian_kernel/blob/develop/arch/arm/boot/dts/rk3288-miniarm.dts
> 
> So this is really just mainlining the support.
> 
> I've split the changed into three parts:

These general comments apply to all 3 of your patches:

(1) Please follow the general guildelines for sending patches, like
described in Documentation/process/5.Posting.rst in your kernel tree like:
- send output of "git format-patch"
- signed-off-by line
- full name as "from"
- ideally use "git send-email"
- no html mails
- no mangled content (your mail client replaced all tabs with spaces)

(2) Please keep things to lower cases. So name your board for
example rk3288-tinker-s.dts

(3) When adding a board, please also add a corresponding entry to
Documentation/devicetree/bindings/arm/rockchip.txt

(4) When adding a board variant - please don't simply copy devicetrees.
Instead ideally create a shared dtsi, that both the tinker.dts
and tinker-s can include.

For reference you can look at the Rock960 CE+EE patchset posted today:
https://patchwork.kernel.org/cover/10594427/

(5) Please add lists and maintainers. I'm missing
- linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
- Devicetree binding maintainers:
  - robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
  - mark.rutland-5wv7dgnIgG8@public.gmane.org


Thanks
Heiko

[1/3] Device Tree for ASUS Tinker Board S

[beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io]

Hi,

The ASUS Tinker Board S : 
https://www.asus.com/uk/Single-Board-Computer/Tinker-Board-S/

Is a variant on the original ASUS Tinker Board, the main difference 
being that the "S" has eMMC.

This patchset sets up the device tree for the "S". It is based on the 
patches used with the debian distribution which ships with the device : 
https://github.com/TinkerBoard/debian_kernel/blob/develop/arch/arm/boot/dts/rk3288-miniarm.dts

So this is really just mainlining the support.

I've split the changed into three parts:


1) This part - just creates a new dts file that is a copy of the tinker 
board, with just a name change
2) Changes needed to add the eMMC
3) Changes needed to enable wifi

This is the first patch I've done for linux - so if I've got anything 
wrong, just let me know and I'll correct.

Also any comments you have.

Regards,

David Summers

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index b5bd3de87c33..6f173506dbd8 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -864,6 +864,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
         rk3288-r89.dtb \
         rk3288-rock2-square.dtb \
         rk3288-tinker.dtb \
+       rk3288-tinkerS.dtb \
         rk3288-veyron-brain.dtb \
         rk3288-veyron-jaq.dtb \
         rk3288-veyron-jerry.dtb \

diff -up linux-rockchip/arch/arm/boot/dts/rk3288-tinker*.dts
--- linux-rockchip/arch/arm/boot/dts/rk3288-tinker.dts    2018-09-01 
13:16:55.637645728 +0100
+++ linux-rockchip/arch/arm/boot/dts/rk3288-tinkerS.dts 2018-09-02 
09:57:55.090964465 +0100
@@ -9,8 +9,8 @@
  #include <dt-bindings/input/input.h>

  / {
-    model = "Rockchip RK3288 Tinker Board";
-    compatible = "asus,rk3288-tinker", "rockchip,rk3288";
+    model = "Asus Rockchip RK3288 Tinker Board S";
+    compatible = "asus,rk3288-tinkerS", "rockchip,rk3288";

      chosen {
          stdout-path = "serial2:115200n8";

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip