Re:[PATCH RESEND] drm/rockchip: Unregister platform drivers in reverse order

From: "Andy Yan" <andyshrk@163.com>
To: "Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>
Cc: "Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Sean Paul" <seanpaul@chromium.org>,
	"Jeffy Chen" <jeffy.chen@rock-chips.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Mark Yao" <markyao0591@gmail.com>,
	kernel@collabora.com, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re:[PATCH RESEND] drm/rockchip: Unregister platform drivers in reverse order
Date: Mon, 12 Aug 2024 10:14:22 +0800 (CST)	[thread overview]
Message-ID: <3649004a.1f69.191445d79dc.Coremail.andyshrk@163.com> (raw)
In-Reply-To: <20240808-rk-drm-fix-unreg-v1-1-c30d9a754722@collabora.com>

Hi Cristian,

At 2024-08-08 19:58:02, "Cristian Ciocaltea" <cristian.ciocaltea@collabora.com> wrote:
>Move rockchip_drm_platform_driver unregistration after its sub-drivers,
>which ensures all drivers are unregistered in the reverse order used
>when they were registered.

Would you please provied some detail information about how to reproduce this
issue this patch try to fix？Or some kernel log when this issue   triggered。
>
>Fixes: 8820b68bd378 ("drm/rockchip: Refactor the component match logic.")
>Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>---
> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>index 44d769d9234d..ca7b07503fbe 100644
>--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>@@ -528,10 +528,9 @@ static int __init rockchip_drm_init(void)
> 
> static void __exit rockchip_drm_fini(void)
> {
>-	platform_driver_unregister(&rockchip_drm_platform_driver);
>-
> 	platform_unregister_drivers(rockchip_sub_drivers,
> 				    num_rockchip_sub_drivers);
>+	platform_driver_unregister(&rockchip_drm_platform_driver);
> }
> 
> module_init(rockchip_drm_init);
>
>---
>base-commit: 1eb586a9782cde8e5091b9de74603e0a8386b09e
>change-id: 20240702-rk-drm-fix-unreg-9f3f29996a00
>-- 
>Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip