From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 2/9] iommu: rockchip: make it explicitly non-modular Date: Tue, 27 Nov 2018 00:37:07 +0100 Message-ID: <3696101.6o5idU3W3V@phil> References: <1543271498-28966-1-git-send-email-paul.gortmaker@windriver.com> <1543271498-28966-3-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1543271498-28966-3-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Gortmaker Cc: Jeffy Chen , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Kurtz , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Am Montag, 26. November 2018, 23:31:31 CET schrieb Paul Gortmaker: > The Kconfig currently controlling compilation of this code is: > > drivers/iommu/Kconfig:config ROCKCHIP_IOMMU > drivers/iommu/Kconfig: bool "Rockchip IOMMU Support" > > ...meaning that it currently is not being built as a module by anyone. > > The bind/unbind/remove was already explicitly disabled in commit > 98b72b94def9 ("iommu/rockchip: Prohibit unbind and remove"). > > Lets remove the remaining traces of modular infrastructure, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Joerg Roedel > Cc: Heiko Stuebner > Cc: Simon Xue > Cc: Daniel Kurtz > Cc: Jeffy Chen > Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Signed-off-by: Paul Gortmaker Acked-by: Heiko Stuebner