From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v1 1/5] ARM: dts: rockchip: fix vqmmc-supply property name for rk3188-bqedison2qc Date: Wed, 11 Mar 2020 10:07:54 +0100 Message-ID: <37714750.JZCpAI0Cju@phil> References: <20200307134841.13803-1-jbx6244@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20200307134841.13803-1-jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johan Jonker Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Am Samstag, 7. März 2020, 14:48:37 CET schrieb Johan Jonker: > A test with the command below does not detect all errors > in combination with 'additionalProperties: false' and > allOf: > - $ref: "synopsys-dw-mshc-common.yaml#" > allOf: > - $ref: "mmc-controller.yaml#" > > 'additionalProperties' applies to all properties that are not > accounted-for by 'properties' or 'patternProperties' in > the immediate schema. > > First when we combine rockchip-dw-mshc.yaml, > synopsys-dw-mshc-common.yaml and mmc-controller.yaml it gives > this error: > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: mmc@10218000: > 'vmmcq-supply' does not match any of the regexes: > '^.*@[0-9]+$', > '^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)| > uhs-(sdr(12|25|50|104)|ddr50))$', > 'pinctrl-[0-9]+' > > 'vmmcq-supply' is not a valid property name for mmc nodes. > Fix this error by renaming it to 'vqmmc-supply'. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > > Signed-off-by: Johan Jonker applied all 5 for 5.7 Thanks Heiko