Re: [PATCH 3/7] iommu: Remove ops.pgsize_bitmap from drivers that don't use it

From: "Sven Peter" <sven@svenpeter.dev>
To: "Jason Gunthorpe" <jgg@nvidia.com>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	asahi@lists.linux.dev,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Lu Baolu" <baolu.lu@linux.intel.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Gerald Schaefer" <gerald.schaefer@linux.ibm.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	iommu@lists.linux.dev, "Janne Grunau" <j@jannau.net>,
	"Jean-Philippe Brucker" <jean-philippe@linaro.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Kevin Tian" <kevin.tian@intel.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-riscv@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Matthew Rosato" <mjrosato@linux.ibm.com>,
	"Neal Gompa" <neal@gompa.dev>, "Orson Zhai" <orsonzhai@gmail.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Niklas Schnelle" <schnelle@linux.ibm.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Tomasz Jeznach" <tjeznach@rivosinc.com>,
	"Krishna Reddy" <vdumpa@nvidia.com>,
	virtualization@lists.linux.dev, "Chen-Yu Tsai" <wens@csie.org>,
	"Will Deacon" <will@kernel.org>, "Yong Wu" <yong.wu@mediatek.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>
Cc: patches@lists.linux.dev
Subject: Re: [PATCH 3/7] iommu: Remove ops.pgsize_bitmap from drivers that don't use it
Date: Thu, 01 May 2025 21:07:44 +0200	[thread overview]
Message-ID: <38706b77-4e58-4dfb-add3-814746f4a3c5@app.fastmail.com> (raw)
In-Reply-To: <3-v1-7c5282b0c334+2db-iommu_rm_ops_pgsize_jgg@nvidia.com>

On Tue, Apr 29, 2025, at 16:34, Jason Gunthorpe wrote:
> These drivers all set the domain->pgsize_bitmap in their
> domain_alloc_paging() functions, so the ops value is never used. Delete
> it.
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  drivers/iommu/apple-dart.c       | 1 -
>  drivers/iommu/intel/iommu.c      | 1 -
>  drivers/iommu/iommufd/selftest.c | 1 -
>  drivers/iommu/riscv/iommu.c      | 1 -
>  drivers/iommu/virtio-iommu.c     | 6 ++----
>  5 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
> index 757d24f67ad45a..190f28d7661515 100644
> --- a/drivers/iommu/apple-dart.c
> +++ b/drivers/iommu/apple-dart.c
> @@ -991,7 +991,6 @@ static const struct iommu_ops apple_dart_iommu_ops = {
>  	.of_xlate = apple_dart_of_xlate,
>  	.def_domain_type = apple_dart_def_domain_type,
>  	.get_resv_regions = apple_dart_get_resv_regions,
> -	.pgsize_bitmap = -1UL, /* Restricted during dart probe */
>  	.owner = THIS_MODULE,
>  	.default_domain_ops = &(const struct iommu_domain_ops) {
>  		.attach_dev	= apple_dart_attach_dev_paging,

Reviewed-by: Sven Peter <sven@svenpeter.dev> # for Apple DART


Best,


Sven

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip